Patchwork [Oneirc,SRU] SAUCE: Bug#891270 drm/i915: add multi-threaded forcewake support

login
register
mail settings
Submitter Manoj Iyer
Date Nov. 21, 2011, 6:17 p.m.
Message ID <1321899444-5304-1-git-send-email-manoj.iyer@canonical.com>
Download mbox
Permalink /patch/126889/
State New
Headers show

Pull-request

git://kernel.ubuntu.com/manjo/ubuntu-oneiric.git lp891270

Comments

Manoj Iyer - Nov. 21, 2011, 6:17 p.m.
From: Manoj Iyer <manoj.iyer@canonical.com>

Please consider the following sauce patch to Oneiric. 

SRU JUSTIFICATION
================

ISSUE
=====
Ivybridge system fails to resume from S3/S4 with recent BIOS. On system resume causes kernel oops in i915 driver.

FIX
===
Upstream fixed the issue by adding multi-threaded forcewake support.
On IVB C0+ with newer BIOSes, the forcewake handshake has changed. There's
now a bitfield for different driver components to keep the GT powered
on. On Linux, we centralize forcewake handling in one place, so we
still just need a single bit, but we need to use the new registers if MT
forcewake is enabled.

TEST
=====
This patch was tested on Ivybridge system with the kernel posted at http://kernel.ubuntu.com/~sarvatt/fdo42923/ and the test results are noted in comment #3 in this bug, and also reported the same to https://bugs.freedesktop.org/show_bug.cgi?id=42923

The following changes since commit f0bba7483b90dabcf025dc923e0722f5ff9b5e6d:

  UBUNTU: SAUCE: drm/i915: add multi-threaded forcewake support (2011-11-21 11:37:20 -0600)

are available in the git repository at:
  git://kernel.ubuntu.com/manjo/ubuntu-oneiric.git lp891270

Manoj Iyer (1):
  UBUNTU: SAUCE: drm/i915: add multi-threaded forcewake support

 drivers/gpu/drm/i915/i915_drv.c      |   30 ++++++++++++++++++++++++++----
 drivers/gpu/drm/i915/i915_drv.h      |    8 ++++++++
 drivers/gpu/drm/i915/i915_reg.h      |    4 ++++
 drivers/gpu/drm/i915/intel_display.c |   22 ++++++++++++++++++++++
 4 files changed, 60 insertions(+), 4 deletions(-)
Seth Forshee - Nov. 22, 2011, 2:34 p.m.
On Mon, Nov 21, 2011 at 12:17:24PM -0600, manoj.iyer@canonical.com wrote:
> From: Manoj Iyer <manoj.iyer@canonical.com>
> 
> Please consider the following sauce patch to Oneiric. 
> 
> SRU JUSTIFICATION
> ================
> 
> ISSUE
> =====
> Ivybridge system fails to resume from S3/S4 with recent BIOS. On system resume causes kernel oops in i915 driver.
> 
> FIX
> ===
> Upstream fixed the issue by adding multi-threaded forcewake support.
> On IVB C0+ with newer BIOSes, the forcewake handshake has changed. There's
> now a bitfield for different driver components to keep the GT powered
> on. On Linux, we centralize forcewake handling in one place, so we
> still just need a single bit, but we need to use the new registers if MT
> forcewake is enabled.
> 
> TEST
> =====
> This patch was tested on Ivybridge system with the kernel posted at http://kernel.ubuntu.com/~sarvatt/fdo42923/ and the test results are noted in comment #3 in this bug, and also reported the same to https://bugs.freedesktop.org/show_bug.cgi?id=42923
> 
> The following changes since commit f0bba7483b90dabcf025dc923e0722f5ff9b5e6d:
> 
>   UBUNTU: SAUCE: drm/i915: add multi-threaded forcewake support (2011-11-21 11:37:20 -0600)
> 
> are available in the git repository at:
>   git://kernel.ubuntu.com/manjo/ubuntu-oneiric.git lp891270
> 
> Manoj Iyer (1):
>   UBUNTU: SAUCE: drm/i915: add multi-threaded forcewake support

It seems you still have the attribution problem that Tim pointed out
earlier, as this is showing you as the patch author. I also notice that
the patch from the mailing list has a description of what the patch is
doing and sign-offs, which I think we should be including.
Seth Forshee - Nov. 22, 2011, 2:36 p.m.
On Tue, Nov 22, 2011 at 08:34:38AM -0600, Seth Forshee wrote:
> On Mon, Nov 21, 2011 at 12:17:24PM -0600, manoj.iyer@canonical.com wrote:
> > From: Manoj Iyer <manoj.iyer@canonical.com>
> > 
> > Please consider the following sauce patch to Oneiric. 
> > 
> > SRU JUSTIFICATION
> > ================
> > 
> > ISSUE
> > =====
> > Ivybridge system fails to resume from S3/S4 with recent BIOS. On system resume causes kernel oops in i915 driver.
> > 
> > FIX
> > ===
> > Upstream fixed the issue by adding multi-threaded forcewake support.
> > On IVB C0+ with newer BIOSes, the forcewake handshake has changed. There's
> > now a bitfield for different driver components to keep the GT powered
> > on. On Linux, we centralize forcewake handling in one place, so we
> > still just need a single bit, but we need to use the new registers if MT
> > forcewake is enabled.
> > 
> > TEST
> > =====
> > This patch was tested on Ivybridge system with the kernel posted at http://kernel.ubuntu.com/~sarvatt/fdo42923/ and the test results are noted in comment #3 in this bug, and also reported the same to https://bugs.freedesktop.org/show_bug.cgi?id=42923
> > 
> > The following changes since commit f0bba7483b90dabcf025dc923e0722f5ff9b5e6d:
> > 
> >   UBUNTU: SAUCE: drm/i915: add multi-threaded forcewake support (2011-11-21 11:37:20 -0600)
> > 
> > are available in the git repository at:
> >   git://kernel.ubuntu.com/manjo/ubuntu-oneiric.git lp891270
> > 
> > Manoj Iyer (1):
> >   UBUNTU: SAUCE: drm/i915: add multi-threaded forcewake support
> 
> It seems you still have the attribution problem that Tim pointed out
> earlier, as this is showing you as the patch author. I also notice that
> the patch from the mailing list has a description of what the patch is
> doing and sign-offs, which I think we should be including.

Sorry, ignore this. I pulled up the wrong message, so I looked at the
old branch in your tree. I'll look at the right one this time :)
Manoj Iyer - Nov. 22, 2011, 3:25 p.m.
Seth,

I already resent the patches with correct attributions.

git://kernel.ubuntu.com/manjo/ubuntu-oneiric.git lp891270v2

Cheers


On Tue, 22 Nov 2011, Seth Forshee wrote:

> On Mon, Nov 21, 2011 at 12:17:24PM -0600, manoj.iyer@canonical.com wrote:
>> From: Manoj Iyer <manoj.iyer@canonical.com>
>>
>> Please consider the following sauce patch to Oneiric.
>>
>> SRU JUSTIFICATION
>> ================
>>
>> ISSUE
>> =====
>> Ivybridge system fails to resume from S3/S4 with recent BIOS. On system resume causes kernel oops in i915 driver.
>>
>> FIX
>> ===
>> Upstream fixed the issue by adding multi-threaded forcewake support.
>> On IVB C0+ with newer BIOSes, the forcewake handshake has changed. There's
>> now a bitfield for different driver components to keep the GT powered
>> on. On Linux, we centralize forcewake handling in one place, so we
>> still just need a single bit, but we need to use the new registers if MT
>> forcewake is enabled.
>>
>> TEST
>> =====
>> This patch was tested on Ivybridge system with the kernel posted at http://kernel.ubuntu.com/~sarvatt/fdo42923/ and the test results are noted in comment #3 in this bug, and also reported the same to https://bugs.freedesktop.org/show_bug.cgi?id=42923
>>
>> The following changes since commit f0bba7483b90dabcf025dc923e0722f5ff9b5e6d:
>>
>>   UBUNTU: SAUCE: drm/i915: add multi-threaded forcewake support (2011-11-21 11:37:20 -0600)
>>
>> are available in the git repository at:
>>   git://kernel.ubuntu.com/manjo/ubuntu-oneiric.git lp891270
>>
>> Manoj Iyer (1):
>>   UBUNTU: SAUCE: drm/i915: add multi-threaded forcewake support
>
> It seems you still have the attribution problem that Tim pointed out
> earlier, as this is showing you as the patch author. I also notice that
> the patch from the mailing list has a description of what the patch is
> doing and sign-offs, which I think we should be including.
>
>

--
====================
Manoj Iyer
Ubuntu/Canonical
Hardware Enablement
====================