Patchwork [U-Boot,RFC,v2,07/12] arm: printf() is not available in some SPL configurations

login
register
mail settings
Submitter Christian Riesch
Date Nov. 21, 2011, 4:33 p.m.
Message ID <1321893227-19545-9-git-send-email-christian.riesch@omicron.at>
Download mbox | patch
Permalink /patch/126838/
State Superseded
Headers show

Comments

Christian Riesch - Nov. 21, 2011, 4:33 p.m.
This patch avoids build breakage for SPLs that do not support printf.

Signed-off-by: Christian Riesch <christian.riesch@omicron.at>
Cc: Wolfgang Denk <wd@denx.de>
Cc: Tom Rini <tom.rini@gmail.com>
---
 arch/arm/lib/eabi_compat.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)
Tom Rini - Nov. 21, 2011, 5:52 p.m.
On Mon, Nov 21, 2011 at 9:33 AM, Christian Riesch
<christian.riesch@omicron.at> wrote:
> This patch avoids build breakage for SPLs that do not support printf.
>
> Signed-off-by: Christian Riesch <christian.riesch@omicron.at>
> Cc: Wolfgang Denk <wd@denx.de>
> Cc: Tom Rini <tom.rini@gmail.com>
> ---
>  arch/arm/lib/eabi_compat.c |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/lib/eabi_compat.c b/arch/arm/lib/eabi_compat.c
> index eb3e26d..748c808 100644
> --- a/arch/arm/lib/eabi_compat.c
> +++ b/arch/arm/lib/eabi_compat.c
> @@ -13,10 +13,13 @@
>
>  int raise (int signum)
>  {
> +#if !defined(CONFIG_SPL_BUILD) || defined(CONFIG_SPL_LIBCOMMON_SUPPORT)
>        printf("raise: Signal # %d caught\n", signum);
> +#endif
>        return 0;
>  }
>
> +
>  /* Dummy function to avoid linker complaints */
>  void __aeabi_unwind_cpp_pr0(void)
>  {

No extra white space adding please :)  Otherwise
Acked-by: Tom Rini <trini@ti.com>
Christian Riesch - Nov. 22, 2011, 7:01 a.m.
Hello Tom,

On Mon, Nov 21, 2011 at 6:52 PM, Tom Rini <tom.rini@gmail.com> wrote:
> On Mon, Nov 21, 2011 at 9:33 AM, Christian Riesch
> <christian.riesch@omicron.at> wrote:
>> This patch avoids build breakage for SPLs that do not support printf.
>>
>> Signed-off-by: Christian Riesch <christian.riesch@omicron.at>
>> Cc: Wolfgang Denk <wd@denx.de>
>> Cc: Tom Rini <tom.rini@gmail.com>
>> ---
>>  arch/arm/lib/eabi_compat.c |    3 +++
>>  1 files changed, 3 insertions(+), 0 deletions(-)
>>
>> diff --git a/arch/arm/lib/eabi_compat.c b/arch/arm/lib/eabi_compat.c
>> index eb3e26d..748c808 100644
>> --- a/arch/arm/lib/eabi_compat.c
>> +++ b/arch/arm/lib/eabi_compat.c
>> @@ -13,10 +13,13 @@
>>
>>  int raise (int signum)
>>  {
>> +#if !defined(CONFIG_SPL_BUILD) || defined(CONFIG_SPL_LIBCOMMON_SUPPORT)
>>        printf("raise: Signal # %d caught\n", signum);
>> +#endif
>>        return 0;
>>  }
>>
>> +
>>  /* Dummy function to avoid linker complaints */
>>  void __aeabi_unwind_cpp_pr0(void)
>>  {
>
> No extra white space adding please :)  Otherwise

Ok, I'll remove that line and resubmit the patch.

> Acked-by: Tom Rini <trini@ti.com>

Thanks, Christian

Patch

diff --git a/arch/arm/lib/eabi_compat.c b/arch/arm/lib/eabi_compat.c
index eb3e26d..748c808 100644
--- a/arch/arm/lib/eabi_compat.c
+++ b/arch/arm/lib/eabi_compat.c
@@ -13,10 +13,13 @@ 
 
 int raise (int signum)
 {
+#if !defined(CONFIG_SPL_BUILD) || defined(CONFIG_SPL_LIBCOMMON_SUPPORT)
 	printf("raise: Signal # %d caught\n", signum);
+#endif
 	return 0;
 }
 
+
 /* Dummy function to avoid linker complaints */
 void __aeabi_unwind_cpp_pr0(void)
 {