From patchwork Mon Nov 21 10:56:18 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: zanghongyong@huawei.com X-Patchwork-Id: 126762 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [140.186.70.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 8BB57B720D for ; Mon, 21 Nov 2011 22:51:15 +1100 (EST) Received: from localhost ([::1]:47158 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RSSOt-0006jP-Dp for incoming@patchwork.ozlabs.org; Mon, 21 Nov 2011 06:51:03 -0500 Received: from eggs.gnu.org ([140.186.70.92]:42315) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RSSOk-0006hp-OD for qemu-devel@nongnu.org; Mon, 21 Nov 2011 06:50:58 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RSSOf-0006PL-CG for qemu-devel@nongnu.org; Mon, 21 Nov 2011 06:50:54 -0500 Received: from szxga01-in.huawei.com ([119.145.14.64]:54325) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RSSOf-0006OA-2Y for qemu-devel@nongnu.org; Mon, 21 Nov 2011 06:50:49 -0500 Received: from huawei.com (szxga05-in [172.24.2.49]) by szxga05-in.huawei.com (iPlanet Messaging Server 5.2 HotFix 2.14 (built Aug 8 2006)) with ESMTP id <0LV0002Q2E89QR@szxga05-in.huawei.com> for qemu-devel@nongnu.org; Mon, 21 Nov 2011 19:50:33 +0800 (CST) Received: from szxrg02-dlp.huawei.com ([172.24.2.119]) by szxga05-in.huawei.com (iPlanet Messaging Server 5.2 HotFix 2.14 (built Aug 8 2006)) with ESMTP id <0LV000CJLE7EC9@szxga05-in.huawei.com> for qemu-devel@nongnu.org; Mon, 21 Nov 2011 19:50:33 +0800 (CST) Received: from szxeml207-edg.china.huawei.com ([172.24.2.119]) by szxrg02-dlp.huawei.com (MOS 4.1.9-GA) with ESMTP id AFD16487; Mon, 21 Nov 2011 19:50:29 +0800 Received: from SZXEML412-HUB.china.huawei.com (10.82.67.91) by szxeml207-edg.china.huawei.com (172.24.2.59) with Microsoft SMTP Server (TLS) id 14.1.323.3; Mon, 21 Nov 2011 19:50:28 +0800 Received: from localhost.localdomain (10.166.29.43) by szxeml412-hub.china.huawei.com (10.82.67.91) with Microsoft SMTP Server id 14.1.323.3; Mon, 21 Nov 2011 19:50:19 +0800 Date: Mon, 21 Nov 2011 18:56:18 +0800 From: zanghongyong@huawei.com X-Originating-IP: [10.166.29.43] To: avi@redhat.com, qemu-devel@nongnu.org, kvm@vger.kernel.org Message-id: <1321872978-3298-1-git-send-email-zanghongyong@huawei.com> MIME-version: 1.0 X-Mailer: git-send-email 1.7.0.4 Content-type: text/plain Content-transfer-encoding: 7BIT X-CFilter-Loop: Reflected X-detected-operating-system: by eggs.gnu.org: Solaris 9 X-Received-From: 119.145.14.64 Cc: wusongwei@huawei.com, hanweidong@huawei.com, wuchangyi@huawei.com, louzhengwei@huawei.com, xiaowei.yang@huawei.com, james.chenjiabo@huawei.com, zanghongyong@huawei.com, cam@cs.ualberta.ca Subject: [Qemu-devel] [PATCH] ivshmem: fix PCI BAR2 registration during initialization X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org From: Hongyong Zang Ivshmem cannot work, and the command lspci cannot show ivshmem BAR2 in the guest. As for pci_register_bar(), parameter MemoryRegion should be s->bar instead of s->ivshmem. Signed-off-by: Hongyong Zang Reviewed-by: Avi Kivity --- hw/ivshmem.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/ivshmem.c b/hw/ivshmem.c index 242fbea..2ecf658 100644 --- a/hw/ivshmem.c +++ b/hw/ivshmem.c @@ -694,7 +694,7 @@ static int pci_ivshmem_init(PCIDevice *dev) s->peers = g_malloc0(s->nb_peers * sizeof(Peer)); pci_register_bar(&s->dev, 2, - PCI_BASE_ADDRESS_SPACE_MEMORY, &s->ivshmem); + PCI_BASE_ADDRESS_SPACE_MEMORY, &s->bar); s->eventfd_chr = g_malloc0(s->vectors * sizeof(CharDriverState *));