| Message ID | 20200407081344.3519094-2-t.lamprecht@proxmox.com |
|---|---|
| State | New |
| Headers | show |
| Series | Drop testing message introduced by "net/bpfilter: fix dprintf usage for /dev/kmsg" | expand |
On 07/04/2020 09:13, Thomas Lamprecht wrote: > From: Bruno Meneguele <bmeneg@redhat.com> > > A testing message was brought by 13d0f7b814d9 ("net/bpfilter: fix dprintf > usage for /dev/kmsg") but should've been deleted before patch submission. > Although it doesn't cause any harm to the code or functionality itself, it's > totally unpleasant to have it displayed on every loop iteration with no real > use case. Thus remove it unconditionally. > > Fixes: 13d0f7b814d9 ("net/bpfilter: fix dprintf usage for /dev/kmsg") > Signed-off-by: Bruno Meneguele <bmeneg@redhat.com> > Signed-off-by: David S. Miller <davem@davemloft.net> > Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com> > --- > net/bpfilter/main.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/net/bpfilter/main.c b/net/bpfilter/main.c > index efea4874743e..05e1cfc1e5cd 100644 > --- a/net/bpfilter/main.c > +++ b/net/bpfilter/main.c > @@ -35,7 +35,6 @@ static void loop(void) > struct mbox_reply reply; > int n; > > - fprintf(debug_f, "testing the buffer\n"); > n = read(0, &req, sizeof(req)); > if (n != sizeof(req)) { > fprintf(debug_f, "invalid request %d\n", n); > Yep, reducing spamming the log is always good. Thanks! Acked-by: Colin Ian King <colin.king@canonical.com>
On Tue, Apr 07, 2020 at 10:13:47AM +0200, Thomas Lamprecht wrote: > From: Bruno Meneguele <bmeneg@redhat.com> > > A testing message was brought by 13d0f7b814d9 ("net/bpfilter: fix dprintf > usage for /dev/kmsg") but should've been deleted before patch submission. > Although it doesn't cause any harm to the code or functionality itself, it's > totally unpleasant to have it displayed on every loop iteration with no real > use case. Thus remove it unconditionally. > > Fixes: 13d0f7b814d9 ("net/bpfilter: fix dprintf usage for /dev/kmsg") > Signed-off-by: Bruno Meneguele <bmeneg@redhat.com> > Signed-off-by: David S. Miller <davem@davemloft.net> It's missing the cherry picked line: (cherry picked from commit 41c55ea6c2a7ca4c663eeec05bdf54f4e2419699) But it can be easily adjusted when applying the patch. Apart than that it looks good to me, therefore: Acked-by: Andrea Righi <andrea.righi@canonical.com> > Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com> > --- > net/bpfilter/main.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/net/bpfilter/main.c b/net/bpfilter/main.c > index efea4874743e..05e1cfc1e5cd 100644 > --- a/net/bpfilter/main.c > +++ b/net/bpfilter/main.c > @@ -35,7 +35,6 @@ static void loop(void) > struct mbox_reply reply; > int n; > > - fprintf(debug_f, "testing the buffer\n"); > n = read(0, &req, sizeof(req)); > if (n != sizeof(req)) { > fprintf(debug_f, "invalid request %d\n", n); > -- > 2.20.1 > > > > -- > kernel-team mailing list > kernel-team@lists.ubuntu.com > https://lists.ubuntu.com/mailman/listinfo/kernel-team
On 4/7/20 11:27 AM, Andrea Righi wrote: > On Tue, Apr 07, 2020 at 10:13:47AM +0200, Thomas Lamprecht wrote: >> From: Bruno Meneguele <bmeneg@redhat.com> >> >> A testing message was brought by 13d0f7b814d9 ("net/bpfilter: fix dprintf >> usage for /dev/kmsg") but should've been deleted before patch submission. >> Although it doesn't cause any harm to the code or functionality itself, it's >> totally unpleasant to have it displayed on every loop iteration with no real >> use case. Thus remove it unconditionally. >> >> Fixes: 13d0f7b814d9 ("net/bpfilter: fix dprintf usage for /dev/kmsg") >> Signed-off-by: Bruno Meneguele <bmeneg@redhat.com> >> Signed-off-by: David S. Miller <davem@davemloft.net> > It's missing the cherry picked line: > > (cherry picked from commit 41c55ea6c2a7ca4c663eeec05bdf54f4e2419699) > > But it can be easily adjusted when applying the patch. Apart than that > it looks good to me, therefore: > > Acked-by: Andrea Righi <andrea.righi@canonical.com> > Ah yeah, sure! Sorry about that, it's because I applied with `git am` not with `git cherry-pick -xs` like normally, as I did not had Dave's net tree directly available and was to lazy to add and fetch it as I had the patch already from https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git/patch/?id=41c55ea6c2a7ca4c663eeec05bdf54f4e2419699 oops, adjusted when applying the patch or works both for me :)
diff --git a/net/bpfilter/main.c b/net/bpfilter/main.c index efea4874743e..05e1cfc1e5cd 100644 --- a/net/bpfilter/main.c +++ b/net/bpfilter/main.c @@ -35,7 +35,6 @@ static void loop(void) struct mbox_reply reply; int n; - fprintf(debug_f, "testing the buffer\n"); n = read(0, &req, sizeof(req)); if (n != sizeof(req)) { fprintf(debug_f, "invalid request %d\n", n);