Message ID | 20200406174743.16956-35-f4bug@amsat.org |
---|---|
State | New |
Headers | show
Return-Path: <qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org> X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=<UNKNOWN>) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=amsat.org Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=d6VmOd2k; dkim-atps=neutral Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 48wzJr4k5Mz9sSw for <incoming@patchwork.ozlabs.org>; Tue, 7 Apr 2020 04:17:00 +1000 (AEST) Received: from localhost ([::1]:36468 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from <qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>) id 1jLWIs-0003H4-FL for incoming@patchwork.ozlabs.org; Mon, 06 Apr 2020 14:16:58 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36574) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from <philippe.mathieu.daude@gmail.com>) id 1jLVrR-0002Vr-Ph for qemu-devel@nongnu.org; Mon, 06 Apr 2020 13:48:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from <philippe.mathieu.daude@gmail.com>) id 1jLVrQ-0003Nr-S1 for qemu-devel@nongnu.org; Mon, 06 Apr 2020 13:48:37 -0400 Received: from mail-wm1-x344.google.com ([2a00:1450:4864:20::344]:35068) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from <philippe.mathieu.daude@gmail.com>) id 1jLVrQ-0003ND-MG; Mon, 06 Apr 2020 13:48:36 -0400 Received: by mail-wm1-x344.google.com with SMTP id i19so336279wmb.0; Mon, 06 Apr 2020 10:48:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=z9KZ6eY6DRrXTHj5N0HrtI0MTUlERzvy0/HLB/IrQH4=; b=d6VmOd2kcrdWpMxDbDzEZcYd4jt/mmb6a2Y+psUh0gsZXzUwMEItJsZxVUvE/jfI5Q fjOSiZbkMjbmMC6nvigqiC7njn0iDcTP70+DWJTspTa3NcUewCP/wonU7MdYmYtOagsf vBfdvyG/meTrD72vWkpnS1sAPAF3mPeshUL1wm/DKJNixBPPuTCxxW2Ks38OA5J44wWA Ia1ols52s7j+qqBQ+wO6ovbr3XQ5zLY6syJxUx2hwo0xrVIuA3QqoqO1mITz0hZtT+Pl 8SEtlOHw740BLWXLBWxdCdJjgoPaxYEK3vgMNGsJjqDqCoLhycHKFh90PxUssnSPyFw8 s2AA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=z9KZ6eY6DRrXTHj5N0HrtI0MTUlERzvy0/HLB/IrQH4=; b=Jt6YO76WXJEbuDWthi4Cqritljx5ve6pwWOaZo768sfTYN5xNSpa/zo0+3K37g0KWX iuG8zSYG7AArgKaf41KcSO1OASeVjPj044Avvbyu7nMCdNqbkAA7Iii/dESTH9/KtBW6 GROLlEmpKJT7UMnH+IV7YK4TXWx4xjGYb5rtZZ/N+aDfyfwvDN1EwT2jHkK5osUHn2th uAsXG8ysJb1QWq/SoZn3foIyv+dgCP0ekf61ue9Xp6/nflqCZCs3WDy+xpsY+yc00ijd xA77bS666DszuEkuTOLbJxPezafcoA7VJN1MvSAtSORz1dW64+uRGw6SfG097rXPce6Z w/qA== X-Gm-Message-State: AGi0PuaiIT+f7ZegqgRsGD2YQtPzW48Ekl5cOuX4UyfbJ10ne8eD/7wf TAWVQNPzQIQYcc1hzhPgTa4K35h6J0A= X-Google-Smtp-Source: APiQypIVGs240S+n4X7PMacb1T7hWqNWi4pZJ3uAGnUpEqj3icVbe+NtBeRCrMwjN3HcpwaWaR2L9A== X-Received: by 2002:a1c:8049:: with SMTP id b70mr57991wmd.162.1586195312599; Mon, 06 Apr 2020 10:48:32 -0700 (PDT) Received: from x1w.redhat.com (116.red-83-42-57.dynamicip.rima-tde.net. [83.42.57.116]) by smtp.gmail.com with ESMTPSA id a67sm364880wmc.30.2020.04.06.10.48.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Apr 2020 10:48:32 -0700 (PDT) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= <f4bug@amsat.org> To: qemu-devel@nongnu.org, Markus Armbruster <armbru@redhat.com> Subject: [PATCH-for-5.1 v2 34/54] hw/microblaze/xlnx-zynqmp-pmu: Add missing error-propagation code Date: Mon, 6 Apr 2020 19:47:23 +0200 Message-Id: <20200406174743.16956-35-f4bug@amsat.org> X-Mailer: git-send-email 2.21.1 In-Reply-To: <20200406174743.16956-1-f4bug@amsat.org> References: <20200406174743.16956-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::344 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: <qemu-devel.nongnu.org> List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>, <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe> List-Archive: <https://lists.nongnu.org/archive/html/qemu-devel> List-Post: <mailto:qemu-devel@nongnu.org> List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help> List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>, <mailto:qemu-devel-request@nongnu.org?subject=subscribe> Cc: Peter Maydell <peter.maydell@linaro.org>, Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>, Alistair Francis <alistair@alistair23.me>, =?utf-8?q?Philippe_Mathieu?= =?utf-8?q?-Daud=C3=A9?= <f4bug@amsat.org>, "open list:Xilinx ZynqMP" <qemu-arm@nongnu.org>, "Edgar E. Iglesias" <edgar.iglesias@gmail.com> Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" <qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org> |
Series |
various: Fix error-propagation with Coccinelle scripts
|
expand
|
diff --git a/hw/microblaze/xlnx-zynqmp-pmu.c b/hw/microblaze/xlnx-zynqmp-pmu.c index 2aa602cf85..4ecbea7fdc 100644 --- a/hw/microblaze/xlnx-zynqmp-pmu.c +++ b/hw/microblaze/xlnx-zynqmp-pmu.c @@ -123,7 +123,11 @@ static void xlnx_zynqmp_pmu_soc_realize(DeviceState *dev, Error **errp) /* Connect the IPI device */ for (int i = 0; i < XLNX_ZYNQMP_PMU_NUM_IPIS; i++) { object_property_set_bool(OBJECT(&s->ipi[i]), true, "realized", - &error_abort); + &err); + if (err) { + error_propagate(errp, err); + return; + } sysbus_mmio_map(SYS_BUS_DEVICE(&s->ipi[i]), 0, ipi_addr[i]); sysbus_connect_irq(SYS_BUS_DEVICE(&s->ipi[i]), 0, qdev_get_gpio_in(DEVICE(&s->intc), ipi_irq[i]));
Patch created mechanically by running: $ spatch \ --macro-file scripts/cocci-macro-file.h --include-headers \ --sp-file scripts/coccinelle/use-error_propagate-in-realize.cocci \ --keep-comments --smpl-spacing --in-place --dir hw Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> --- hw/microblaze/xlnx-zynqmp-pmu.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)