From patchwork Mon Nov 21 05:18:20 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Li RongQing X-Patchwork-Id: 126687 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id C458FB7201 for ; Mon, 21 Nov 2011 16:18:30 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750935Ab1KUFS0 (ORCPT ); Mon, 21 Nov 2011 00:18:26 -0500 Received: from mail-iy0-f174.google.com ([209.85.210.174]:37774 "EHLO mail-iy0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750850Ab1KUFSZ (ORCPT ); Mon, 21 Nov 2011 00:18:25 -0500 Received: by iage36 with SMTP id e36so6810161iag.19 for ; Sun, 20 Nov 2011 21:18:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=from:to:subject:date:message-id:x-mailer; bh=ibWIaghrFoh34mC7KgSfnyY2UV+sAcGOiOEclfikPqg=; b=DJCGZl9tiZ4Hkw6DoMQdL3CSSP22zb0AAQmv9sbL6VnCSfXMLbTgE4QAkrjAABcs2F nrFZ6yqD5PB73BraRmL000kl8y0eHScldk9aFfJ2JK9zrJPJh6gER7X+fJ3w9M6N7CkM 8usOIF1Ap0Ml5IAl54Z9oDPgzUybRiOjW0s28= Received: by 10.42.159.72 with SMTP id k8mr10559048icx.14.1321852704928; Sun, 20 Nov 2011 21:18:24 -0800 (PST) Received: from localhost ([61.148.56.138]) by mx.google.com with ESMTPS id jm11sm41681061ibb.1.2011.11.20.21.18.23 (version=TLSv1/SSLv3 cipher=OTHER); Sun, 20 Nov 2011 21:18:24 -0800 (PST) From: roy.qing.li@gmail.com To: netdev@vger.kernel.org Subject: [PATCH] dccp: fix error propagation in dccp_v4_connect Date: Mon, 21 Nov 2011 13:18:20 +0800 Message-Id: <1321852700-2966-1-git-send-email-roy.qing.li@gmail.com> X-Mailer: git-send-email 1.7.1 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: RongQing.Li The errcode is not updated when ip_route_newports() fails. Signed-off-by: RongQing.Li --- net/dccp/ipv4.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/net/dccp/ipv4.c b/net/dccp/ipv4.c index 90a919a..3f4e541 100644 --- a/net/dccp/ipv4.c +++ b/net/dccp/ipv4.c @@ -111,6 +111,7 @@ int dccp_v4_connect(struct sock *sk, struct sockaddr *uaddr, int addr_len) rt = ip_route_newports(fl4, rt, orig_sport, orig_dport, inet->inet_sport, inet->inet_dport, sk); if (IS_ERR(rt)) { + err = PTR_ERR(rt); rt = NULL; goto failure; }