Patchwork [net-next,1/3] be2net: fix to display Pause autonegotiation setting

login
register
mail settings
Submitter Ajit Khaparde
Date Nov. 21, 2011, 5:12 a.m.
Message ID <20111121051240.GA17132@akhaparde-VBox>
Download mbox | patch
Permalink /patch/126685/
State Changes Requested
Delegated to: David Miller
Headers show

Comments

Ajit Khaparde - Nov. 21, 2011, 5:12 a.m.
Pause autonegotiation is supported by default.

Signed-off-by: Ajit Khaparde <ajit.khaparde@emulex.com>
---
 drivers/net/ethernet/emulex/benet/be_ethtool.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Ben Hutchings - Nov. 21, 2011, 5:10 p.m.
On Sun, 2011-11-20 at 23:12 -0600, Ajit Khaparde wrote:
> Pause autonegotiation is supported by default.
> 
> Signed-off-by: Ajit Khaparde <ajit.khaparde@emulex.com>
> ---
>  drivers/net/ethernet/emulex/benet/be_ethtool.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/net/ethernet/emulex/benet/be_ethtool.c b/drivers/net/ethernet/emulex/benet/be_ethtool.c
> index 575c783..ff53489 100644
> --- a/drivers/net/ethernet/emulex/benet/be_ethtool.c
> +++ b/drivers/net/ethernet/emulex/benet/be_ethtool.c
> @@ -538,7 +538,7 @@ be_get_pauseparam(struct net_device *netdev, struct ethtool_pauseparam *ecmd)
>  	struct be_adapter *adapter = netdev_priv(netdev);
>  
>  	be_cmd_get_flow_control(adapter, &ecmd->tx_pause, &ecmd->rx_pause);
> -	ecmd->autoneg = 0;
> +	ecmd->autoneg = 1;
>  }
>  
>  static int

This is surely not true for XFP and SFP+ interfaces.

Ben.

Patch

diff --git a/drivers/net/ethernet/emulex/benet/be_ethtool.c b/drivers/net/ethernet/emulex/benet/be_ethtool.c
index 575c783..ff53489 100644
--- a/drivers/net/ethernet/emulex/benet/be_ethtool.c
+++ b/drivers/net/ethernet/emulex/benet/be_ethtool.c
@@ -538,7 +538,7 @@  be_get_pauseparam(struct net_device *netdev, struct ethtool_pauseparam *ecmd)
 	struct be_adapter *adapter = netdev_priv(netdev);
 
 	be_cmd_get_flow_control(adapter, &ecmd->tx_pause, &ecmd->rx_pause);
-	ecmd->autoneg = 0;
+	ecmd->autoneg = 1;
 }
 
 static int