Patchwork Include zlib.h using #include <>

login
register
mail settings
Submitter Stefan Weil
Date Nov. 20, 2011, 11:34 a.m.
Message ID <1321788870-27848-1-git-send-email-sw@weilnetz.de>
Download mbox | patch
Permalink /patch/126647/
State Accepted
Headers show

Comments

Stefan Weil - Nov. 20, 2011, 11:34 a.m.
zlib.h is not a local include file, therefore it should be included
using <> instead of "".

Signed-off-by: Stefan Weil <sw@weilnetz.de>
---
 block/vmdk.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Anthony Liguori - Nov. 22, 2011, 12:22 a.m.
On 11/20/2011 05:34 AM, Stefan Weil wrote:
> zlib.h is not a local include file, therefore it should be included
> using<>  instead of "".
>
> Signed-off-by: Stefan Weil<sw@weilnetz.de>

Applied.  Thanks.

Regards,

Anthony Liguori

> ---
>   block/vmdk.c |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/block/vmdk.c b/block/vmdk.c
> index e53a2f0..96f7d5d 100644
> --- a/block/vmdk.c
> +++ b/block/vmdk.c
> @@ -26,7 +26,7 @@
>   #include "qemu-common.h"
>   #include "block_int.h"
>   #include "module.h"
> -#include "zlib.h"
> +#include<zlib.h>
>
>   #define VMDK3_MAGIC (('C'<<  24) | ('O'<<  16) | ('W'<<  8) | 'D')
>   #define VMDK4_MAGIC (('K'<<  24) | ('D'<<  16) | ('M'<<  8) | 'V')

Patch

diff --git a/block/vmdk.c b/block/vmdk.c
index e53a2f0..96f7d5d 100644
--- a/block/vmdk.c
+++ b/block/vmdk.c
@@ -26,7 +26,7 @@ 
 #include "qemu-common.h"
 #include "block_int.h"
 #include "module.h"
-#include "zlib.h"
+#include <zlib.h>
 
 #define VMDK3_MAGIC (('C' << 24) | ('O' << 16) | ('W' << 8) | 'D')
 #define VMDK4_MAGIC (('K' << 24) | ('D' << 16) | ('M' << 8) | 'V')