Patchwork [U-Boot,RFC,1/3] MAINTAINERS: Fix my email address

login
register
mail settings
Submitter Stephen Warren
Date Nov. 19, 2011, 8:47 p.m.
Message ID <1321735649-27138-2-git-send-email-swarren@nvidia.com>
Download mbox | patch
Permalink /patch/126618/
State Changes Requested
Headers show

Comments

Stephen Warren - Nov. 19, 2011, 8:47 p.m.
I forgot to edit it when I cut/paste Tom Warren's MAINTAINERS entry.

Signed-off-by: Stephen Warren <swarren@nvidia.com>
---
 MAINTAINERS |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Wolfgang Denk - Nov. 28, 2011, 6:58 p.m.
Dear Stephen Warren,

In message <1321735649-27138-2-git-send-email-swarren@nvidia.com> you wrote:
> I forgot to edit it when I cut/paste Tom Warren's MAINTAINERS entry.
> 
> Signed-off-by: Stephen Warren <swarren@nvidia.com>
> ---
>  MAINTAINERS |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)

Applied, thanks.

Best regards,

Wolfgang Denk
Wolfgang Denk - Nov. 28, 2011, 7:01 p.m.
Dear Stephen Warren,

In message <1321735649-27138-2-git-send-email-swarren@nvidia.com> you wrote:
> I forgot to edit it when I cut/paste Tom Warren's MAINTAINERS entry.
> 
> Signed-off-by: Stephen Warren <swarren@nvidia.com>
> ---
>  MAINTAINERS |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)

Wrong.  Not applied, as this doesn't apply to mainline.

Please fix.

Best regards,

Wolfgang Denk
Stephen Warren - Nov. 28, 2011, 7:34 p.m.
On 11/28/2011 12:01 PM, Wolfgang Denk wrote:
> Dear Stephen Warren,
> 
> In message <1321735649-27138-2-git-send-email-swarren@nvidia.com> you wrote:
>> I forgot to edit it when I cut/paste Tom Warren's MAINTAINERS entry.
>>
>> Signed-off-by: Stephen Warren <swarren@nvidia.com>
>> ---
>>  MAINTAINERS |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> Wrong.  Not applied, as this doesn't apply to mainline.

This series relies on other Tegra patches, both from myself and from
others (Simon Glass in particular). Those other patches were posted a
long time ago, so I assumed they'd be merged first, and didn't
explicitly mention the dependency.

I imagine this patch series will go in via the new Tegra tree, so Tom
Warren will sort out all the dependencies, based on the list of
outstanding patches that Simon posted recently.
Wolfgang Denk - Nov. 28, 2011, 7:41 p.m.
Dear Stephen Warren,

In message <4ED3E260.7020800@nvidia.com> you wrote:
>
> >>  MAINTAINERS |    2 +-
> >>  1 files changed, 1 insertions(+), 1 deletions(-)
...
> This series relies on other Tegra patches, both from myself and from
> others (Simon Glass in particular). Those other patches were posted a
> long time ago, so I assumed they'd be merged first, and didn't
> explicitly mention the dependency.

But this is global code, that should not go through another repo.

Also, this is a completely independent change, that should be
applicable directly.

Best regards,

Wolfgang Denk
Stephen Warren - Nov. 28, 2011, 7:45 p.m.
On 11/28/2011 12:41 PM, Wolfgang Denk wrote:
> Dear Stephen Warren,
> 
> In message <4ED3E260.7020800@nvidia.com> you wrote:
>>
>>>>  MAINTAINERS |    2 +-
>>>>  1 files changed, 1 insertions(+), 1 deletions(-)
> ...
>> This series relies on other Tegra patches, both from myself and from
>> others (Simon Glass in particular). Those other patches were posted a
>> long time ago, so I assumed they'd be merged first, and didn't
>> explicitly mention the dependency.
> 
> But this is global code, that should not go through another repo.
> 
> Also, this is a completely independent change, that should be
> applicable directly.

The reason it doesn't apply is because the line being edited isn't in
the code yet. It was only added to the file when I added support for the
first board where I was listed as maintainer. I assume you agree that
the original addition to MAINTAINERS should be part of the change that
added support for that board, and since it's an ARM/Tegra board, that
original change should go through the Tegra and ARM custodian trees? I
suppose once that's done, this patch can indeed go directly into the
main tree. If that flow is fine, I'll simply repost the patch once the
appropriate context is in the main repository.
Wolfgang Denk - Nov. 28, 2011, 8:39 p.m.
Dear Stephen Warren,

In message <4ED3E4D9.6090709@nvidia.com> you wrote:
>
> The reason it doesn't apply is because the line being edited isn't in
> the code yet. It was only added to the file when I added support for the
> first board where I was listed as maintainer. I assume you agree that
> the original addition to MAINTAINERS should be part of the change that
> added support for that board, and since it's an ARM/Tegra board, that
> original change should go through the Tegra and ARM custodian trees? I
> suppose once that's done, this patch can indeed go directly into the
> main tree. If that flow is fine, I'll simply repost the patch once the
> appropriate context is in the main repository.

If that other patch has not been commited yet, youshould rather send
an update for that broken patch, instead of fixing it later.

Best regards,

Wolfgang Denk

Patch

diff --git a/MAINTAINERS b/MAINTAINERS
index 567dc61..c532c29 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -877,7 +877,7 @@  Tom Warren <twarren@nvidia.com>
 	seaboard	Tegra2 (ARM7 & A9 Dual Core)
 
 Tom Warren <twarren@nvidia.com>
-Stephen Warren <twarren@nvidia.com>
+Stephen Warren <swarren@nvidia.com>
 
 	ventana		Tegra2 (ARM7 & A9 Dual Core)