| Message ID | 20200403161538.1375908-7-helen.koike@collabora.com |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | move Rockchip ISP bindings out of staging / add ISP DT nodes for RK3399 | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | warning | "total: 0 errors, 1 warnings, 0 lines checked" |
On Fri, 3 Apr 2020 13:15:35 -0300, Helen Koike wrote: > Move rkisp1 bindings to Documentation/devicetree/bindings/media > > Verified with: > make ARCH=arm64 dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/media/rockchip-isp1.yaml > > Signed-off-by: Helen Koike <helen.koike@collabora.com> > --- > > V2: > - no changes > > .../devicetree/bindings/media/rockchip-isp1.yaml | 0 > 1 file changed, 0 insertions(+), 0 deletions(-) > rename {drivers/staging/media/rkisp1/Documentation => Documentation}/devicetree/bindings/media/rockchip-isp1.yaml (100%) > Acked-by: Rob Herring <robh@kernel.org>
Hi Helen, make ARCH=arm dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/media/rockchip-isp1.yaml SCHEMA Documentation/devicetree/bindings/processed-schema-examples.yaml SCHEMA Documentation/devicetree/bindings/processed-schema.yaml CHKDT Documentation/devicetree/bindings/media/rockchip-isp1.yaml DTC Documentation/devicetree/bindings/media/rockchip-isp1.example.dt.yaml Documentation/devicetree/bindings/media/rockchip-isp1.example.dts:22.27-99.11: Warning (unit_address_vs_reg): /example-0/parent@0: node has a unit name, but no reg or ranges property CHECK Documentation/devicetree/bindings/media/rockchip-isp1.example.dt.yaml On 4/3/20 6:15 PM, Helen Koike wrote: > Move rkisp1 bindings to Documentation/devicetree/bindings/media > > Verified with: > make ARCH=arm64 dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/media/rockchip-isp1.yaml > > Signed-off-by: Helen Koike <helen.koike@collabora.com> > --- > > V2: > - no changes > > .../devicetree/bindings/media/rockchip-isp1.yaml | 0 > 1 file changed, 0 insertions(+), 0 deletions(-) > rename {drivers/staging/media/rkisp1/Documentation => Documentation}/devicetree/bindings/media/rockchip-isp1.yaml (100%) > > diff --git a/drivers/staging/media/rkisp1/Documentation/devicetree/bindings/media/rockchip-isp1.yaml b/Documentation/devicetree/bindings/media/rockchip-isp1.yaml > similarity index 100% > rename from drivers/staging/media/rkisp1/Documentation/devicetree/bindings/media/rockchip-isp1.yaml > rename to Documentation/devicetree/bindings/media/rockchip-isp1.yaml >
Hi Helen, > clocks: > items: > - description: ISP clock > - description: ISP AXI clock clock > - description: ISP AXI clock wrapper clock > - description: ISP AHB clock clock Too many clocks here ^ Too many spaces here ^ > - description: ISP AHB wrapper clock We can expect 4 to 5 clocks. With 5 clocks and a different description this layout is maybe not so handy. As first change: clocks: maxItems: 5 description: rk3399 clocks ISP clock ISP AXI clock ISP AXI wrapper clock ISP AHB clock ISP AHB wrapper clock And then later: clocks: maxItems: 5 description: rk3288 clocks ISP clock ISP AXI clock ISP AHB clock ISP Pixel clock ISP JPEG source clock rk3399 clocks ISP clock ISP AXI clock ISP AXI wrapper clock ISP AHB clock ISP AHB wrapper clock With 4 clocks: clocks: minItems: 4 maxItems: 5 description: rk1808 clocks rk3288 clocks rk3326 clocks rk3368 clocks rk3399 clocks [..] > > clock-names: > items: > - const: clk_isp > - const: aclk_isp > - const: aclk_isp_wrap > - const: hclk_isp > - const: hclk_isp_wrap On 4/3/20 6:15 PM, Helen Koike wrote: > Move rkisp1 bindings to Documentation/devicetree/bindings/media > > Verified with: > make ARCH=arm64 dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/media/rockchip-isp1.yaml > > Signed-off-by: Helen Koike <helen.koike@collabora.com> > --- > > V2: > - no changes > > .../devicetree/bindings/media/rockchip-isp1.yaml | 0 > 1 file changed, 0 insertions(+), 0 deletions(-) > rename {drivers/staging/media/rkisp1/Documentation => Documentation}/devicetree/bindings/media/rockchip-isp1.yaml (100%) > > diff --git a/drivers/staging/media/rkisp1/Documentation/devicetree/bindings/media/rockchip-isp1.yaml b/Documentation/devicetree/bindings/media/rockchip-isp1.yaml > similarity index 100% > rename from drivers/staging/media/rkisp1/Documentation/devicetree/bindings/media/rockchip-isp1.yaml > rename to Documentation/devicetree/bindings/media/rockchip-isp1.yaml >
diff --git a/drivers/staging/media/rkisp1/Documentation/devicetree/bindings/media/rockchip-isp1.yaml b/Documentation/devicetree/bindings/media/rockchip-isp1.yaml
similarity index 100%
rename from drivers/staging/media/rkisp1/Documentation/devicetree/bindings/media/rockchip-isp1.yaml
rename to Documentation/devicetree/bindings/media/rockchip-isp1.yaml
Move rkisp1 bindings to Documentation/devicetree/bindings/media Verified with: make ARCH=arm64 dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/media/rockchip-isp1.yaml Signed-off-by: Helen Koike <helen.koike@collabora.com> --- V2: - no changes .../devicetree/bindings/media/rockchip-isp1.yaml | 0 1 file changed, 0 insertions(+), 0 deletions(-) rename {drivers/staging/media/rkisp1/Documentation => Documentation}/devicetree/bindings/media/rockchip-isp1.yaml (100%)