Patchwork [U-Boot] drivers/usb/host/ehci-mxc.c: Fix GCC 4.6 warning

login
register
mail settings
Submitter Anatolij Gustschin
Date Nov. 19, 2011, 8:10 p.m.
Message ID <1321733433-6050-1-git-send-email-agust@denx.de>
Download mbox | patch
Permalink /patch/126608/
State Accepted
Delegated to: Remy Bohmer
Headers show

Comments

Anatolij Gustschin - Nov. 19, 2011, 8:10 p.m.
Fix:
ehci-mxc.c: In function 'ehci_hcd_init':
ehci-mxc.c:113:6: warning: variable 'tmp' set but not used
[-Wunused-but-set-variable]

Signed-off-by: Anatolij Gustschin <agust@denx.de>
---
 drivers/usb/host/ehci-mxc.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)
Remy Bohmer - Nov. 26, 2011, 11:58 p.m.
Hi,

2011/11/19 Anatolij Gustschin <agust@denx.de>:
> Fix:
> ehci-mxc.c: In function 'ehci_hcd_init':
> ehci-mxc.c:113:6: warning: variable 'tmp' set but not used
> [-Wunused-but-set-variable]
>
> Signed-off-by: Anatolij Gustschin <agust@denx.de>
> ---
>  drivers/usb/host/ehci-mxc.c |    3 +--
>  1 files changed, 1 insertions(+), 2 deletions(-)

Applied to u-boot-usb. Thanks.

Remy
Wolfgang Denk - Dec. 9, 2011, 9:35 a.m.
Dear Anatolij Gustschin,

In message <1321733433-6050-1-git-send-email-agust@denx.de> you wrote:
> Fix:
> ehci-mxc.c: In function 'ehci_hcd_init':
> ehci-mxc.c:113:6: warning: variable 'tmp' set but not used
> [-Wunused-but-set-variable]
> 
> Signed-off-by: Anatolij Gustschin <agust@denx.de>
> ---
>  drivers/usb/host/ehci-mxc.c |    3 +--
>  1 files changed, 1 insertions(+), 2 deletions(-)

Applied, thanks.

Remy, you wrote you had applied this to u-boot-usb, so this is
probably OK with you.  Sorry that I did not want to wait any longer
for your pull request, at least not for these simple fixes.

Best regards,

Wolfgang Denk

Patch

diff --git a/drivers/usb/host/ehci-mxc.c b/drivers/usb/host/ehci-mxc.c
index f403d49..61dbccd 100644
--- a/drivers/usb/host/ehci-mxc.c
+++ b/drivers/usb/host/ehci-mxc.c
@@ -110,11 +110,10 @@  int ehci_hcd_init(void)
 {
 	struct usb_ehci *ehci;
 #ifdef CONFIG_MX31
-	u32 tmp;
 	struct clock_control_regs *sc_regs =
 		(struct clock_control_regs *)CCM_BASE;
 
-	tmp = __raw_readl(&sc_regs->ccmr);
+	__raw_readl(&sc_regs->ccmr);
 	__raw_writel(__raw_readl(&sc_regs->ccmr) | (1 << 9), &sc_regs->ccmr) ;
 #endif