| Message ID | 20200403120957.2431-8-skashyap@marvell.com |
|---|---|
| State | Changes Requested |
| Delegated to: | David Miller |
| Headers | show |
| Series | qed/qedf: Firmware recovery, bw update and misc fixes. | expand |
Saurav,
> - Get the dev info after updating the params.
This could also benefit from being elaborated a bit.
Hi Martin, > -----Original Message----- > From: Martin K. Petersen <martin.petersen@oracle.com> > Sent: Tuesday, April 14, 2020 6:57 AM > To: Saurav Kashyap <skashyap@marvell.com> > Cc: martin.petersen@oracle.com; GR-QLogic-Storage-Upstream <GR-QLogic- > Storage-Upstream@marvell.com>; linux-scsi@vger.kernel.org; Javed Hasan > <jhasan@marvell.com>; netdev@vger.kernel.org > Subject: [EXT] Re: [PATCH v3 7/7] qedf: Get dev info after updating the > params. > > External Email > > ---------------------------------------------------------------------- > > Saurav, > > > - Get the dev info after updating the params. > > This could also benefit from being elaborated a bit. <SK> Thanks for the feedback. I will submit the updated patch set. Thanks, ~Saurav > > -- > Martin K. Petersen Oracle Linux Engineering
diff --git a/drivers/scsi/qedf/qedf_main.c b/drivers/scsi/qedf/qedf_main.c index 52673b4..dc5ac55 100644 --- a/drivers/scsi/qedf/qedf_main.c +++ b/drivers/scsi/qedf/qedf_main.c @@ -3332,6 +3332,13 @@ static int __qedf_probe(struct pci_dev *pdev, int mode) } qed_ops->common->update_pf_params(qedf->cdev, &qedf->pf_params); + /* Learn information crucial for qedf to progress */ + rc = qed_ops->fill_dev_info(qedf->cdev, &qedf->dev_info); + if (rc) { + QEDF_ERR(&qedf->dbg_ctx, "Failed to dev info.\n"); + goto err2; + } + /* Record BDQ producer doorbell addresses */ qedf->bdq_primary_prod = qedf->dev_info.primary_dbq_rq_addr; qedf->bdq_secondary_prod = qedf->dev_info.secondary_bdq_rq_addr;
- Get the dev info after updating the params. Signed-off-by: Saurav Kashyap <skashyap@marvell.com> --- drivers/scsi/qedf/qedf_main.c | 7 +++++++ 1 file changed, 7 insertions(+)