From patchwork Sat Nov 19 09:57:20 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yongqiang Yang X-Patchwork-Id: 126566 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 61C6BB722D for ; Sat, 19 Nov 2011 23:31:37 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752453Ab1KSMbg (ORCPT ); Sat, 19 Nov 2011 07:31:36 -0500 Received: from mail-iy0-f174.google.com ([209.85.210.174]:48182 "EHLO mail-iy0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752281Ab1KSMbg (ORCPT ); Sat, 19 Nov 2011 07:31:36 -0500 Received: by mail-iy0-f174.google.com with SMTP id e36so4861656iag.19 for ; Sat, 19 Nov 2011 04:31:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references; bh=x2usOYSELz9/Btv9G+T9oddpdkPoHk1fKLBJoYe4Dj8=; b=XmyJMT5pdGdMT3KsoBLrpMG+zceJ1I2adiOJPCTmE31f7FbEUZ6vNYGjg9nMZaJFln mqtk44pzx30Kj+mKWhKjSW/w4tNfQkgB3MWqubZIoDRcG9Z4hGn3w2EDYa9GjbpOiUkt 4uPk8FCMNkSr7z+fP3LM4bm2y+1+E59wBJ/Ps= Received: by 10.42.135.66 with SMTP id o2mr6675021ict.0.1321705895766; Sat, 19 Nov 2011 04:31:35 -0800 (PST) Received: from localhost.localdomain ([159.226.43.42]) by mx.google.com with ESMTPS id eb23sm16483257ibb.2.2011.11.19.04.31.33 (version=TLSv1/SSLv3 cipher=OTHER); Sat, 19 Nov 2011 04:31:35 -0800 (PST) From: Yongqiang Yang To: tytso@mit.edu Cc: adilger@dilger.ca, linux-ext4@vger.kernel.org, Yongqiang Yang Subject: [PATCH v4 14/15] ext4: let ext4_group_extend() use common code Date: Sat, 19 Nov 2011 17:57:20 +0800 Message-Id: <1321696641-14437-15-git-send-email-xiaoqiangnk@gmail.com> X-Mailer: git-send-email 1.7.5.1 In-Reply-To: <1321696641-14437-1-git-send-email-xiaoqiangnk@gmail.com> References: <1321696641-14437-1-git-send-email-xiaoqiangnk@gmail.com> Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org From: Yongqiang Yang ext4_group_extend_no_check() is moved out from ext4_group_extend(), this patch lets ext4_group_extend() call ext4_group_extentd_no_check() instead. Signed-off-by: Yongqiang Yang --- fs/ext4/resize.c | 41 ++--------------------------------------- 1 files changed, 2 insertions(+), 39 deletions(-) diff --git a/fs/ext4/resize.c b/fs/ext4/resize.c index 6e0af4b..ba04e0b 100644 --- a/fs/ext4/resize.c +++ b/fs/ext4/resize.c @@ -1804,8 +1804,7 @@ int ext4_group_extend(struct super_block *sb, struct ext4_super_block *es, ext4_grpblk_t last; ext4_grpblk_t add; struct buffer_head *bh; - handle_t *handle; - int err, err2; + int err; ext4_group_t group; o_blocks_count = ext4_blocks_count(es); @@ -1861,43 +1860,7 @@ int ext4_group_extend(struct super_block *sb, struct ext4_super_block *es, } brelse(bh); - /* We will update the superblock, one block bitmap, and - * one group descriptor via ext4_free_blocks(). - */ - handle = ext4_journal_start_sb(sb, 3); - if (IS_ERR(handle)) { - err = PTR_ERR(handle); - ext4_warning(sb, "error %d on journal start", err); - goto exit_put; - } - - if ((err = ext4_journal_get_write_access(handle, - EXT4_SB(sb)->s_sbh))) { - ext4_warning(sb, "error %d on journal write access", err); - ext4_journal_stop(handle); - goto exit_put; - } - ext4_blocks_count_set(es, o_blocks_count + add); - ext4_debug("freeing blocks %llu through %llu\n", o_blocks_count, - o_blocks_count + add); - /* We add the blocks to the bitmap and set the group need init bit */ - err = ext4_group_add_blocks(handle, sb, o_blocks_count, add); - ext4_handle_dirty_super(handle, sb); - ext4_debug("freed blocks %llu through %llu\n", o_blocks_count, - o_blocks_count + add); - err2 = ext4_journal_stop(handle); - if (!err && err2) - err = err2; - - if (err) - goto exit_put; - - if (test_opt(sb, DEBUG)) - printk(KERN_DEBUG "EXT4-fs: extended group to %llu blocks\n", - ext4_blocks_count(es)); - update_backups(sb, EXT4_SB(sb)->s_sbh->b_blocknr, (char *)es, - sizeof(struct ext4_super_block)); -exit_put: + err = ext4_group_extend_no_check(sb, o_blocks_count, add); return err; } /* ext4_group_extend */