Patchwork [U-Boot,2/9] ARM: cerf250: re-add MACH_TYPE_PXA_CERF

login
register
mail settings
Submitter Anatolij Gustschin
Date Nov. 19, 2011, 11:59 a.m.
Message ID <1321703956-4224-3-git-send-email-agust@denx.de>
Download mbox | patch
Permalink /patch/126545/
State Rejected
Delegated to: Albert ARIBAUD
Headers show

Comments

Anatolij Gustschin - Nov. 19, 2011, 11:59 a.m.
MACH_TYPE_PXA_CERF was removed from mach-types.h.
Add it to the board config file.

Signed-off-by: Anatolij Gustschin <agust@denx.de>
---
 board/cerf250/cerf250.c   |    3 ---
 include/configs/cerf250.h |    3 +++
 2 files changed, 3 insertions(+), 3 deletions(-)
Simon Glass - Nov. 19, 2011, 5:56 p.m.
On Sat, Nov 19, 2011 at 3:59 AM, Anatolij Gustschin <agust@denx.de> wrote:
> MACH_TYPE_PXA_CERF was removed from mach-types.h.
> Add it to the board config file.
>
> Signed-off-by: Anatolij Gustschin <agust@denx.de>

I built this and it fixes the failure. I did not test on hardware.

Acked-by: Simon Glass <sjg@chromium.org>

> ---
>  board/cerf250/cerf250.c   |    3 ---
>  include/configs/cerf250.h |    3 +++
>  2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/board/cerf250/cerf250.c b/board/cerf250/cerf250.c
> index 043afea..615c288 100644
> --- a/board/cerf250/cerf250.c
> +++ b/board/cerf250/cerf250.c
> @@ -43,9 +43,6 @@ int board_init (void)
>        dcache_disable();
>        icache_disable();
>
> -       /* arch number of cerf PXA Board */
> -       gd->bd->bi_arch_number = MACH_TYPE_PXA_CERF;
> -
>        /* adress of boot parameters */
>        gd->bd->bi_boot_params = 0xa0000100;
>
> diff --git a/include/configs/cerf250.h b/include/configs/cerf250.h
> index 70427da..dde9e14 100644
> --- a/include/configs/cerf250.h
> +++ b/include/configs/cerf250.h
> @@ -42,6 +42,9 @@
>
>  #undef CONFIG_USE_IRQ                  /* we don't need IRQ/FIQ stuff */
>
> +#define MACH_TYPE_PXA_CERF     139
> +#define CONFIG_MACH_TYPE       MACH_TYPE_PXA_CERF
> +
>  /* we will never enable dcache, because we have to setup MMU first */
>  #define CONFIG_SYS_DCACHE_OFF
>
> --
> 1.7.5.4
>
> _______________________________________________
> U-Boot mailing list
> U-Boot@lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot
>
Marek Vasut - Nov. 20, 2011, 12:09 a.m.
> On Sat, Nov 19, 2011 at 3:59 AM, Anatolij Gustschin <agust@denx.de> wrote:
> > MACH_TYPE_PXA_CERF was removed from mach-types.h.
> > Add it to the board config file.
> > 
> > Signed-off-by: Anatolij Gustschin <agust@denx.de>
> 
> I built this and it fixes the failure. I did not test on hardware.
> 
> Acked-by: Simon Glass <sjg@chromium.org>

Good, CCing original maintainer.

Is the device still activelly used or can we drop it?

M

> 
> > ---
> >  board/cerf250/cerf250.c   |    3 ---
> >  include/configs/cerf250.h |    3 +++
> >  2 files changed, 3 insertions(+), 3 deletions(-)
> > 
> > diff --git a/board/cerf250/cerf250.c b/board/cerf250/cerf250.c
> > index 043afea..615c288 100644
> > --- a/board/cerf250/cerf250.c
> > +++ b/board/cerf250/cerf250.c
> > @@ -43,9 +43,6 @@ int board_init (void)
> >        dcache_disable();
> >        icache_disable();
> > 
> > -       /* arch number of cerf PXA Board */
> > -       gd->bd->bi_arch_number = MACH_TYPE_PXA_CERF;
> > -
> >        /* adress of boot parameters */
> >        gd->bd->bi_boot_params = 0xa0000100;
> > 
> > diff --git a/include/configs/cerf250.h b/include/configs/cerf250.h
> > index 70427da..dde9e14 100644
> > --- a/include/configs/cerf250.h
> > +++ b/include/configs/cerf250.h
> > @@ -42,6 +42,9 @@
> > 
> >  #undef CONFIG_USE_IRQ                  /* we don't need IRQ/FIQ stuff */
> > 
> > +#define MACH_TYPE_PXA_CERF     139
> > +#define CONFIG_MACH_TYPE       MACH_TYPE_PXA_CERF
> > +
> >  /* we will never enable dcache, because we have to setup MMU first */
> >  #define CONFIG_SYS_DCACHE_OFF
> > 
> > --
> > 1.7.5.4
> > 
> > _______________________________________________
> > U-Boot mailing list
> > U-Boot@lists.denx.de
> > http://lists.denx.de/mailman/listinfo/u-boot
> 
> _______________________________________________
> U-Boot mailing list
> U-Boot@lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot
Marek Vasut - Nov. 20, 2011, 12:18 a.m.
> > On Sat, Nov 19, 2011 at 3:59 AM, Anatolij Gustschin <agust@denx.de> wrote:
> > > MACH_TYPE_PXA_CERF was removed from mach-types.h.
> > > Add it to the board config file.
> > > 
> > > Signed-off-by: Anatolij Gustschin <agust@denx.de>
> > 
> > I built this and it fixes the failure. I did not test on hardware.
> > 
> > Acked-by: Simon Glass <sjg@chromium.org>
> 
> Good, CCing original maintainer.
> 
> Is the device still activelly used or can we drop it?
> 
> M

I see delivery failure to the address, this board is dead. Time for a good-bye 
patch?

M
> 
> > > ---
> > > 
> > >  board/cerf250/cerf250.c   |    3 ---
> > >  include/configs/cerf250.h |    3 +++
> > >  2 files changed, 3 insertions(+), 3 deletions(-)
> > > 
> > > diff --git a/board/cerf250/cerf250.c b/board/cerf250/cerf250.c
> > > index 043afea..615c288 100644
> > > --- a/board/cerf250/cerf250.c
> > > +++ b/board/cerf250/cerf250.c
> > > @@ -43,9 +43,6 @@ int board_init (void)
> > > 
> > >        dcache_disable();
> > >        icache_disable();
> > > 
> > > -       /* arch number of cerf PXA Board */
> > > -       gd->bd->bi_arch_number = MACH_TYPE_PXA_CERF;
> > > -
> > > 
> > >        /* adress of boot parameters */
> > >        gd->bd->bi_boot_params = 0xa0000100;
> > > 
> > > diff --git a/include/configs/cerf250.h b/include/configs/cerf250.h
> > > index 70427da..dde9e14 100644
> > > --- a/include/configs/cerf250.h
> > > +++ b/include/configs/cerf250.h
> > > @@ -42,6 +42,9 @@
> > > 
> > >  #undef CONFIG_USE_IRQ                  /* we don't need IRQ/FIQ stuff
> > >  */
> > > 
> > > +#define MACH_TYPE_PXA_CERF     139
> > > +#define CONFIG_MACH_TYPE       MACH_TYPE_PXA_CERF
> > > +
> > > 
> > >  /* we will never enable dcache, because we have to setup MMU first */
> > >  #define CONFIG_SYS_DCACHE_OFF
> > > 
> > > --
> > > 1.7.5.4
> > > 
> > > _______________________________________________
> > > U-Boot mailing list
> > > U-Boot@lists.denx.de
> > > http://lists.denx.de/mailman/listinfo/u-boot
> > 
> > _______________________________________________
> > U-Boot mailing list
> > U-Boot@lists.denx.de
> > http://lists.denx.de/mailman/listinfo/u-boot
Albert ARIBAUD - Nov. 21, 2011, 4:44 p.m.
Hi Marek,

> I see delivery failure to the address, this board is dead. Time for a good-bye
> patch?

Yes, let us drop the board. If someone wants to resurrect it, they can 
step forward any time.

Amicalement,

Patch

diff --git a/board/cerf250/cerf250.c b/board/cerf250/cerf250.c
index 043afea..615c288 100644
--- a/board/cerf250/cerf250.c
+++ b/board/cerf250/cerf250.c
@@ -43,9 +43,6 @@  int board_init (void)
 	dcache_disable();
 	icache_disable();
 
-	/* arch number of cerf PXA Board */
-	gd->bd->bi_arch_number = MACH_TYPE_PXA_CERF;
-
 	/* adress of boot parameters */
 	gd->bd->bi_boot_params = 0xa0000100;
 
diff --git a/include/configs/cerf250.h b/include/configs/cerf250.h
index 70427da..dde9e14 100644
--- a/include/configs/cerf250.h
+++ b/include/configs/cerf250.h
@@ -42,6 +42,9 @@ 
 
 #undef	CONFIG_USE_IRQ			/* we don't need IRQ/FIQ stuff */
 
+#define MACH_TYPE_PXA_CERF	139
+#define CONFIG_MACH_TYPE	MACH_TYPE_PXA_CERF
+
 /* we will never enable dcache, because we have to setup MMU first */
 #define CONFIG_SYS_DCACHE_OFF