Patchwork [U-Boot,3/9] ARM: cradle: re-add MACH_TYPE_HHP_CRADLE

login
register
mail settings
Submitter Anatolij Gustschin
Date Nov. 19, 2011, 11:59 a.m.
Message ID <1321703956-4224-4-git-send-email-agust@denx.de>
Download mbox | patch
Permalink /patch/126541/
State Rejected
Delegated to: Albert ARIBAUD
Headers show

Comments

Anatolij Gustschin - Nov. 19, 2011, 11:59 a.m.
MACH_TYPE_HHP_CRADLE was removed from mach-types.h.
Add it to the board config file.

Signed-off-by: Anatolij Gustschin <agust@denx.de>
---
 board/cradle/cradle.c    |    3 ---
 include/configs/cradle.h |    3 +++
 2 files changed, 3 insertions(+), 3 deletions(-)
Simon Glass - Nov. 19, 2011, 5:57 p.m.
On Sat, Nov 19, 2011 at 3:59 AM, Anatolij Gustschin <agust@denx.de> wrote:
> MACH_TYPE_HHP_CRADLE was removed from mach-types.h.
> Add it to the board config file.
>
> Signed-off-by: Anatolij Gustschin <agust@denx.de>

I built this and it fixes the failure. I did not test on hardware.

Acked-by: Simon Glass <sjg@chromium.org>

> ---
>  board/cradle/cradle.c    |    3 ---
>  include/configs/cradle.h |    3 +++
>  2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/board/cradle/cradle.c b/board/cradle/cradle.c
> index 2bbf2d5..e9f38f8 100644
> --- a/board/cradle/cradle.c
> +++ b/board/cradle/cradle.c
> @@ -191,9 +191,6 @@ board_init (void)
>
>        led_code (0xf, YELLOW);
>
> -       /* arch number of HHP Cradle */
> -       gd->bd->bi_arch_number = MACH_TYPE_HHP_CRADLE;
> -
>        /* adress of boot parameters */
>        gd->bd->bi_boot_params = 0xa0000100;
>
> diff --git a/include/configs/cradle.h b/include/configs/cradle.h
> index 25be616..d56deee 100644
> --- a/include/configs/cradle.h
> +++ b/include/configs/cradle.h
> @@ -35,6 +35,9 @@
>  #define CONFIG_PXA250           1       /* This is an PXA250 CPU    */
>  #define CONFIG_HHP_CRADLE       1       /* on an Cradle Board       */
>
> +#define MACH_TYPE_HHP_CRADLE   210
> +#define CONFIG_MACH_TYPE       MACH_TYPE_HHP_CRADLE
> +
>  #undef CONFIG_USE_IRQ                   /* we don't need IRQ/FIQ stuff */
>
>  /* we will never enable dcache, because we have to setup MMU first */
> --
> 1.7.5.4
>
> _______________________________________________
> U-Boot mailing list
> U-Boot@lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot
>
Marek Vasut - Nov. 21, 2011, 10:28 p.m.
> MACH_TYPE_HHP_CRADLE was removed from mach-types.h.
> Add it to the board config file.
> 
> Signed-off-by: Anatolij Gustschin <agust@denx.de>
> ---
>  board/cradle/cradle.c    |    3 ---
>  include/configs/cradle.h |    3 +++
>  2 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/board/cradle/cradle.c b/board/cradle/cradle.c
> index 2bbf2d5..e9f38f8 100644
> --- a/board/cradle/cradle.c
> +++ b/board/cradle/cradle.c
> @@ -191,9 +191,6 @@ board_init (void)
> 
>  	led_code (0xf, YELLOW);
> 
> -	/* arch number of HHP Cradle */
> -	gd->bd->bi_arch_number = MACH_TYPE_HHP_CRADLE;
> -
>  	/* adress of boot parameters */
>  	gd->bd->bi_boot_params = 0xa0000100;
> 
> diff --git a/include/configs/cradle.h b/include/configs/cradle.h
> index 25be616..d56deee 100644
> --- a/include/configs/cradle.h
> +++ b/include/configs/cradle.h
> @@ -35,6 +35,9 @@
>  #define CONFIG_PXA250           1       /* This is an PXA250 CPU    */
>  #define CONFIG_HHP_CRADLE       1       /* on an Cradle Board       */
> 
> +#define MACH_TYPE_HHP_CRADLE	210
> +#define CONFIG_MACH_TYPE	MACH_TYPE_HHP_CRADLE
> +
>  #undef CONFIG_USE_IRQ                   /* we don't need IRQ/FIQ stuff */
> 
>  /* we will never enable dcache, because we have to setup MMU first */

Hey,

this thing too ... is the maintainer still alive ? If not, time for a good-bye 
patch too (according to the MAINTAINERS file, it's time for a good bye patch).

M

Patch

diff --git a/board/cradle/cradle.c b/board/cradle/cradle.c
index 2bbf2d5..e9f38f8 100644
--- a/board/cradle/cradle.c
+++ b/board/cradle/cradle.c
@@ -191,9 +191,6 @@  board_init (void)
 
 	led_code (0xf, YELLOW);
 
-	/* arch number of HHP Cradle */
-	gd->bd->bi_arch_number = MACH_TYPE_HHP_CRADLE;
-
 	/* adress of boot parameters */
 	gd->bd->bi_boot_params = 0xa0000100;
 
diff --git a/include/configs/cradle.h b/include/configs/cradle.h
index 25be616..d56deee 100644
--- a/include/configs/cradle.h
+++ b/include/configs/cradle.h
@@ -35,6 +35,9 @@ 
 #define CONFIG_PXA250           1       /* This is an PXA250 CPU    */
 #define CONFIG_HHP_CRADLE       1       /* on an Cradle Board       */
 
+#define MACH_TYPE_HHP_CRADLE	210
+#define CONFIG_MACH_TYPE	MACH_TYPE_HHP_CRADLE
+
 #undef CONFIG_USE_IRQ                   /* we don't need IRQ/FIQ stuff */
 
 /* we will never enable dcache, because we have to setup MMU first */