| Message ID | 20200331152428.33951-1-andriy.shevchenko@linux.intel.com |
|---|---|
| State | New |
| Headers | show |
| Series | [v1] pinctrl: baytrail: Enable pin configuration setting for GPIO chip | expand |
On Tue, Mar 31, 2020 at 06:24:28PM +0300, Andy Shevchenko wrote: > It appears that pin configuration for GPIO chip hasn't been enabled yet > due to absence of ->set_config() callback. > > Enable it here for Intel Baytrail. > > Fixes: c501d0b149de ("pinctrl: baytrail: Add pin control operations") > Depends-on: 2956b5d94a76 ("pinctrl / gpio: Introduce .set_config() callback for GPIO chips") > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
On Wed, Apr 01, 2020 at 12:46:20PM +0300, Mika Westerberg wrote: > On Tue, Mar 31, 2020 at 06:24:28PM +0300, Andy Shevchenko wrote: > > It appears that pin configuration for GPIO chip hasn't been enabled yet > > due to absence of ->set_config() callback. > > > > Enable it here for Intel Baytrail. > > > > Fixes: c501d0b149de ("pinctrl: baytrail: Add pin control operations") > > Depends-on: 2956b5d94a76 ("pinctrl / gpio: Introduce .set_config() callback for GPIO chips") > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > > Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com> Pushed to fixes, thanks!
diff --git a/drivers/pinctrl/intel/pinctrl-baytrail.c b/drivers/pinctrl/intel/pinctrl-baytrail.c index b409642f168d..9b821c9cbd16 100644 --- a/drivers/pinctrl/intel/pinctrl-baytrail.c +++ b/drivers/pinctrl/intel/pinctrl-baytrail.c @@ -1286,6 +1286,7 @@ static const struct gpio_chip byt_gpio_chip = { .direction_output = byt_gpio_direction_output, .get = byt_gpio_get, .set = byt_gpio_set, + .set_config = gpiochip_generic_config, .dbg_show = byt_gpio_dbg_show, };
It appears that pin configuration for GPIO chip hasn't been enabled yet due to absence of ->set_config() callback. Enable it here for Intel Baytrail. Fixes: c501d0b149de ("pinctrl: baytrail: Add pin control operations") Depends-on: 2956b5d94a76 ("pinctrl / gpio: Introduce .set_config() callback for GPIO chips") Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> --- drivers/pinctrl/intel/pinctrl-baytrail.c | 1 + 1 file changed, 1 insertion(+)