diff mbox series

configs: ls1012afrwy: drop env qspi_bootcmd

Message ID 20200331082419.30149-1-biwen.li@oss.nxp.com
State Changes Requested
Delegated to: Priyanka Jain
Headers show
Series configs: ls1012afrwy: drop env qspi_bootcmd | expand

Commit Message

Biwen Li March 31, 2020, 8:24 a.m. UTC 
From: Biwen Li <biwen.li@nxp.com>

Drop useless environment variable installer and qspi_bootcmd
for ls1012afrwy

Signed-off-by: Biwen Li <biwen.li@nxp.com>
---
 include/configs/ls1012afrwy.h | 9 ---------
 1 file changed, 9 deletions(-)

Comments

Priyanka Jain (OSS) April 15, 2020, 10:08 a.m. UTC | #1 
>-----Original Message-----
>From: U-Boot <u-boot-bounces@lists.denx.de> On Behalf Of Biwen Li
>Sent: Tuesday, March 31, 2020 1:54 PM
>To: Jagdish Gediya <jagdish.gediya@nxp.com>; Priyanka Jain
><priyanka.jain@nxp.com>; Pramod Kumar <pramod.kumar_1@nxp.com>;
>Shengzhou Liu <shengzhou.liu@nxp.com>
>Cc: Alison Wang <alison.wang@nxp.com>; u-boot@lists.denx.de; Jiafei Pan
><jiafei.pan@nxp.com>; Biwen Li <biwen.li@nxp.com>
>Subject: [PATCH] configs: ls1012afrwy: drop env qspi_bootcmd
>
>From: Biwen Li <biwen.li@nxp.com>
>
>Drop useless environment variable installer and qspi_bootcmd for
>ls1012afrwy
>
Please explain why these variables are useless

Thanks
Priyanka
>Signed-off-by: Biwen Li <biwen.li@nxp.com>
>---
> include/configs/ls1012afrwy.h | 9 ---------
> 1 file changed, 9 deletions(-)
>
>diff --git a/include/configs/ls1012afrwy.h b/include/configs/ls1012afrwy.h
>index 9007249804..ec071d0606 100644
>--- a/include/configs/ls1012afrwy.h
>+++ b/include/configs/ls1012afrwy.h
>@@ -107,15 +107,6 @@
> 			"env exists secureboot "	\
> 			"&& esbc_validate ${scripthdraddr};"    \
> 		"source ${scriptaddr}\0"	  \
>-	"installer=load mmc 0:2 $load_addr "	\
>-		   "/flex_installer_arm64.itb; "	\
>-		   "bootm $load_addr#$board\0"	\
>-	"qspi_bootcmd=pfe stop; echo Trying load from qspi..;"	\
>-		"sf probe && sf read $load_addr "	\
>-		"$kernel_addr $kernel_size; env exists secureboot "	\
>-		"&& sf read $kernelheader_addr_r $kernelheader_addr "
>	\
>-		"$kernelheader_size && esbc_validate
>${kernelheader_addr_r}; " \
>-		"bootm $load_addr#$board\0"	\
> 	"sd_bootcmd=pfe stop; echo Trying load from sd card..;"
>	\
> 		"mmcinfo; mmc read $load_addr "			\
> 		"$kernel_addr_sd $kernel_size_sd ;"		\
>--
>2.17.1
Biwen Li April 15, 2020, 12:23 p.m. UTC | #2 
> 
> >-----Original Message-----
> >From: U-Boot <u-boot-bounces@lists.denx.de> On Behalf Of Biwen Li
> >Sent: Tuesday, March 31, 2020 1:54 PM
> >To: Jagdish Gediya <jagdish.gediya@nxp.com>; Priyanka Jain
> ><priyanka.jain@nxp.com>; Pramod Kumar <pramod.kumar_1@nxp.com>;
> >Shengzhou Liu <shengzhou.liu@nxp.com>
> >Cc: Alison Wang <alison.wang@nxp.com>; u-boot@lists.denx.de; Jiafei Pan
> ><jiafei.pan@nxp.com>; Biwen Li <biwen.li@nxp.com>
> >Subject: [PATCH] configs: ls1012afrwy: drop env qspi_bootcmd
> >
> >From: Biwen Li <biwen.li@nxp.com>
> >
> >Drop useless environment variable installer and qspi_bootcmd for
> >ls1012afrwy
> >
> Please explain why these variables are useless
Only 2 MB nor flash in ls1012afrwy. So cannnot get kernel(30 MB) from the nor flash.
> 
> Thanks
> Priyanka
> >Signed-off-by: Biwen Li <biwen.li@nxp.com>
> >---
> > include/configs/ls1012afrwy.h | 9 ---------
> > 1 file changed, 9 deletions(-)
> >
> >diff --git a/include/configs/ls1012afrwy.h
> >b/include/configs/ls1012afrwy.h index 9007249804..ec071d0606 100644
> >--- a/include/configs/ls1012afrwy.h
> >+++ b/include/configs/ls1012afrwy.h
> >@@ -107,15 +107,6 @@
> > 			"env exists secureboot "	\
> > 			"&& esbc_validate ${scripthdraddr};"    \
> > 		"source ${scriptaddr}\0"	  \
> >-	"installer=load mmc 0:2 $load_addr "	\
> >-		   "/flex_installer_arm64.itb; "	\
> >-		   "bootm $load_addr#$board\0"	\
> >-	"qspi_bootcmd=pfe stop; echo Trying load from qspi..;"	\
> >-		"sf probe && sf read $load_addr "	\
> >-		"$kernel_addr $kernel_size; env exists secureboot "	\
> >-		"&& sf read $kernelheader_addr_r $kernelheader_addr "
> >	\
> >-		"$kernelheader_size && esbc_validate
> >${kernelheader_addr_r}; " \
> >-		"bootm $load_addr#$board\0"	\
> > 	"sd_bootcmd=pfe stop; echo Trying load from sd card..;"
> >	\
> > 		"mmcinfo; mmc read $load_addr "			\
> > 		"$kernel_addr_sd $kernel_size_sd ;"		\
> >--
> >2.17.1
Priyanka Jain (OSS) April 16, 2020, 7:12 a.m. UTC | #3 
>-----Original Message-----
>From: Biwen Li <biwen.li@nxp.com>
>Sent: Wednesday, April 15, 2020 5:54 PM
>To: Priyanka Jain (OSS) <priyanka.jain@oss.nxp.com>; Biwen Li (OSS)
><biwen.li@oss.nxp.com>; Jagdish Gediya <jagdish.gediya@nxp.com>; Pramod
>Kumar <pramod.kumar_1@nxp.com>; Shengzhou Liu
><shengzhou.liu@nxp.com>
>Cc: Alison Wang <alison.wang@nxp.com>; u-boot@lists.denx.de; Jiafei Pan
><jiafei.pan@nxp.com>
>Subject: RE: [PATCH] configs: ls1012afrwy: drop env qspi_bootcmd
>
>>
>> >-----Original Message-----
>> >From: U-Boot <u-boot-bounces@lists.denx.de> On Behalf Of Biwen Li
>> >Sent: Tuesday, March 31, 2020 1:54 PM
>> >To: Jagdish Gediya <jagdish.gediya@nxp.com>; Priyanka Jain
>> ><priyanka.jain@nxp.com>; Pramod Kumar <pramod.kumar_1@nxp.com>;
>> >Shengzhou Liu <shengzhou.liu@nxp.com>
>> >Cc: Alison Wang <alison.wang@nxp.com>; u-boot@lists.denx.de; Jiafei
>> >Pan <jiafei.pan@nxp.com>; Biwen Li <biwen.li@nxp.com>
>> >Subject: [PATCH] configs: ls1012afrwy: drop env qspi_bootcmd
>> >
>> >From: Biwen Li <biwen.li@nxp.com>
>> >
>> >Drop useless environment variable installer and qspi_bootcmd for
>> >ls1012afrwy
>> >
>> Please explain why these variables are useless
>Only 2 MB nor flash in ls1012afrwy. So cannnot get kernel(30 MB) from the
>nor flash.
Thanks Biwen.
Please provide this explanation in patch description. 
In future patches also please ensure to provided proper description for reviewers to easily review.

Regards
Priyanka
>>
>> Thanks
>> Priyanka
>> >Signed-off-by: Biwen Li <biwen.li@nxp.com>
>> >---
>> > include/configs/ls1012afrwy.h | 9 ---------
>> > 1 file changed, 9 deletions(-)
>> >
>> >diff --git a/include/configs/ls1012afrwy.h
>> >b/include/configs/ls1012afrwy.h index 9007249804..ec071d0606 100644
>> >--- a/include/configs/ls1012afrwy.h
>> >+++ b/include/configs/ls1012afrwy.h
>> >@@ -107,15 +107,6 @@
>> > 			"env exists secureboot "	\
>> > 			"&& esbc_validate ${scripthdraddr};"    \
>> > 		"source ${scriptaddr}\0"	  \
>> >-	"installer=load mmc 0:2 $load_addr "	\
>> >-		   "/flex_installer_arm64.itb; "	\
>> >-		   "bootm $load_addr#$board\0"	\
>> >-	"qspi_bootcmd=pfe stop; echo Trying load from qspi..;"	\
>> >-		"sf probe && sf read $load_addr "	\
>> >-		"$kernel_addr $kernel_size; env exists secureboot "	\
>> >-		"&& sf read $kernelheader_addr_r $kernelheader_addr "
>> >	\
>> >-		"$kernelheader_size && esbc_validate
>> >${kernelheader_addr_r}; " \
>> >-		"bootm $load_addr#$board\0"	\
>> > 	"sd_bootcmd=pfe stop; echo Trying load from sd card..;"
>> >	\
>> > 		"mmcinfo; mmc read $load_addr "			\
>> > 		"$kernel_addr_sd $kernel_size_sd ;"		\
>> >--
>> >2.17.1
diff mbox series

Patch

diff --git a/include/configs/ls1012afrwy.h b/include/configs/ls1012afrwy.h
index 9007249804..ec071d0606 100644
--- a/include/configs/ls1012afrwy.h
+++ b/include/configs/ls1012afrwy.h
@@ -107,15 +107,6 @@ 
 			"env exists secureboot "	\
 			"&& esbc_validate ${scripthdraddr};"    \
 		"source ${scriptaddr}\0"	  \
-	"installer=load mmc 0:2 $load_addr "	\
-		   "/flex_installer_arm64.itb; "	\
-		   "bootm $load_addr#$board\0"	\
-	"qspi_bootcmd=pfe stop; echo Trying load from qspi..;"	\
-		"sf probe && sf read $load_addr "	\
-		"$kernel_addr $kernel_size; env exists secureboot "	\
-		"&& sf read $kernelheader_addr_r $kernelheader_addr "	\
-		"$kernelheader_size && esbc_validate ${kernelheader_addr_r}; " \
-		"bootm $load_addr#$board\0"	\
 	"sd_bootcmd=pfe stop; echo Trying load from sd card..;"		\
 		"mmcinfo; mmc read $load_addr "			\
 		"$kernel_addr_sd $kernel_size_sd ;"		\