Patchwork PR 44707 testcase failure

login
register
mail settings
Submitter Ulrich Weigand
Date Nov. 18, 2011, 6:19 p.m.
Message ID <201111181819.pAIIJ6Cc032280@d06av02.portsmouth.uk.ibm.com>
Download mbox | patch
Permalink /patch/126462/
State New
Headers show

Comments

Ulrich Weigand - Nov. 18, 2011, 6:19 p.m.
Mike Stump wrote:
> On Nov 18, 2011, at 9:04 AM, "Ulrich Weigand" <uweigand@de.ibm.com> wrote:
> > Huh, it seems the test in this form assumes the assembler supports /* ...  */
> > comments.  But this isn't really necessary for the test to work; I think the
> > best fix would be to just remove the comment and simply write 20
> >   __asm__ volatile ("" : : "nro" (e1), "nro" (e2), "nro" (e3 ...
> > instead.
> 
> Sounds good to me.

OK, I've checked in the following patch.

Tested on i386-linux.

Bye,
Ulrich

ChangeLog:

	* gcc.c-torture/compile/pr44707.c: Do not assume assembler
	supports /* ... */ comments.

Patch

Index: gcc/testsuite/gcc.c-torture/compile/pr44707.c
===================================================================
--- gcc/testsuite/gcc.c-torture/compile/pr44707.c	(revision 181162)
+++ gcc/testsuite/gcc.c-torture/compile/pr44707.c	(working copy)
@@ -9,6 +9,6 @@ 
   int e3 = v.b;
   int e4 = v.c;
   int e5 = v.d;
-  __asm__ volatile ("/* %0 %1 %2 %3 %4 */" : : "nro" (e1), "nro" (e2), "nro" (e3), "nro" (e4), "nro" (e5));
+  __asm__ volatile ("" : : "nro" (e1), "nro" (e2), "nro" (e3), "nro" (e4), "nro" (e5));
 }