| Message ID | 474bb6cf67defb8be9de5035c11aee57a680557a.1585641083.git.maozhongyi@cmss.chinamobile.com |
|---|---|
| State | New |
| Headers | show |
| Series | Improved reporting for migrate parameters | expand |
On Tue, Mar 31, 2020 at 04:22:07PM +0800, Mao Zhongyi wrote: > Signed-off-by: Mao Zhongyi <maozhongyi@cmss.chinamobile.com> > Reviewed-by: Juan Quintela <quintela@redhat.com> > --- > migration/migration.c | 2 +- > monitor/hmp-cmds.c | 8 ++++---- > 2 files changed, 5 insertions(+), 5 deletions(-) Thank you for these changes! Reviewed-by: Stefano Garzarella <sgarzare@redhat.com> > > diff --git a/migration/migration.c b/migration/migration.c > index 5a6436d035..b3d36d1467 100644 > --- a/migration/migration.c > +++ b/migration/migration.c > @@ -1214,7 +1214,7 @@ static bool migrate_params_check(MigrationParameters *params, Error **errp) > error_setg(errp, QERR_INVALID_PARAMETER_VALUE, > "downtime_limit", > "an integer in the range of 0 to " > - stringify(MAX_MIGRATE_DOWNTIME)" milliseconds"); > + stringify(MAX_MIGRATE_DOWNTIME)" ms"); > return false; > } > > diff --git a/monitor/hmp-cmds.c b/monitor/hmp-cmds.c > index 63097ddcc8..c5de8af1ee 100644 > --- a/monitor/hmp-cmds.c > +++ b/monitor/hmp-cmds.c > @@ -231,18 +231,18 @@ void hmp_info_migrate(Monitor *mon, const QDict *qdict) > monitor_printf(mon, "\n"); > } > > - monitor_printf(mon, "total time: %" PRIu64 " milliseconds\n", > + monitor_printf(mon, "total time: %" PRIu64 " ms\n", > info->total_time); > if (info->has_expected_downtime) { > - monitor_printf(mon, "expected downtime: %" PRIu64 " milliseconds\n", > + monitor_printf(mon, "expected downtime: %" PRIu64 " ms\n", > info->expected_downtime); > } > if (info->has_downtime) { > - monitor_printf(mon, "downtime: %" PRIu64 " milliseconds\n", > + monitor_printf(mon, "downtime: %" PRIu64 " ms\n", > info->downtime); > } > if (info->has_setup_time) { > - monitor_printf(mon, "setup: %" PRIu64 " milliseconds\n", > + monitor_printf(mon, "setup: %" PRIu64 " ms\n", > info->setup_time); > } > } > -- > 2.17.1 > > > >
diff --git a/migration/migration.c b/migration/migration.c index 5a6436d035..b3d36d1467 100644 --- a/migration/migration.c +++ b/migration/migration.c @@ -1214,7 +1214,7 @@ static bool migrate_params_check(MigrationParameters *params, Error **errp) error_setg(errp, QERR_INVALID_PARAMETER_VALUE, "downtime_limit", "an integer in the range of 0 to " - stringify(MAX_MIGRATE_DOWNTIME)" milliseconds"); + stringify(MAX_MIGRATE_DOWNTIME)" ms"); return false; } diff --git a/monitor/hmp-cmds.c b/monitor/hmp-cmds.c index 63097ddcc8..c5de8af1ee 100644 --- a/monitor/hmp-cmds.c +++ b/monitor/hmp-cmds.c @@ -231,18 +231,18 @@ void hmp_info_migrate(Monitor *mon, const QDict *qdict) monitor_printf(mon, "\n"); } - monitor_printf(mon, "total time: %" PRIu64 " milliseconds\n", + monitor_printf(mon, "total time: %" PRIu64 " ms\n", info->total_time); if (info->has_expected_downtime) { - monitor_printf(mon, "expected downtime: %" PRIu64 " milliseconds\n", + monitor_printf(mon, "expected downtime: %" PRIu64 " ms\n", info->expected_downtime); } if (info->has_downtime) { - monitor_printf(mon, "downtime: %" PRIu64 " milliseconds\n", + monitor_printf(mon, "downtime: %" PRIu64 " ms\n", info->downtime); } if (info->has_setup_time) { - monitor_printf(mon, "setup: %" PRIu64 " milliseconds\n", + monitor_printf(mon, "setup: %" PRIu64 " ms\n", info->setup_time); } }