diff mbox series

[u-boot-marvell,4/4] arm: mvebu: dts: turris_mox: fix USB3 regulator

Message ID 20200330171926.26119-4-marek.behun@nic.cz
State Superseded
Delegated to: Stefan Roese
Headers show
Series [u-boot-marvell,1/4] arm: mvebu: turris_mox: Fix early SPI communication | expand

Commit Message

Marek Behún March 30, 2020, 5:19 p.m. UTC 
Commit e8e9715df2d4 requires the USB3 regulator node to have the
enable-active-high property for the regulator to work properly. The
GPIO_ACTIVE_HIGH constant is not enough anymore.

Signed-off-by: Marek Behún <marek.behun@nic.cz>
Fixes: e8e9715df2d4 ("regulator: fixed: Modify enable-active-high...")
---
 arch/arm/dts/armada-3720-turris-mox.dts | 1 +
 1 file changed, 1 insertion(+)

Comments

Stefan Roese March 31, 2020, 10:24 a.m. UTC | #1 
On 30.03.20 19:19, Marek Behún wrote:
> Commit e8e9715df2d4 requires the USB3 regulator node to have the
> enable-active-high property for the regulator to work properly. The
> GPIO_ACTIVE_HIGH constant is not enough anymore.
> 
> Signed-off-by: Marek Behún <marek.behun@nic.cz>
> Fixes: e8e9715df2d4 ("regulator: fixed: Modify enable-active-high...")
> ---
>   arch/arm/dts/armada-3720-turris-mox.dts | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm/dts/armada-3720-turris-mox.dts b/arch/arm/dts/armada-3720-turris-mox.dts
> index 4c65c3e32c..a1e0ad5020 100644
> --- a/arch/arm/dts/armada-3720-turris-mox.dts
> +++ b/arch/arm/dts/armada-3720-turris-mox.dts
> @@ -42,6 +42,7 @@
>   		startup-delay-us = <2000000>;
>   		shutdown-delay-us = <1000000>;
>   		gpio = <&gpiosb 0 GPIO_ACTIVE_HIGH>;
> +		enable-active-high;
>   		regulator-boot-on;
>   	};
>   

Reviewed-by: Stefan Roese <sr@denx.de>

Thanks,
Stefan
diff mbox series

Patch

diff --git a/arch/arm/dts/armada-3720-turris-mox.dts b/arch/arm/dts/armada-3720-turris-mox.dts
index 4c65c3e32c..a1e0ad5020 100644
--- a/arch/arm/dts/armada-3720-turris-mox.dts
+++ b/arch/arm/dts/armada-3720-turris-mox.dts
@@ -42,6 +42,7 @@ 
 		startup-delay-us = <2000000>;
 		shutdown-delay-us = <1000000>;
 		gpio = <&gpiosb 0 GPIO_ACTIVE_HIGH>;
+		enable-active-high;
 		regulator-boot-on;
 	};