diff mbox

[net-next-2.6,TPROXY] fixes a possible read from an unmapped location in the socket match

Message ID 1228674863.15263.82.camel@bzorp.balabit
State Not Applicable, archived
Delegated to: David Miller
Headers show

Commit Message

Balazs Scheidler Dec. 7, 2008, 10:16 a.m. UTC 
TIME_WAIT sockets need to be handled specially, and the socket match
	casted inet_timewait_sock instances to inet_sock, which are not
	compatible. Handle this special case by checking sk->sk_state.
---
 net/netfilter/xt_socket.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Comments

David Miller Dec. 8, 2008, 7:54 a.m. UTC | #1 
From: Balazs Scheidler <bazsi@balabit.hu>
Date: Sun, 7 Dec 2008 11:16:53 +0100

> 	TIME_WAIT sockets need to be handled specially, and the socket match
> 	casted inet_timewait_sock instances to inet_sock, which are not
> 	compatible. Handle this special case by checking sk->sk_state.

There is no need to send this seperate version of the patch,
the bug fix will propagate automatically when I next merge
net-2.6 into net-next-2.6
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/net/netfilter/xt_socket.c b/net/netfilter/xt_socket.c
index 0e03922..1d521a5 100644
--- a/net/netfilter/xt_socket.c
+++ b/net/netfilter/xt_socket.c
@@ -144,7 +144,7 @@  socket_mt(const struct sk_buff *skb, const struct xt_match_param *par)
 	sk = nf_tproxy_get_sock_v4(dev_net(skb->dev), protocol,
 				   saddr, daddr, sport, dport, par->in, false);
 	if (sk != NULL) {
-		bool wildcard = (inet_sk(sk)->rcv_saddr == 0);
+		bool wildcard = (sk->sk_state != TCP_TIME_WAIT && inet_sk(sk)->rcv_saddr == 0);
 
 		nf_tproxy_put_sock(sk);
 		if (wildcard)