diff mbox series

[2/2] nanpi_neo4_config: Enable BR2_TARGET_ARM_TRUSTED_FIRMWARE_NEEDS_ARM32_TOOLCHAIN option

Message ID 1585574086-28047-2-git-send-email-marek.belisko@open-nandra.com
State Changes Requested
Headers show
Series [1/2] Revert "configs/nanopi_neo4: remove defconfig" | expand

Commit Message

Marek Belisko March 30, 2020, 1:14 p.m. UTC 
Signed-off-by: Marek Belisko <marek.belisko@open-nandra.com>
---
 configs/nanopi_neo4_defconfig | 1 +
 1 file changed, 1 insertion(+)

Comments

Sergey Matyukevich March 30, 2020, 3:25 p.m. UTC | #1 
> Signed-off-by: Marek Belisko <marek.belisko@open-nandra.com>
> ---
>  configs/nanopi_neo4_defconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/configs/nanopi_neo4_defconfig b/configs/nanopi_neo4_defconfig
> index 0e58aea..2bffe66 100644
> --- a/configs/nanopi_neo4_defconfig
> +++ b/configs/nanopi_neo4_defconfig
> @@ -11,6 +11,7 @@ BR2_TARGET_ARM_TRUSTED_FIRMWARE_CUSTOM_GIT=y
>  BR2_TARGET_ARM_TRUSTED_FIRMWARE_CUSTOM_REPO_URL="https://github.com/ARM-software/arm-trusted-firmware"
>  BR2_TARGET_ARM_TRUSTED_FIRMWARE_CUSTOM_REPO_VERSION="v2.0"
>  BR2_TARGET_ARM_TRUSTED_FIRMWARE_PLATFORM="rk3399"
> +BR2_TARGET_ARM_TRUSTED_FIRMWARE_NEEDS_ARM32_TOOLCHAIN=y
>  BR2_TARGET_ARM_TRUSTED_FIRMWARE_BL31=y

I would suggest to write proper commit messages for these two patches.

Otherwise neo4 build looks good:
Tested-by: Sergey Matyukevich <geomatsi@gmail.com>

Regards,
Sergey
Belisko Marek March 30, 2020, 4:38 p.m. UTC | #2 
On Mon, Mar 30, 2020 at 5:20 PM Sergey Matyukevich <geomatsi@gmail.com> wrote:
>
> > Signed-off-by: Marek Belisko <marek.belisko@open-nandra.com>
> > ---
> >  configs/nanopi_neo4_defconfig | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/configs/nanopi_neo4_defconfig b/configs/nanopi_neo4_defconfig
> > index 0e58aea..2bffe66 100644
> > --- a/configs/nanopi_neo4_defconfig
> > +++ b/configs/nanopi_neo4_defconfig
> > @@ -11,6 +11,7 @@ BR2_TARGET_ARM_TRUSTED_FIRMWARE_CUSTOM_GIT=y
> >  BR2_TARGET_ARM_TRUSTED_FIRMWARE_CUSTOM_REPO_URL="https://github.com/ARM-software/arm-trusted-firmware"
> >  BR2_TARGET_ARM_TRUSTED_FIRMWARE_CUSTOM_REPO_VERSION="v2.0"
> >  BR2_TARGET_ARM_TRUSTED_FIRMWARE_PLATFORM="rk3399"
> > +BR2_TARGET_ARM_TRUSTED_FIRMWARE_NEEDS_ARM32_TOOLCHAIN=y
> >  BR2_TARGET_ARM_TRUSTED_FIRMWARE_BL31=y
>
> I would suggest to write proper commit messages for these two patches.
OK fine. I have in queue also patch for bumping kernel to 5.4 will
test and post updated version. Thanks.
>
> Otherwise neo4 build looks good:
> Tested-by: Sergey Matyukevich <geomatsi@gmail.com>
>
> Regards,
> Sergey

BR,

marek
diff mbox series

Patch

diff --git a/configs/nanopi_neo4_defconfig b/configs/nanopi_neo4_defconfig
index 0e58aea..2bffe66 100644
--- a/configs/nanopi_neo4_defconfig
+++ b/configs/nanopi_neo4_defconfig
@@ -11,6 +11,7 @@  BR2_TARGET_ARM_TRUSTED_FIRMWARE_CUSTOM_GIT=y
 BR2_TARGET_ARM_TRUSTED_FIRMWARE_CUSTOM_REPO_URL="https://github.com/ARM-software/arm-trusted-firmware"
 BR2_TARGET_ARM_TRUSTED_FIRMWARE_CUSTOM_REPO_VERSION="v2.0"
 BR2_TARGET_ARM_TRUSTED_FIRMWARE_PLATFORM="rk3399"
+BR2_TARGET_ARM_TRUSTED_FIRMWARE_NEEDS_ARM32_TOOLCHAIN=y
 BR2_TARGET_ARM_TRUSTED_FIRMWARE_BL31=y
 
 # Bootloader