Patchwork [U-Boot,V2,3/6] i.mx: mxc_gpio: add the i.mx6q support

login
register
mail settings
Submitter Jason Liu
Date Nov. 18, 2011, 7:11 a.m.
Message ID <1321600267-8514-4-git-send-email-jason.hui@linaro.org>
Download mbox | patch
Permalink /patch/126353/
State Superseded
Delegated to: Stefano Babic
Headers show

Comments

Jason Liu - Nov. 18, 2011, 7:11 a.m.
Signed-off-by: Jason Liu <jason.hui@linaro.org>
Cc: Stefano Babic <sbabic@denx.de>
Acked-by: Stefano Babic <sbabic@denx.de>
---
V2: add Stefano's ack
---
 drivers/gpio/mxc_gpio.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
Jason Liu - Nov. 18, 2011, 7:30 a.m.
2011/11/18 Lv Terry-R65388 <r65388@freescale.com>:
> Hi Jason,
>
>        What about using
>
> #ifdef GPIO4_BASE_ADDR
>        [3] = GPIO4_BASE_ADDR,
> #endif
[...]

>
>        Then we can avoid adding SOC compile options in future.
>

Terry, please don't top-post. As for your comments, I don't think so,
first, we should not simply use GPIOx_BASE_ADDR, and second,
it will introduce a lot of other platforms changes.

Jason Liu

> _______________________________________________
> U-Boot mailing list
> U-Boot@lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot
>
>
Marek Vasut - Nov. 18, 2011, 10:18 a.m.
> 2011/11/18 Lv Terry-R65388 <r65388@freescale.com>:
> > Hi Jason,
> > 
> >        What about using
> > 
> > #ifdef GPIO4_BASE_ADDR
> >        [3] = GPIO4_BASE_ADDR,
> > #endif
> 
> [...]
> 
> >        Then we can avoid adding SOC compile options in future.
> 
> Terry, please don't top-post. As for your comments, I don't think so,
> first, we should not simply use GPIOx_BASE_ADDR, and second,
> it will introduce a lot of other platforms changes.
> 
> Jason Liu

So it's Jason Liu or Jason Hui ?! What the heck is your name ?

M
Jason Liu - Nov. 18, 2011, 12:26 p.m.
On Fri, Nov 18, 2011 at 6:18 PM, Marek Vasut <marek.vasut@gmail.com> wrote:
>> 2011/11/18 Lv Terry-R65388 <r65388@freescale.com>:
>> > Hi Jason,
>> >
>> >        What about using
>> >
>> > #ifdef GPIO4_BASE_ADDR
>> >        [3] = GPIO4_BASE_ADDR,
>> > #endif
>>
>> [...]
>>
>> >        Then we can avoid adding SOC compile options in future.
>>
>> Terry, please don't top-post. As for your comments, I don't think so,
>> first, we should not simply use GPIOx_BASE_ADDR, and second,
>> it will introduce a lot of other platforms changes.
>>
>> Jason Liu
>
> So it's Jason Liu or Jason Hui ?! What the heck is your name ?

There is some mistake when linaro assign me the email address.
in fact, it should be jason.liu@linaro.org. But anyway, I don't care
about it. Sorry to make you confuse. ;)

Jason
>
> M
>
Mike Frysinger - Nov. 18, 2011, 8 p.m.
On Friday 18 November 2011 02:11:04 Jason Liu wrote:
> -#if defined(CONFIG_MX51) || defined(CONFIG_MX53)
> +#if defined(CONFIG_MX51) || defined(CONFIG_MX53) || defined(CONFIG_MX6Q)
>  	[3] = GPIO4_BASE_ADDR,
>  #endif

#ifdef GPIO4_BASE_ADDR ?
-mike
Mike Frysinger - Nov. 18, 2011, 8:01 p.m.
On Friday 18 November 2011 07:26:59 Jason Hui wrote:
> On Fri, Nov 18, 2011 at 6:18 PM, Marek Vasut <marek.vasut@gmail.com> wrote:
> >> 2011/11/18 Lv Terry-R65388 <r65388@freescale.com>:
> >> > Hi Jason,
> >> > 
> >> >        What about using
> >> > 
> >> > #ifdef GPIO4_BASE_ADDR
> >> >        [3] = GPIO4_BASE_ADDR,
> >> > #endif
> >> 
> >> [...]
> >> 
> >> >        Then we can avoid adding SOC compile options in future.
> >> 
> >> Terry, please don't top-post. As for your comments, I don't think so,
> >> first, we should not simply use GPIOx_BASE_ADDR, and second,
> >> it will introduce a lot of other platforms changes.
> >> 
> >> Jason Liu
> > 
> > So it's Jason Liu or Jason Hui ?! What the heck is your name ?
> 
> There is some mistake when linaro assign me the email address.
> in fact, it should be jason.liu@linaro.org. But anyway, I don't care
> about it. Sorry to make you confuse. ;)

but the "Jason Hui" part is controlled purely on your side :).  only the 
"jason.hui@linaro.org" is controlled by Linaro.
-mike
Marek Vasut - Nov. 18, 2011, 10:59 p.m.
> On Friday 18 November 2011 07:26:59 Jason Hui wrote:
> > On Fri, Nov 18, 2011 at 6:18 PM, Marek Vasut <marek.vasut@gmail.com> wrote:
> > >> 2011/11/18 Lv Terry-R65388 <r65388@freescale.com>:
> > >> > Hi Jason,
> > >> > 
> > >> >        What about using
> > >> > 
> > >> > #ifdef GPIO4_BASE_ADDR
> > >> > 
> > >> >        [3] = GPIO4_BASE_ADDR,
> > >> > 
> > >> > #endif
> > >> 
> > >> [...]
> > >> 
> > >> >        Then we can avoid adding SOC compile options in future.
> > >> 
> > >> Terry, please don't top-post. As for your comments, I don't think so,
> > >> first, we should not simply use GPIOx_BASE_ADDR, and second,
> > >> it will introduce a lot of other platforms changes.
> > >> 
> > >> Jason Liu
> > > 
> > > So it's Jason Liu or Jason Hui ?! What the heck is your name ?
> > 
> > There is some mistake when linaro assign me the email address.
> > in fact, it should be jason.liu@linaro.org. But anyway, I don't care
> > about it. Sorry to make you confuse. ;)
> 
> but the "Jason Hui" part is controlled purely on your side :).  only the
> "jason.hui@linaro.org" is controlled by Linaro.
> -mike

Not really ... you can fake both ;-D
Mike Frysinger - Nov. 18, 2011, 11:50 p.m.
On Friday 18 November 2011 17:59:28 Marek Vasut wrote:
> > On Friday 18 November 2011 07:26:59 Jason Hui wrote:
> > > On Fri, Nov 18, 2011 at 6:18 PM, Marek Vasut wrote:
> > > >> 2011/11/18 Lv Terry-R65388 <r65388@freescale.com>:
> > > >> > Hi Jason,
> > > >> > 
> > > >> >        What about using
> > > >> > 
> > > >> > #ifdef GPIO4_BASE_ADDR
> > > >> > 
> > > >> >        [3] = GPIO4_BASE_ADDR,
> > > >> > 
> > > >> > #endif
> > > >> 
> > > >> [...]
> > > >> 
> > > >> >        Then we can avoid adding SOC compile options in future.
> > > >> 
> > > >> Terry, please don't top-post. As for your comments, I don't think
> > > >> so, first, we should not simply use GPIOx_BASE_ADDR, and second, it
> > > >> will introduce a lot of other platforms changes.
> > > >> 
> > > >> Jason Liu
> > > > 
> > > > So it's Jason Liu or Jason Hui ?! What the heck is your name ?
> > > 
> > > There is some mistake when linaro assign me the email address.
> > > in fact, it should be jason.liu@linaro.org. But anyway, I don't care
> > > about it. Sorry to make you confuse. ;)
> > 
> > but the "Jason Hui" part is controlled purely on your side :).  only the
> > "jason.hui@linaro.org" is controlled by Linaro.
> 
> Not really ... you can fake both ;-D

you can fake the From.  you can't fake the To.
-mike

Patch

diff --git a/drivers/gpio/mxc_gpio.c b/drivers/gpio/mxc_gpio.c
index a7f36b2..908808d 100644
--- a/drivers/gpio/mxc_gpio.c
+++ b/drivers/gpio/mxc_gpio.c
@@ -40,10 +40,10 @@  static unsigned long gpio_ports[] = {
 	[0] = GPIO1_BASE_ADDR,
 	[1] = GPIO2_BASE_ADDR,
 	[2] = GPIO3_BASE_ADDR,
-#if defined(CONFIG_MX51) || defined(CONFIG_MX53)
+#if defined(CONFIG_MX51) || defined(CONFIG_MX53) || defined(CONFIG_MX6Q)
 	[3] = GPIO4_BASE_ADDR,
 #endif
-#if defined(CONFIG_MX53)
+#if defined(CONFIG_MX53) || defined(CONFIG_MX6Q)
 	[4] = GPIO5_BASE_ADDR,
 	[5] = GPIO6_BASE_ADDR,
 	[6] = GPIO7_BASE_ADDR,