Patchwork [Lucid] Revert "ALSA: hda: Fix quirk for Dell Inspiron 910"

login
register
mail settings
Submitter Herton Ronaldo Krzesinski
Date Nov. 18, 2011, 3:05 a.m.
Message ID <1321585558-683-2-git-send-email-herton.krzesinski@canonical.com>
Download mbox | patch
Permalink /patch/126342/
State New
Headers show

Comments

Herton Ronaldo Krzesinski - Nov. 18, 2011, 3:05 a.m.
From: Herton Ronaldo Krzesinski <herton.krzesinski@canonical.com>

This reverts commit afcbc7ee8b6b20c0480245b829787f12964d669f.

It was wrong included in 2.6.32 stable (was intended for 2.6.38+ in the
original commit changelog), and causes a regression (bug 875300).

BugLink: https://launchpad.net/bugs/875300
Signed-off-by: Herton Ronaldo Krzesinski <herton.krzesinski@canonical.com>
---
 sound/pci/hda/patch_realtek.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
Tim Gardner - Nov. 18, 2011, 12:06 p.m.
Have you sent a note to stable@vger.kernel.org about this ?
Herton Ronaldo Krzesinski - Nov. 18, 2011, 1 p.m.
On Fri, Nov 18, 2011 at 07:06:43AM -0500, Tim Gardner wrote:
> Have you sent a note to stable@vger.kernel.org about this ?

It's now sent to stable@vger.kernel.org as well.
Andy Whitcroft - Nov. 21, 2011, 12:37 p.m.
On Fri, Nov 18, 2011 at 01:05:58AM -0200, Herton R. Krzesinski wrote:
> From: Herton Ronaldo Krzesinski <herton.krzesinski@canonical.com>
> 
> This reverts commit afcbc7ee8b6b20c0480245b829787f12964d669f.
> 
> It was wrong included in 2.6.32 stable (was intended for 2.6.38+ in the
> original commit changelog), and causes a regression (bug 875300).
> 
> BugLink: https://launchpad.net/bugs/875300
> Signed-off-by: Herton Ronaldo Krzesinski <herton.krzesinski@canonical.com>
> ---
>  sound/pci/hda/patch_realtek.c |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
> 
> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> index 083b777..ed550e4 100644
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -12662,7 +12662,6 @@ static struct snd_pci_quirk alc268_cfg_tbl[] = {
>  	SND_PCI_QUIRK(0x1025, 0x015b, "Acer Aspire One",
>  						ALC268_ACER_ASPIRE_ONE),
>  	SND_PCI_QUIRK(0x1028, 0x0253, "Dell OEM", ALC268_DELL),
> -	SND_PCI_QUIRK(0x1028, 0x02b0, "Dell Inspiron 910", ALC268_AUTO),
>  	SND_PCI_QUIRK_MASK(0x1028, 0xfff0, 0x02b0,
>  			"Dell Inspiron Mini9/Vostro A90", ALC268_DELL),
>  	/* almost compatible with toshiba but with optional digital outs;
> -- 

Given the investigation that has gone into this it sounds a lot like a
testing error in the original case.

Acked-by: Andy Whitcroft <apw@canonical.com>

-apw

Patch

diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index 083b777..ed550e4 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -12662,7 +12662,6 @@  static struct snd_pci_quirk alc268_cfg_tbl[] = {
 	SND_PCI_QUIRK(0x1025, 0x015b, "Acer Aspire One",
 						ALC268_ACER_ASPIRE_ONE),
 	SND_PCI_QUIRK(0x1028, 0x0253, "Dell OEM", ALC268_DELL),
-	SND_PCI_QUIRK(0x1028, 0x02b0, "Dell Inspiron 910", ALC268_AUTO),
 	SND_PCI_QUIRK_MASK(0x1028, 0xfff0, 0x02b0,
 			"Dell Inspiron Mini9/Vostro A90", ALC268_DELL),
 	/* almost compatible with toshiba but with optional digital outs;