Patchwork Fix wrong parameter given to sizeof call

login
register
mail settings
Submitter Thomas Jarosch
Date Nov. 17, 2011, 8:33 p.m.
Message ID <4EC56FB0.3040900@intra2net.com>
Download mbox | patch
Permalink /patch/126307/
State Accepted
Delegated to: David Miller
Headers show

Comments

Thomas Jarosch - Nov. 17, 2011, 8:33 p.m.
"remote_list" is of type

struct dma_chunk remote_list[VETH_MAX_FRAMES_PER_MSG];

Probably a copy'n'paste error.

Signed-off-by: Thomas Jarosch <thomas.jarosch@intra2net.com>
---
 drivers/net/ethernet/ibm/iseries_veth.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
David Miller - Nov. 21, 2011, 7:56 p.m.
From: Thomas Jarosch <thomas.jarosch@intra2net.com>
Date: Thu, 17 Nov 2011 21:33:52 +0100

> "remote_list" is of type
> 
> struct dma_chunk remote_list[VETH_MAX_FRAMES_PER_MSG];
> 
> Probably a copy'n'paste error.
> 
> Signed-off-by: Thomas Jarosch <thomas.jarosch@intra2net.com>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/drivers/net/ethernet/ibm/iseries_veth.c b/drivers/net/ethernet/ibm/iseries_veth.c
index 4326681..acc31af 100644
--- a/drivers/net/ethernet/ibm/iseries_veth.c
+++ b/drivers/net/ethernet/ibm/iseries_veth.c
@@ -1421,7 +1421,7 @@  static void veth_receive(struct veth_lpar_connection *cnx,
 
 		/* FIXME: do we need this? */
 		memset(local_list, 0, sizeof(local_list));
-		memset(remote_list, 0, sizeof(VETH_MAX_FRAMES_PER_MSG));
+		memset(remote_list, 0, sizeof(remote_list));
 
 		/* a 0 address marks the end of the valid entries */
 		if (senddata->addr[startchunk] == 0)