| Message ID | 20200326203820.59678-1-fontaine.fabrice@gmail.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [1/1] package/sdbusplus: needs C++17 | expand |
> From: Fabrice Fontaine <fontaine.fabrice@gmail.com> > Sent: Thursday, March 26, 2020 1:38 PM > To: buildroot@buildroot.org <buildroot@buildroot.org> > Cc: John Faith <jfaith@impinj.com>; Fabrice Fontaine <fontaine.fabrice@gmail.com> > Subject: [PATCH 1/1] package/sdbusplus: needs C++17 > > sdbusplus needs C++17 since > https://github.com/openbmc/sdbusplus/commit/ca46b9d2e958d1e4b392265f656f782899c2de1d > > This is not needed for host-sdbusplus as libsdbusplus is disabled on > host through --disable-libsdbusplus > > Fixes: > - > http://autobuild.buildroot.org/results/65a4652e5b419f03ace109c4b3738e9b997cdabe > > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com> Reviewed-by: John Faith <jfaith@impinj.com> Thanks for fixing this! , John > --- > package/sdbusplus/Config.in | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/package/sdbusplus/Config.in b/package/sdbusplus/Config.in > index e278d17156..c66203c463 100644 > --- a/package/sdbusplus/Config.in > +++ b/package/sdbusplus/Config.in > @@ -2,6 +2,7 @@ config BR2_PACKAGE_SDBUSPLUS > bool "sdbusplus" > depends on BR2_INSTALL_LIBSTDCPP > depends on BR2_PACKAGE_SYSTEMD > + depends on BR2_TOOLCHAIN_GCC_AT_LEAST_7 # C++17 > help > A C++ library for sd-bus with a bindings and doc generator. > > @@ -10,5 +11,6 @@ config BR2_PACKAGE_SDBUSPLUS > > https://github.com/openbmc/sdbusplus > > -comment "sdbusplus needs systemd and a toolchain w/ C++" > - depends on !BR2_PACKAGE_SYSTEMD || !BR2_INSTALL_LIBSTDCPP > +comment "sdbusplus needs systemd and a toolchain w/ C++, gcc >= 7" > + depends on !BR2_PACKAGE_SYSTEMD || !BR2_INSTALL_LIBSTDCPP || \ > + !BR2_TOOLCHAIN_GCC_AT_LEAST_7 > -- > 2.25.1
On Thu, 26 Mar 2020 21:38:20 +0100 Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote: > sdbusplus needs C++17 since > https://github.com/openbmc/sdbusplus/commit/ca46b9d2e958d1e4b392265f656f782899c2de1d > > This is not needed for host-sdbusplus as libsdbusplus is disabled on > host through --disable-libsdbusplus > > Fixes: > - http://autobuild.buildroot.org/results/65a4652e5b419f03ace109c4b3738e9b997cdabe > > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com> > --- > package/sdbusplus/Config.in | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) Applied to master, thanks. Thomas
>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes: > sdbusplus needs C++17 since > https://github.com/openbmc/sdbusplus/commit/ca46b9d2e958d1e4b392265f656f782899c2de1d > This is not needed for host-sdbusplus as libsdbusplus is disabled on > host through --disable-libsdbusplus > Fixes: > - http://autobuild.buildroot.org/results/65a4652e5b419f03ace109c4b3738e9b997cdabe > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com> Committed to 2020.02.x, thanks.
diff --git a/package/sdbusplus/Config.in b/package/sdbusplus/Config.in index e278d17156..c66203c463 100644 --- a/package/sdbusplus/Config.in +++ b/package/sdbusplus/Config.in @@ -2,6 +2,7 @@ config BR2_PACKAGE_SDBUSPLUS bool "sdbusplus" depends on BR2_INSTALL_LIBSTDCPP depends on BR2_PACKAGE_SYSTEMD + depends on BR2_TOOLCHAIN_GCC_AT_LEAST_7 # C++17 help A C++ library for sd-bus with a bindings and doc generator. @@ -10,5 +11,6 @@ config BR2_PACKAGE_SDBUSPLUS https://github.com/openbmc/sdbusplus -comment "sdbusplus needs systemd and a toolchain w/ C++" - depends on !BR2_PACKAGE_SYSTEMD || !BR2_INSTALL_LIBSTDCPP +comment "sdbusplus needs systemd and a toolchain w/ C++, gcc >= 7" + depends on !BR2_PACKAGE_SYSTEMD || !BR2_INSTALL_LIBSTDCPP || \ + !BR2_TOOLCHAIN_GCC_AT_LEAST_7
sdbusplus needs C++17 since https://github.com/openbmc/sdbusplus/commit/ca46b9d2e958d1e4b392265f656f782899c2de1d This is not needed for host-sdbusplus as libsdbusplus is disabled on host through --disable-libsdbusplus Fixes: - http://autobuild.buildroot.org/results/65a4652e5b419f03ace109c4b3738e9b997cdabe Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com> --- package/sdbusplus/Config.in | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)