[linux-next] ata: sata_fsl: fix a compile error
diff mbox series

Message ID 20200325235921.22431-1-leoyang.li@nxp.com
State Not Applicable
Delegated to: David Miller
Headers show
Series
  • [linux-next] ata: sata_fsl: fix a compile error
Related show

Commit Message

Li Yang March 25, 2020, 11:59 p.m. UTC
drivers/ata/sata_fsl.c: In function 'sata_fsl_init_controller':
drivers/ata/sata_fsl.c:1365:15: error: 'ap' undeclared (first use in this function)
  ata_port_dbg(ap, "icc = 0x%x\n", ioread32(hcr_base + ICC));
               ^

Fixes: b3f06231 ("sata_fsl: move DPRINTK to ata debugging")

Cc: Hannes Reinecke <hare@suse.de>
Signed-off-by: Li Yang <leoyang.li@nxp.com>
---
 drivers/ata/sata_fsl.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Sergei Shtylyov March 26, 2020, 9:06 a.m. UTC | #1
Hello!

On 26.03.2020 2:59, Li Yang wrote:

> drivers/ata/sata_fsl.c: In function 'sata_fsl_init_controller':
> drivers/ata/sata_fsl.c:1365:15: error: 'ap' undeclared (first use in this function)
>    ata_port_dbg(ap, "icc = 0x%x\n", ioread32(hcr_base + ICC));
 >                 ^

    Another fix has been posted yesterday.

> Fixes: b3f06231 ("sata_fsl: move DPRINTK to ata debugging")

    12 digits SHA1 is needed here.

> Cc: Hannes Reinecke <hare@suse.de>
> Signed-off-by: Li Yang <leoyang.li@nxp.com>
[...]

MBR, Sergei
Jens Axboe March 26, 2020, 3:17 p.m. UTC | #2
On 3/26/20 3:06 AM, Sergei Shtylyov wrote:
> Hello!
> 
> On 26.03.2020 2:59, Li Yang wrote:
> 
>> drivers/ata/sata_fsl.c: In function 'sata_fsl_init_controller':
>> drivers/ata/sata_fsl.c:1365:15: error: 'ap' undeclared (first use in this function)
>>    ata_port_dbg(ap, "icc = 0x%x\n", ioread32(hcr_base + ICC));
>  >                 ^
> 
>     Another fix has been posted yesterday.

I also dropped the series yesterday, so we don't need any of these
patches anymore.

Patch
diff mbox series

diff --git a/drivers/ata/sata_fsl.c b/drivers/ata/sata_fsl.c
index 45c15c4e9f8a..c43a97d63e6c 100644
--- a/drivers/ata/sata_fsl.c
+++ b/drivers/ata/sata_fsl.c
@@ -1340,6 +1340,7 @@  static int sata_fsl_init_controller(struct ata_host *host)
 {
 	struct sata_fsl_host_priv *host_priv = host->private_data;
 	void __iomem *hcr_base = host_priv->hcr_base;
+	struct ata_port *ap = host->ports[0];
 	u32 temp;
 
 	/*