diff mbox series

[V4,02/13] net: smc911x: Replace malloc()+memset() with calloc()

Message ID 20200325164653.112079-3-marek.vasut+renesas@gmail.com
State Accepted
Commit 882d5f6983ff23b6f09899bb43d6dfd90ed7492f
Delegated to: Joe Hershberger
Headers show
Series net: smc911x: Convert to DM | expand

Commit Message

Marek Vasut March 25, 2020, 4:46 p.m. UTC 
Replace combination of malloc()+memset() with calloc() as the behavior
is exactly the same and the amount of code is reduced.

Signed-off-by: Marek Vasut <marek.vasut+renesas@gmail.com>
Cc: Joe Hershberger <joe.hershberger@ni.com>
Cc: Masahiro Yamada <yamada.masahiro@socionext.com>
---
V2: - Use kzalloc()
    - Return -ENOMEM on alloc fail
V3: - Switch back to calloc(), it's not worth pulling in all the
      linux-compatibility complexity
V4: No change
---
 drivers/net/smc911x.c | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)
diff mbox series

Patch

diff --git a/drivers/net/smc911x.c b/drivers/net/smc911x.c
index 24b4eaeb3f..2c72e3469d 100644
--- a/drivers/net/smc911x.c
+++ b/drivers/net/smc911x.c
@@ -242,11 +242,9 @@  int smc911x_initialize(u8 dev_num, int base_addr)
 	unsigned long addrl, addrh;
 	struct eth_device *dev;
 
-	dev = malloc(sizeof(*dev));
-	if (!dev) {
-		return -1;
-	}
-	memset(dev, 0, sizeof(*dev));
+	dev = calloc(1, sizeof(*dev));
+	if (!dev)
+		return -ENOMEM;
 
 	dev->iobase = base_addr;