From patchwork Wed Mar 25 09:45:59 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas De Schampheleire X-Patchwork-Id: 1261272 Return-Path: X-Original-To: incoming-buildroot@patchwork.ozlabs.org Delivered-To: patchwork-incoming-buildroot@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=busybox.net (client-ip=140.211.166.133; helo=hemlock.osuosl.org; envelope-from=buildroot-bounces@busybox.net; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=s//anhZ3; dkim-atps=neutral Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 48nNX36CPMz9sQt for ; Wed, 25 Mar 2020 20:45:23 +1100 (AEDT) Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id C0B6B88728; Wed, 25 Mar 2020 09:45:20 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id we2skSaaqvGi; Wed, 25 Mar 2020 09:45:20 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by hemlock.osuosl.org (Postfix) with ESMTP id D438E88761; Wed, 25 Mar 2020 09:45:19 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by ash.osuosl.org (Postfix) with ESMTP id A641A1BF37C for ; Wed, 25 Mar 2020 09:45:18 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id 9CC27227F7 for ; Wed, 25 Mar 2020 09:45:18 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 04ElADSc1NsX for ; Wed, 25 Mar 2020 09:45:16 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-ot1-f66.google.com (mail-ot1-f66.google.com [209.85.210.66]) by silver.osuosl.org (Postfix) with ESMTPS id C480520770 for ; Wed, 25 Mar 2020 09:45:16 +0000 (UTC) Received: by mail-ot1-f66.google.com with SMTP id z5so1022586oth.9 for ; Wed, 25 Mar 2020 02:45:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=wM3R9SGNj8fECaxWGasu4qA2mmW3oa5F8YThwA5RgS0=; b=s//anhZ3Bw13Minq/pjmY0WI7ZDyDK4HJITo8cHAgYktbfc2qXIjz5kdlllpAvVPxJ CPpULs+dkBWEIz7h5DsBc2SjuzS6WC+mE154ZPb2VgRDE1N2e5bq2yUQ4RNaaBgi6hg0 G4jYq9duQ7KkFj2WVpx7B36NXuQ38MucQSRk6tfLFtJjZqihkdsqemFJ+4GuHBdVF89o 8164oXqtQIS5sFV/XXkxw8MPjKGBsXSUHU1ifbvz3khTJBdvvOk31o+rYOVOC0+nsfxS OAwA1sk5P11AYxsYdZ/4PcHcT0kuVeqR985RBNLW5BfWj8ojYl3cqDO97yD8syh2R1f5 Ynug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=wM3R9SGNj8fECaxWGasu4qA2mmW3oa5F8YThwA5RgS0=; b=fVQu3M7zngN4+Ac+aGXdxvFB8RHS9YAvrkYxGFe/qAcO1TSzPXFDep6dhP0v2PD3L2 4Ei0dMuceaBXc7o2z+vCujJTkoWM5cradHGV1ACLqL/FaQkp04iCGPcoL/glVfFNJGzh 0Nhaz4NUUtPKApNhKhLZcRj4rIGKG3c+Twm/8S+zLBuWQY/qTJBIrLRcWR3yCY44xfkS pUbMupVnGcq6W5XNQ9JUCvYxw2x32kplqZAsHLl8tt7CvDU1IhRpcxpYbkz/O43Insj4 tsYQ4HNS0aD4DV3b99FqrjxqkTM06lp9hW44Nb/AfQd1Yrhe9U2OnUg0xJQBozhS+PZL AUGA== X-Gm-Message-State: ANhLgQ1X1chFpEksiEo1QAOGZd5sB6mEuOYn5wtmRezLAflSYIr5nfNV eOmI6C9gg6CB3bBasS3mvu9fbiYH2SE= X-Google-Smtp-Source: ADFU+vuguw6+fXjMyVZVUriYWobSBB9B/8/1HHrLahfVtVueMerEki4JcJlBkDeG8MfXW5Dpqqz+9w== X-Received: by 2002:a05:6830:239b:: with SMTP id l27mr1893227ots.278.1585129515594; Wed, 25 Mar 2020 02:45:15 -0700 (PDT) Received: from localhost ([131.228.32.166]) by smtp.gmail.com with ESMTPSA id b11sm6829048otj.64.2020.03.25.02.45.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Mar 2020 02:45:15 -0700 (PDT) From: Thomas De Schampheleire To: buildroot@buildroot.org Date: Wed, 25 Mar 2020 10:45:59 +0100 Message-Id: <20200325094559.5046-1-patrickdepinguin@gmail.com> X-Mailer: git-send-email 2.24.1 MIME-Version: 1.0 Subject: [Buildroot] [PATCH] Revert "package/perl-crypt-ssleay: new package" X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Yann E. MORIN" , Thomas De Schampheleire Errors-To: buildroot-bounces@busybox.net Sender: "buildroot" From: Thomas De Schampheleire This reverts commit 25033cfb8612c6d0f45c89806f7e0669ffbf0e8a. This perl package is deprecated and gives following recommendations while building: *** THIS IS NOT AN ERROR, JUST A MESSAGE FOR YOUR INFORMATION *** Do you really need Crypt::SSLeay? Starting with version 6.02 of LWP, https support was unbundled into LWP::Protocol::https. This module specifies as one of its prerequisites IO::Socket::SSL which is automatically used by LWP::UserAgent unless this preference is overridden separately. IO::Socket::SSL is a more complete implementation, and, crucially, it allows hostname verification. Crypt::SSLeay does not support this. At this point, Crypt::SSLeay is maintained to support existing software that already depends on it. However, it is possible that your software does not really depend on Crypt::SSLeay, only on the ability of LWP::UserAgent class to communicate with sites over SSL/TLS. If are using version LWP 6.02 or later, and therefore have installed LWP::Protocol::https and its dependencies, and do not explicitly use Net::SSL before loading LWP::UserAgent, or override the default socket class, you are probably using IO::Socket::SSL and do not really need Crypt::SSLeay. Before installing Crypt::SSLeay, you may want to try specifying a dependency on LWP::Protocol::https. Signed-off-by: Thomas De Schampheleire --- DEVELOPERS | 2 - package/Config.in | 1 - package/perl-crypt-ssleay/Config.in | 12 ------ .../perl-crypt-ssleay/perl-crypt-ssleay.hash | 6 --- .../perl-crypt-ssleay/perl-crypt-ssleay.mk | 18 -------- package/perl-try-tiny/perl-try-tiny.mk | 1 - .../tests/package/test_perl_crypt_ssleay.py | 43 ------------------- 7 files changed, 83 deletions(-) delete mode 100644 package/perl-crypt-ssleay/Config.in delete mode 100644 package/perl-crypt-ssleay/perl-crypt-ssleay.hash delete mode 100644 package/perl-crypt-ssleay/perl-crypt-ssleay.mk delete mode 100644 support/testing/tests/package/test_perl_crypt_ssleay.py diff --git a/DEVELOPERS b/DEVELOPERS index 1fb4e65755..4a43ca420d 100644 --- a/DEVELOPERS +++ b/DEVELOPERS @@ -2425,7 +2425,6 @@ F: package/perl-convert-asn1/ F: package/perl-crypt-blowfish/ F: package/perl-crypt-cbc/ F: package/perl-crypt-openssl-aes/ -F: package/perl-crypt-ssleay/ F: package/perl-i18n/ F: package/perl-locale-maketext-lexicon/ F: package/perl-lwp-protocol-https/ @@ -2444,7 +2443,6 @@ F: package/perl-path-class/ F: package/pigz/ F: package/xenomai/ F: support/scripts/size-stats -F: support/testing/tests/package/test_perl_crypt_ssleay.py F: support/testing/tests/package/test_perl_lwp_protocol_https.py F: utils/size-stats-compare F: toolchain/ diff --git a/package/Config.in b/package/Config.in index 614ec921e5..7b73198d50 100644 --- a/package/Config.in +++ b/package/Config.in @@ -726,7 +726,6 @@ menu "Perl libraries/modules" source "package/perl-crypt-openssl-aes/Config.in" source "package/perl-crypt-openssl-random/Config.in" source "package/perl-crypt-openssl-rsa/Config.in" - source "package/perl-crypt-ssleay/Config.in" source "package/perl-data-dump/Config.in" source "package/perl-data-optlist/Config.in" source "package/perl-data-uuid/Config.in" diff --git a/package/perl-crypt-ssleay/Config.in b/package/perl-crypt-ssleay/Config.in deleted file mode 100644 index 92ea354b46..0000000000 --- a/package/perl-crypt-ssleay/Config.in +++ /dev/null @@ -1,12 +0,0 @@ -config BR2_PACKAGE_PERL_CRYPT_SSLEAY - bool "perl-crypt-ssleay" - depends on !BR2_STATIC_LIBS - select BR2_PACKAGE_OPENSSL - select BR2_PACKAGE_PERL_LWP_PROTOCOL_HTTPS # runtime - help - OpenSSL support for LWP. - - https://metacpan.org/release/Crypt-SSLeay - -comment "perl-crypt-ssleay needs a toolchain w/ dynamic library" - depends on BR2_STATIC_LIBS diff --git a/package/perl-crypt-ssleay/perl-crypt-ssleay.hash b/package/perl-crypt-ssleay/perl-crypt-ssleay.hash deleted file mode 100644 index c5427bfec9..0000000000 --- a/package/perl-crypt-ssleay/perl-crypt-ssleay.hash +++ /dev/null @@ -1,6 +0,0 @@ -# retrieved by scancpan from http://cpan.metacpan.org/ -md5 77d955c9056dbb12413d95d8852a9cdf Crypt-SSLeay-0.72.tar.gz -sha256 f5d34f813677829857cf8a0458623db45b4d9c2311daaebe446f9e01afa9ffe8 Crypt-SSLeay-0.72.tar.gz - -# computed by scancpan -sha256 5c21a4393be5a9d307fd1dd2274e5d261a3213272277c2b72e7321db51e4bad7 README.md diff --git a/package/perl-crypt-ssleay/perl-crypt-ssleay.mk b/package/perl-crypt-ssleay/perl-crypt-ssleay.mk deleted file mode 100644 index 9564ee2b38..0000000000 --- a/package/perl-crypt-ssleay/perl-crypt-ssleay.mk +++ /dev/null @@ -1,18 +0,0 @@ -################################################################################ -# -# perl-crypt-ssleay -# -################################################################################ - -PERL_CRYPT_SSLEAY_VERSION = 0.72 -PERL_CRYPT_SSLEAY_SOURCE = Crypt-SSLeay-$(PERL_CRYPT_SSLEAY_VERSION).tar.gz -PERL_CRYPT_SSLEAY_SITE = $(BR2_CPAN_MIRROR)/authors/id/N/NA/NANIS -PERL_CRYPT_SSLEAY_DEPENDENCIES = \ - openssl \ - host-perl-path-class \ - host-perl-try-tiny -PERL_CRYPT_SSLEAY_LICENSE = Artistic-2.0 -PERL_CRYPT_SSLEAY_LICENSE_FILES = README.md -PERL_CRYPT_SSLEAY_DISTNAME = Crypt-SSLeay - -$(eval $(perl-package)) diff --git a/package/perl-try-tiny/perl-try-tiny.mk b/package/perl-try-tiny/perl-try-tiny.mk index 62fb1bbace..f13e2ee59f 100644 --- a/package/perl-try-tiny/perl-try-tiny.mk +++ b/package/perl-try-tiny/perl-try-tiny.mk @@ -12,4 +12,3 @@ PERL_TRY_TINY_LICENSE_FILES = LICENCE PERL_TRY_TINY_DISTNAME = Try-Tiny $(eval $(perl-package)) -$(eval $(host-perl-package)) diff --git a/support/testing/tests/package/test_perl_crypt_ssleay.py b/support/testing/tests/package/test_perl_crypt_ssleay.py deleted file mode 100644 index e6093b3938..0000000000 --- a/support/testing/tests/package/test_perl_crypt_ssleay.py +++ /dev/null @@ -1,43 +0,0 @@ -from tests.package.test_perl import TestPerlBase - - -class TestPerlCryptSSLeay(TestPerlBase): - """ - package: - Crypt-SSLeay XS - direct dependencies: - LWP-Protocol-https - indirect dependencies: - Encode-Locale - File-Listing - HTML-Parser XS - HTML-Tagset - HTTP-Cookies - HTTP-Daemon - HTTP-Date - HTTP-Message - HTTP-Negotiate - IO-HTML - IO-Socket-SSL - LWP-MediaTypes - Mozilla-CA - Net-HTTP - Net-SSLeay XS - TimeDate - Try-Tiny - URI - WWW-RobotRules - libwww-perl - """ - - config = TestPerlBase.config + \ - """ - BR2_PACKAGE_PERL=y - BR2_PACKAGE_PERL_CRYPT_SSLEAY=y - """ - - def test_run(self): - self.login() - self.module_test("HTML::Parser") - self.module_test("Net::SSLeay") - self.module_test("Crypt::SSLeay")