From patchwork Thu Nov 17 02:03:20 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yongqiang Yang X-Patchwork-Id: 126107 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id E23A1B71C4 for ; Thu, 17 Nov 2011 15:31:56 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754875Ab1KQEbv (ORCPT ); Wed, 16 Nov 2011 23:31:51 -0500 Received: from mail-iy0-f174.google.com ([209.85.210.174]:38853 "EHLO mail-iy0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754843Ab1KQEbu (ORCPT ); Wed, 16 Nov 2011 23:31:50 -0500 Received: by iage36 with SMTP id e36so1594550iag.19 for ; Wed, 16 Nov 2011 20:31:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=from:to:cc:subject:date:message-id:x-mailer; bh=QF6ntb2eJ+kc9u8qXd1Dgcg48OWJ0LnED50XQ5ZDbyE=; b=uTgrOIHTmxQhphzS9wfCzbMybm7I78MOpgE0gkH3srkc8F2yn+exfnBSVNC3NvzhQP CFSGXI5qsr8sAUWnYKn7r58jOLtyIHY2yPS3tRbxstNU2oQwDqK8ToYDarlVT+fyIPSo k+sUtfAKiwKv6hCrP8iBXyzP95KgCRMBsfTYs= Received: by 10.42.153.6 with SMTP id k6mr37884861icw.30.1321504309940; Wed, 16 Nov 2011 20:31:49 -0800 (PST) Received: from localhost.localdomain ([159.226.43.42]) by mx.google.com with ESMTPS id l28sm11691965ibc.3.2011.11.16.20.31.47 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 16 Nov 2011 20:31:48 -0800 (PST) From: Yongqiang Yang To: tytso@mit.edu Cc: linux-ext4@vger.kernel.org, Yongqiang Yang Subject: [PATCH 1/6] ext4: remove unnecessary var in ext4_ext_insert_extent Date: Thu, 17 Nov 2011 10:03:20 +0800 Message-Id: <1321495405-9583-1-git-send-email-xiaoqiangnk@gmail.com> X-Mailer: git-send-email 1.7.5.1 Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org Var(uninitialized) is not necessary. As the comment says, two extent are either initialized or uninitialized. So checking newext is ok. Signed-off-by: Yongqiang Yang --- fs/ext4/extents.c | 5 +---- 1 files changed, 1 insertions(+), 4 deletions(-) diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c index 61fa9e1..6b4a558 100644 --- a/fs/ext4/extents.c +++ b/fs/ext4/extents.c @@ -1665,7 +1665,6 @@ int ext4_ext_insert_extent(handle_t *handle, struct inode *inode, struct ext4_ext_path *npath = NULL; int depth, len, err; ext4_lblk_t next; - unsigned uninitialized = 0; int flags = 0; if (unlikely(ext4_ext_get_actual_len(newext) == 0)) { @@ -1698,11 +1697,9 @@ int ext4_ext_insert_extent(handle_t *handle, struct inode *inode, * both extents are uninitialized, or both aren't. Thus we * need to check only one of them here. */ - if (ext4_ext_is_uninitialized(ex)) - uninitialized = 1; ex->ee_len = cpu_to_le16(ext4_ext_get_actual_len(ex) + ext4_ext_get_actual_len(newext)); - if (uninitialized) + if (ext4_ext_is_uninitialized(newext)) ext4_ext_mark_uninitialized(ex); eh = path[depth].p_hdr; nearex = ex;