Patchwork [net-next,v6,3/9] kbuild: document RPS/XPS network Kconfig options

login
register
mail settings
Submitter david decotigny
Date Nov. 17, 2011, 2:39 a.m.
Message ID <e0bb736123d687a921f15e4bb0254eeeabe22dcb.1321496595.git.david.decotigny@google.com>
Download mbox | patch
Permalink /patch/126105/
State Rejected
Delegated to: David Miller
Headers show

Comments

david decotigny - Nov. 17, 2011, 2:39 a.m.
This adds a description of RPS/XPS options and allow them to be
changed at make menuconfig time.

It also fixes following checkpatch syntax warnings:
ERROR: trailing whitespace
+^I  $

ERROR: trailing whitespace
+^I$



Signed-off-by: David Decotigny <david.decotigny@google.com>
---
 net/Kconfig |   21 ++++++++++++++++-----
 1 files changed, 16 insertions(+), 5 deletions(-)
David Miller - Nov. 17, 2011, 2:58 a.m.
From: David Decotigny <david.decotigny@google.com>
Date: Wed, 16 Nov 2011 18:39:05 -0800

> This adds a description of RPS/XPS options and allow them to be
> changed at make menuconfig time.

These aren't meant to be selectable.

They are expressing internal dependencies so we don't have to crap
up the code with the complicated dependency conditional test.

They are meant to be turned on, unconditionally, when the dependencies
are met.  They are not meant to be controllable by the user.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
david decotigny - Nov. 17, 2011, 3:04 a.m.
On Wed, Nov 16, 2011 at 6:58 PM, David Miller <davem@davemloft.net> wrote:
> From: David Decotigny <david.decotigny@google.com>
> Date: Wed, 16 Nov 2011 18:39:05 -0800
>
>> This adds a description of RPS/XPS options and allow them to be
>> changed at make menuconfig time.
>
> These aren't meant to be selectable.

Ok. I only needed this for our compilation scripts in order to make
sure I didn't have my CONFIG_* wrong in patch 4/9. I don't need this
patch anymore.

David, should I re-send an updated v7 version of this series with this
patch removed? Or is it Ok if I simply mark this patch as rejected in
patchwork and stick to patch series v6?
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
David Miller - Nov. 17, 2011, 3:12 a.m.
From: David Decotigny <david.decotigny@google.com>
Date: Wed, 16 Nov 2011 19:04:58 -0800

> David, should I re-send an updated v7 version of this series with this
> patch removed? Or is it Ok if I simply mark this patch as rejected in
> patchwork and stick to patch series v6?

I'll try to apply v6 as-is sans patch #3.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/net/Kconfig b/net/Kconfig
index a073148..991379e 100644
--- a/net/Kconfig
+++ b/net/Kconfig
@@ -10,7 +10,7 @@  menuconfig NET
 	  The reason is that some programs need kernel networking support even
 	  when running on a stand-alone machine that isn't connected to any
 	  other computer.
-	  
+
 	  If you are upgrading from an older kernel, you
 	  should consider updating your networking tools too because changes
 	  in the kernel and the tools often go hand in hand. The tools are
@@ -217,20 +217,32 @@  source "net/dns_resolver/Kconfig"
 source "net/batman-adv/Kconfig"
 
 config RPS
-	boolean
+	boolean "Enable Receive Packet Steering"
 	depends on SMP && SYSFS && USE_GENERIC_SMP_HELPERS
 	default y
+	help
+	  RPS distributes the load of received packet processing
+	  across multiple CPUs. If unsure, say Y.
 
 config RFS_ACCEL
-	boolean
+	boolean "Enable Hardware Acceleration of RFS"
 	depends on RPS && GENERIC_HARDIRQS
 	select CPU_RMAP
 	default y
+	help
+	  Allow drivers for multiqueue hardware with flow filter
+	  tables to accelerate RFS. If unsure, say Y.
 
 config XPS
-	boolean
+	boolean "Enable Transmit Packet Steering"
 	depends on SMP && SYSFS && USE_GENERIC_SMP_HELPERS
 	default y
+	help
+	  For multiqueue devices, XPS selects a transmit queue during
+	  packet transmission based on configuration. This is done by
+	  mapping the CPU transmitting the packet to a queue. XPS can
+	  reduce transmit network latency on SMP systems. If unsure,
+	  say Y.
 
 config HAVE_BPF_JIT
 	bool
@@ -274,7 +286,6 @@  config NET_TCPPROBE
 
 	Documentation on how to use TCP connection probing can be found
 	at:
-	
 	  http://www.linuxfoundation.org/collaborate/workgroups/networking/tcpprobe
 
 	To compile this code as a module, choose M here: the