Patchwork [FIX,net,v1] net-e1000e: Fix default interrupt throttle rate not set in NIC HW

login
register
mail settings
Submitter david decotigny
Date Nov. 17, 2011, 1:18 a.m.
Message ID <7182ad277085740c360a17865326058779b101de.1321492611.git.david.decotigny@google.com>
Download mbox | patch
Permalink /patch/126101/
State Superseded
Delegated to: David Miller
Headers show

Comments

david decotigny - Nov. 17, 2011, 1:18 a.m.
From: Ying Cai <ycai@google.com>

This change ensures that the itr/itr_setting adjustment logic is used,
even for the default/compiled-in value.

Context:
  When we changed the default InterruptThrottleRate value from default
  (3 = dynamic mode) to 8000 for example, only adapter->itr_setting
  (which controls interrupt coalescing mode) was set to 8000, but
  adapter->itr (which controls the value set in NIC register) was not
  updated accordingly. So from ethtool, it seemed the interrupt
  throttling is enabled at 8000 intr/s, but the NIC actually was
  running in dynamic mode which has lower CPU efficiency especially
  when throughput is not high.



Signed-off-by: David Decotigny <david.decotigny@google.com>
---
 drivers/net/ethernet/intel/e1000e/param.c |   98 +++++++++++++++-------------
 1 files changed, 52 insertions(+), 46 deletions(-)
david decotigny - Nov. 17, 2011, 1:42 a.m.
Sorry, I realized that the same fix could be applied to e1000. Sending
an updated v2 patch shortly...

--
David Decotigny



On Wed, Nov 16, 2011 at 5:18 PM, David Decotigny
<david.decotigny@google.com> wrote:
> From: Ying Cai <ycai@google.com>
>
> This change ensures that the itr/itr_setting adjustment logic is used,
> even for the default/compiled-in value.
>
> Context:
>  When we changed the default InterruptThrottleRate value from default
>  (3 = dynamic mode) to 8000 for example, only adapter->itr_setting
>  (which controls interrupt coalescing mode) was set to 8000, but
>  adapter->itr (which controls the value set in NIC register) was not
>  updated accordingly. So from ethtool, it seemed the interrupt
>  throttling is enabled at 8000 intr/s, but the NIC actually was
>  running in dynamic mode which has lower CPU efficiency especially
>  when throughput is not high.
>
>
>
> Signed-off-by: David Decotigny <david.decotigny@google.com>
> ---
>  drivers/net/ethernet/intel/e1000e/param.c |   98 +++++++++++++++-------------
>  1 files changed, 52 insertions(+), 46 deletions(-)
>
> diff --git a/drivers/net/ethernet/intel/e1000e/param.c b/drivers/net/ethernet/intel/e1000e/param.c
> index 20e93b0..41937e5 100644
> --- a/drivers/net/ethernet/intel/e1000e/param.c
> +++ b/drivers/net/ethernet/intel/e1000e/param.c
> @@ -106,7 +106,7 @@ E1000_PARAM(RxAbsIntDelay, "Receive Absolute Interrupt Delay");
>  /*
>  * Interrupt Throttle Rate (interrupts/sec)
>  *
> - * Valid Range: 100-100000 (0=off, 1=dynamic, 3=dynamic conservative)
> + * Valid Range: 100-100000 or one of: 0=off, 1=dynamic, 3=dynamic conservative
>  */
>  E1000_PARAM(InterruptThrottleRate, "Interrupt Throttling Rate");
>  #define DEFAULT_ITR 3
> @@ -335,53 +335,59 @@ void __devinit e1000e_check_options(struct e1000_adapter *adapter)
>
>                if (num_InterruptThrottleRate > bd) {
>                        adapter->itr = InterruptThrottleRate[bd];
> -                       switch (adapter->itr) {
> -                       case 0:
> -                               e_info("%s turned off\n", opt.name);
> -                               break;
> -                       case 1:
> -                               e_info("%s set to dynamic mode\n", opt.name);
> -                               adapter->itr_setting = adapter->itr;
> -                               adapter->itr = 20000;
> -                               break;
> -                       case 3:
> -                               e_info("%s set to dynamic conservative mode\n",
> -                                       opt.name);
> -                               adapter->itr_setting = adapter->itr;
> -                               adapter->itr = 20000;
> -                               break;
> -                       case 4:
> -                               e_info("%s set to simplified (2000-8000 ints) "
> -                                      "mode\n", opt.name);
> -                               adapter->itr_setting = 4;
> -                               break;
> -                       default:
> -                               /*
> -                                * Save the setting, because the dynamic bits
> -                                * change itr.
> -                                */
> -                               if (e1000_validate_option(&adapter->itr, &opt,
> -                                                         adapter) &&
> -                                   (adapter->itr == 3)) {
> -                                       /*
> -                                        * In case of invalid user value,
> -                                        * default to conservative mode.
> -                                        */
> -                                       adapter->itr_setting = adapter->itr;
> -                                       adapter->itr = 20000;
> -                               } else {
> -                                       /*
> -                                        * Clear the lower two bits because
> -                                        * they are used as control.
> -                                        */
> -                                       adapter->itr_setting =
> -                                               adapter->itr & ~3;
> -                               }
> -                               break;
> -                       }
> +
> +                       /* Make sure a message is printed for
> +                        * non-special values. And in case of an
> +                        * invalid option, display warning, use
> +                        * default and go through itr/itr_setting
> +                        * adjustment logic below */
> +                       if ((adapter->itr < 0 || adapter->itr > 4)
> +                           && e1000_validate_option(&adapter->itr, &opt,
> +                                                    adapter))
> +                               adapter->itr = opt.def;
>                } else {
> -                       adapter->itr_setting = opt.def;
> +                       /* if no option specified, use default value
> +                          and go through the logic below to adjust
> +                          itr/itr_setting */
> +                       adapter->itr = opt.def;
> +
> +                       /* Make sure a message is printed for
> +                        * non-special default values */
> +                       if (adapter->itr < 0 || adapter->itr > 4)
> +                               e_info("%s set to default %d\n",
> +                                      opt.name, adapter->itr);
> +               }
> +
> +
> +
> +               adapter->itr_setting = adapter->itr;
> +               switch (adapter->itr) {
> +               case 0:
> +                       e_info("%s turned off\n", opt.name);
> +                       break;
> +               case 1:
> +                       e_info("%s set to dynamic mode\n", opt.name);
> +                       adapter->itr = 20000;
> +                       break;
> +               case 3:
> +                       e_info("%s set to dynamic conservative mode\n",
> +                              opt.name);
>                        adapter->itr = 20000;
> +                       break;
> +               case 4:
> +                       e_info("%s set to simplified (2000-8000 ints) "
> +                              "mode\n", opt.name);
> +                       break;
> +               default:
> +                       /*
> +                        * Save the setting, because the dynamic bits
> +                        * change itr.
> +                        *
> +                        * Clear the lower two bits because
> +                        * they are used as control.
> +                        */
> +                       adapter->itr_setting &= ~3;
> +                       break;
>                }
>        }
>        { /* Interrupt Mode */
> --
> 1.7.3.1
>
>
N‹§²æìr¸›yúèšØb²X¬¶Ç§vØ^–)Þº{.nÇ+‰·§z×^¾)í…æèw*jg¬±¨¶‰šŽŠÝ¢j/êäz¹Þ–Šà2ŠÞ™¨è­Ú&¢)ß¡«a¶Úþø®G«éh®æj:+v‰¨Šwè†Ù¥

Patch

diff --git a/drivers/net/ethernet/intel/e1000e/param.c b/drivers/net/ethernet/intel/e1000e/param.c
index 20e93b0..41937e5 100644
--- a/drivers/net/ethernet/intel/e1000e/param.c
+++ b/drivers/net/ethernet/intel/e1000e/param.c
@@ -106,7 +106,7 @@  E1000_PARAM(RxAbsIntDelay, "Receive Absolute Interrupt Delay");
 /*
  * Interrupt Throttle Rate (interrupts/sec)
  *
- * Valid Range: 100-100000 (0=off, 1=dynamic, 3=dynamic conservative)
+ * Valid Range: 100-100000 or one of: 0=off, 1=dynamic, 3=dynamic conservative
  */
 E1000_PARAM(InterruptThrottleRate, "Interrupt Throttling Rate");
 #define DEFAULT_ITR 3
@@ -335,53 +335,59 @@  void __devinit e1000e_check_options(struct e1000_adapter *adapter)
 
 		if (num_InterruptThrottleRate > bd) {
 			adapter->itr = InterruptThrottleRate[bd];
-			switch (adapter->itr) {
-			case 0:
-				e_info("%s turned off\n", opt.name);
-				break;
-			case 1:
-				e_info("%s set to dynamic mode\n", opt.name);
-				adapter->itr_setting = adapter->itr;
-				adapter->itr = 20000;
-				break;
-			case 3:
-				e_info("%s set to dynamic conservative mode\n",
-					opt.name);
-				adapter->itr_setting = adapter->itr;
-				adapter->itr = 20000;
-				break;
-			case 4:
-				e_info("%s set to simplified (2000-8000 ints) "
-				       "mode\n", opt.name);
-				adapter->itr_setting = 4;
-				break;
-			default:
-				/*
-				 * Save the setting, because the dynamic bits
-				 * change itr.
-				 */
-				if (e1000_validate_option(&adapter->itr, &opt,
-							  adapter) &&
-				    (adapter->itr == 3)) {
-					/*
-					 * In case of invalid user value,
-					 * default to conservative mode.
-					 */
-					adapter->itr_setting = adapter->itr;
-					adapter->itr = 20000;
-				} else {
-					/*
-					 * Clear the lower two bits because
-					 * they are used as control.
-					 */
-					adapter->itr_setting =
-						adapter->itr & ~3;
-				}
-				break;
-			}
+
+			/* Make sure a message is printed for
+			 * non-special values. And in case of an
+			 * invalid option, display warning, use
+			 * default and go through itr/itr_setting
+			 * adjustment logic below */
+			if ((adapter->itr < 0 || adapter->itr > 4)
+			    && e1000_validate_option(&adapter->itr, &opt,
+						     adapter))
+				adapter->itr = opt.def;
 		} else {
-			adapter->itr_setting = opt.def;
+			/* if no option specified, use default value
+			   and go through the logic below to adjust
+			   itr/itr_setting */
+			adapter->itr = opt.def;
+
+			/* Make sure a message is printed for
+			 * non-special default values */
+			if (adapter->itr < 0 || adapter->itr > 4)
+				e_info("%s set to default %d\n",
+				       opt.name, adapter->itr);
+		}
+
+
+
+		adapter->itr_setting = adapter->itr;
+		switch (adapter->itr) {
+		case 0:
+			e_info("%s turned off\n", opt.name);
+			break;
+		case 1:
+			e_info("%s set to dynamic mode\n", opt.name);
+			adapter->itr = 20000;
+			break;
+		case 3:
+			e_info("%s set to dynamic conservative mode\n",
+			       opt.name);
 			adapter->itr = 20000;
+			break;
+		case 4:
+			e_info("%s set to simplified (2000-8000 ints) "
+			       "mode\n", opt.name);
+			break;
+		default:
+			/*
+			 * Save the setting, because the dynamic bits
+			 * change itr.
+			 *
+			 * Clear the lower two bits because
+			 * they are used as control.
+			 */
+			adapter->itr_setting &= ~3;
+			break;
 		}
 	}
 	{ /* Interrupt Mode */