| Message ID | 20200324215809.77787-1-james.hilliard1@gmail.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [1/1] package/wpewebkit: bump to version 2.28.0 | expand |
On Tue, 24 Mar 2020 15:58:09 -0600 James Hilliard <james.hilliard1@gmail.com> wrote: > Adjust fix build with musl patch for 2.28.0. > > Signed-off-by: James Hilliard <james.hilliard1@gmail.com> > --- > package/wpewebkit/0001-Fix-build-with-musl.patch | 6 +++--- > package/wpewebkit/wpewebkit.hash | 8 ++++---- > package/wpewebkit/wpewebkit.mk | 2 +- > 3 files changed, 8 insertions(+), 8 deletions(-) Applied to master, thanks. Why isn't the musl patch upstream ? :-) Thomas
On Sun, Mar 29, 2020 at 2:13 PM Thomas Petazzoni <thomas.petazzoni@bootlin.com> wrote: > > On Tue, 24 Mar 2020 15:58:09 -0600 > James Hilliard <james.hilliard1@gmail.com> wrote: > > > Adjust fix build with musl patch for 2.28.0. > > > > Signed-off-by: James Hilliard <james.hilliard1@gmail.com> > > --- > > package/wpewebkit/0001-Fix-build-with-musl.patch | 6 +++--- > > package/wpewebkit/wpewebkit.hash | 8 ++++---- > > package/wpewebkit/wpewebkit.mk | 2 +- > > 3 files changed, 8 insertions(+), 8 deletions(-) > > Applied to master, thanks. Why isn't the musl patch upstream ? :-) Not sure, maybe Adrian might know? > > Thomas > -- > Thomas Petazzoni, CTO, Bootlin > Embedded Linux and Kernel engineering > https://bootlin.com
Hello, On Sun, 29 Mar 2020 22:27:15 -0600, James Hilliard <james.hilliard1@gmail.com> wrote: > On Sun, Mar 29, 2020 at 2:13 PM Thomas Petazzoni > <thomas.petazzoni@bootlin.com> wrote: > > > > On Tue, 24 Mar 2020 15:58:09 -0600 > > James Hilliard <james.hilliard1@gmail.com> wrote: > > > > > Adjust fix build with musl patch for 2.28.0. > > > > > > Signed-off-by: James Hilliard <james.hilliard1@gmail.com> > > > --- > > > package/wpewebkit/0001-Fix-build-with-musl.patch | 6 +++--- > > > package/wpewebkit/wpewebkit.hash | 8 ++++---- > > > package/wpewebkit/wpewebkit.mk | 2 +- > > > 3 files changed, 8 insertions(+), 8 deletions(-) > > > > Applied to master, thanks. Why isn't the musl patch upstream ? :-) > > Not sure, maybe Adrian might know? Nobody has attempted to send the patch upstream. Maybe I can do it myself :] Note to self: The OpenBSD people are applying some patches which would be neat having upstream as well. Note that in WebKit trunk we have now a fix [1] which will explicitly set the thread stack sizes using “pthread_attr_setstacksize()”, which should further help with Musl (and possibly uClibc) — I have tried at backporting it over to the 2.28 release branch but it's not trivial and it will need another attempt at some point, or waiting until 2.30.x for it ;-) Cheers, —Adrián --- [1] https://bugs.webkit.org/show_bug.cgi?id=208223
>>>>> "James" == James Hilliard <james.hilliard1@gmail.com> writes: > Adjust fix build with musl patch for 2.28.0. This is a security bump, so should be marked as such: https://webkitgtk.org/security/WSA-2020-0003.html What about the corresponding webkitgtk bump?
On Tue, Apr 7, 2020 at 1:29 PM Peter Korsgaard <peter@korsgaard.com> wrote: > > >>>>> "James" == James Hilliard <james.hilliard1@gmail.com> writes: > > > Adjust fix build with musl patch for 2.28.0. > > This is a security bump, so should be marked as such: > > https://webkitgtk.org/security/WSA-2020-0003.html > > What about the corresponding webkitgtk bump? I'm not really set up for testing webkitgtk, maybe Adrian can handle that. > > -- > Bye, Peter Korsgaard
Hello, On Tue, 7 Apr 2020 13:32:49 -0600, James Hilliard <james.hilliard1@gmail.com> wrote: > On Tue, Apr 7, 2020 at 1:29 PM Peter Korsgaard <peter@korsgaard.com> wrote: > > > > >>>>> "James" == James Hilliard <james.hilliard1@gmail.com> writes: > > > > > Adjust fix build with musl patch for 2.28.0. > > > > This is a security bump, so should be marked as such: > > > > https://webkitgtk.org/security/WSA-2020-0003.html > > > > What about the corresponding webkitgtk bump? > > I'm not really set up for testing webkitgtk, maybe Adrian can handle that. I will be sending a patch to update WebKitGTK soon =) Cheers, —Adrián
On Wed, 8 Apr 2020 17:57:58 +0300, Adrian Perez de Castro <aperez@igalia.com> wrote: > Hello, > > On Tue, 7 Apr 2020 13:32:49 -0600, James Hilliard <james.hilliard1@gmail.com> wrote: > > On Tue, Apr 7, 2020 at 1:29 PM Peter Korsgaard <peter@korsgaard.com> wrote: > > > > > > >>>>> "James" == James Hilliard <james.hilliard1@gmail.com> writes: > > > > > > > Adjust fix build with musl patch for 2.28.0. > > > > > > This is a security bump, so should be marked as such: > > > > > > https://webkitgtk.org/security/WSA-2020-0003.html > > > > > > What about the corresponding webkitgtk bump? > > > > I'm not really set up for testing webkitgtk, maybe Adrian can handle that. > > I will be sending a patch to update WebKitGTK soon =) Here goes: https://patchwork.ozlabs.org/patch/1268124/ :-]
diff --git a/package/wpewebkit/0001-Fix-build-with-musl.patch b/package/wpewebkit/0001-Fix-build-with-musl.patch index a436adf6ce..705c67c7f6 100644 --- a/package/wpewebkit/0001-Fix-build-with-musl.patch +++ b/package/wpewebkit/0001-Fix-build-with-musl.patch @@ -9,7 +9,7 @@ https://github.com/WebPlatformForEmbedded/meta-wpe/blob/master/recipes-wpe/wpewe Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com> --- Source/JavaScriptCore/runtime/MachineContext.h | 10 +++++----- - Source/WTF/wtf/Platform.h | 2 +- + Source/WTF/wtf/PlatformHave.h | 2 +- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/Source/JavaScriptCore/runtime/MachineContext.h b/Source/JavaScriptCore/runtime/MachineContext.h @@ -63,8 +63,8 @@ index bf0bdc7a51a..78d2ec81838 100644 #if CPU(X86) diff --git a/Source/WTF/wtf/Platform.h b/Source/WTF/wtf/Platform.h index e2a3388993f..95fe7c593cf 100644 ---- a/Source/WTF/wtf/Platform.h -+++ b/Source/WTF/wtf/Platform.h +--- a/Source/WTF/wtf/PlatformHave.h ++++ b/Source/WTF/wtf/PlatformHave.h @@ -683,7 +683,7 @@ #define HAVE_CFNETWORK_STORAGE_PARTITIONING 1 #endif diff --git a/package/wpewebkit/wpewebkit.hash b/package/wpewebkit/wpewebkit.hash index fd78264914..2e7016fe38 100644 --- a/package/wpewebkit/wpewebkit.hash +++ b/package/wpewebkit/wpewebkit.hash @@ -1,7 +1,7 @@ -# From https://wpewebkit.org/releases/wpewebkit-2.26.4.tar.xz.sums -md5 4cd2883ec9da38a0ffe413bb75239874 wpewebkit-2.26.4.tar.xz -sha1 337f78ee237fe98c7e6e728d8fc0508069b007be wpewebkit-2.26.4.tar.xz -sha256 0c292182864b63b725491f1a69b55c03e0e75f6db0875389caff31fe9c0d3ae9 wpewebkit-2.26.4.tar.xz +# From https://wpewebkit.org/releases/wpewebkit-2.28.0.tar.xz.sums +md5 4298b9d38b4f05f92995422ea9979893 wpewebkit-2.28.0.tar.xz +sha1 9e791b6112cca8cda51ae7e991b545f4bf0bb46c wpewebkit-2.28.0.tar.xz +sha256 a85cd3cb46206a4929a9562d53379a7e7e2ec1a3224b34e2dcf5da30bb906722 wpewebkit-2.28.0.tar.xz # Hashes for license files: sha256 0b5d3a7cc325942567373b0ecd757d07c132e0ebd7c97bfc63f7e1a76094edb4 Source/WebCore/LICENSE-APPLE diff --git a/package/wpewebkit/wpewebkit.mk b/package/wpewebkit/wpewebkit.mk index 6591c7a0d8..9c969cae5a 100644 --- a/package/wpewebkit/wpewebkit.mk +++ b/package/wpewebkit/wpewebkit.mk @@ -4,7 +4,7 @@ # ################################################################################ -WPEWEBKIT_VERSION = 2.26.4 +WPEWEBKIT_VERSION = 2.28.0 WPEWEBKIT_SITE = http://www.wpewebkit.org/releases WPEWEBKIT_SOURCE = wpewebkit-$(WPEWEBKIT_VERSION).tar.xz WPEWEBKIT_INSTALL_STAGING = YES
Adjust fix build with musl patch for 2.28.0. Signed-off-by: James Hilliard <james.hilliard1@gmail.com> --- package/wpewebkit/0001-Fix-build-with-musl.patch | 6 +++--- package/wpewebkit/wpewebkit.hash | 8 ++++---- package/wpewebkit/wpewebkit.mk | 2 +- 3 files changed, 8 insertions(+), 8 deletions(-)