[ovs-dev] vlog: Fix OVS_REQUIRES macro.
diff mbox series

Message ID 1585077398-106736-1-git-send-email-u9012063@gmail.com
State New
Headers show
Series
  • [ovs-dev] vlog: Fix OVS_REQUIRES macro.
Related show

Commit Message

William Tu March 24, 2020, 7:16 p.m. UTC
Pass lock objects, not their addresses, to the annotation macros.

Signed-off-by: William Tu <u9012063@gmail.com>
---
 lib/vlog.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Ben Pfaff March 24, 2020, 7:31 p.m. UTC | #1
On Tue, Mar 24, 2020 at 12:16:38PM -0700, William Tu wrote:
> Pass lock objects, not their addresses, to the annotation macros.
> 
> Signed-off-by: William Tu <u9012063@gmail.com>

Acked-by: Ben Pfaff <blp@ovn.org>
William Tu March 24, 2020, 7:46 p.m. UTC | #2
On Tue, Mar 24, 2020 at 12:31:33PM -0700, Ben Pfaff wrote:
> On Tue, Mar 24, 2020 at 12:16:38PM -0700, William Tu wrote:
> > Pass lock objects, not their addresses, to the annotation macros.
> > 
> > Signed-off-by: William Tu <u9012063@gmail.com>
> 
> Acked-by: Ben Pfaff <blp@ovn.org>
Applied, thanks.

Patch
diff mbox series

diff --git a/lib/vlog.c b/lib/vlog.c
index 6d17d4837e9c..ee6b0d3a620a 100644
--- a/lib/vlog.c
+++ b/lib/vlog.c
@@ -257,7 +257,7 @@  vlog_get_level(const struct vlog_module *module,
 }
 
 static void
-update_min_level(struct vlog_module *module) OVS_REQUIRES(&log_file_mutex)
+update_min_level(struct vlog_module *module) OVS_REQUIRES(log_file_mutex)
 {
     enum vlog_destination destination;