| Message ID | 20200323180632.14119-7-Sergey.Semin@baikalelectronics.ru |
|---|---|
| State | New |
| Headers | show |
| Series | gpio: dwapb: Fix reference clocks usage | expand |
On Mon, Mar 23, 2020 at 09:06:32PM +0300, Sergey.Semin@baikalelectronics.ru wrote: > From: Serge Semin <Sergey.Semin@baikalelectronics.ru> > > Add myself as a co-maintainer of the Synopsis DesignWare APB GPIO driver. I see neither cover letter, nor first three patches. What's going on? > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -16084,6 +16084,7 @@ F: drivers/tty/serial/8250/8250_dw.c > > SYNOPSYS DESIGNWARE APB GPIO DRIVER > M: Hoan Tran <hoan@os.amperecomputing.com> > +S: Serge Semin <fancer.lancer@gmail.com> Are you sure you used a correct letter? > L: linux-gpio@vger.kernel.org > S: Maintained > F: Documentation/devicetree/bindings/gpio/snps-dwapb-gpio.txt Had you chance to run parse-maintainers.pl to see if other fields are in order?
On Mon, 2020-03-23 at 21:06 +0300, Sergey.Semin@baikalelectronics.ru wrote: > From: Serge Semin <Sergey.Semin@baikalelectronics.ru> > > Add myself as a co-maintainer of the Synopsis DesignWare APB GPIO driver. [] > diff --git a/MAINTAINERS b/MAINTAINERS [] > @@ -16084,6 +16084,7 @@ F: drivers/tty/serial/8250/8250_dw.c > > SYNOPSYS DESIGNWARE APB GPIO DRIVER > M: Hoan Tran <hoan@os.amperecomputing.com> > +S: Serge Semin <fancer.lancer@gmail.com> nack - S: is not the right line type prefix You need to use an M: type line not an S:. The S: line is for subsystem status which should be one of: S: *Status*, one of the following: Supported: Someone is actually paid to look after this. Maintained: Someone actually looks after it. Odd Fixes: It has a maintainer but they don't have time to do much other than throw the odd patch in. See below.. Orphan: No current maintainer [but maybe you could take the role as you write your new code]. Obsolete: Old code. Something tagged obsolete generally means it has been replaced by a better system and you should be using that. > L: linux-gpio@vger.kernel.org > S: Maintained like this... > F: Documentation/devicetree/bindings/gpio/snps-dwapb-gpio.txt
Drop unneeded Cc's. On Mon, Mar 23, 2020 at 09:06:32PM +0300, Sergey.Semin@baikalelectronics.ru wrote: > From: Serge Semin <Sergey.Semin@baikalelectronics.ru> > > Add myself as a co-maintainer of the Synopsis DesignWare APB GPIO driver. By the way, if you are really wanting to maintain the driver, I may give you (for free) Intel Galileo board where this IP is being used. Send me private mail where we can discuss how to deliver.
On Mon, Mar 23, 2020 at 11:36:45AM -0700, Joe Perches wrote: > On Mon, 2020-03-23 at 21:06 +0300, Sergey.Semin@baikalelectronics.ru > wrote: > > From: Serge Semin <Sergey.Semin@baikalelectronics.ru> > > > > Add myself as a co-maintainer of the Synopsis DesignWare APB GPIO driver. > [] > > diff --git a/MAINTAINERS b/MAINTAINERS > [] > > @@ -16084,6 +16084,7 @@ F: drivers/tty/serial/8250/8250_dw.c > > > > SYNOPSYS DESIGNWARE APB GPIO DRIVER > > M: Hoan Tran <hoan@os.amperecomputing.com> > > +S: Serge Semin <fancer.lancer@gmail.com> > > nack - S: is not the right line type prefix > > You need to use an M: type line not an S:. > Ah, yeah. Will fix it in v3. Regards, -Sergey > The S: line is for subsystem status which should be one of: > > S: *Status*, one of the following: > Supported: Someone is actually paid to look after this. > Maintained: Someone actually looks after it. > Odd Fixes: It has a maintainer but they don't have time to do > much other than throw the odd patch in. See below.. > Orphan: No current maintainer [but maybe you could take the > role as you write your new code]. > Obsolete: Old code. Something tagged obsolete generally means > it has been replaced by a better system and you > should be using that. > > > L: linux-gpio@vger.kernel.org > > S: Maintained > > like this... > > > F: Documentation/devicetree/bindings/gpio/snps-dwapb-gpio.txt > > >
On Mon, Mar 23, 2020 at 08:34:24PM +0200, Andy Shevchenko wrote: > On Mon, Mar 23, 2020 at 09:06:32PM +0300, Sergey.Semin@baikalelectronics.ru wrote: > > From: Serge Semin <Sergey.Semin@baikalelectronics.ru> > > > > Add myself as a co-maintainer of the Synopsis DesignWare APB GPIO driver. > > I see neither cover letter, nor first three patches. What's going on? > Automatic "cc-cmd" is added you to the Cc list. You've been referenced as a patch submitter, that's why you are in Cc to this and some another patch. Regards, -Sergey > > --- a/MAINTAINERS > > +++ b/MAINTAINERS > > @@ -16084,6 +16084,7 @@ F: drivers/tty/serial/8250/8250_dw.c > > > > SYNOPSYS DESIGNWARE APB GPIO DRIVER > > M: Hoan Tran <hoan@os.amperecomputing.com> > > > +S: Serge Semin <fancer.lancer@gmail.com> > > Are you sure you used a correct letter? > > > L: linux-gpio@vger.kernel.org > > S: Maintained > > F: Documentation/devicetree/bindings/gpio/snps-dwapb-gpio.txt > > Had you chance to run parse-maintainers.pl to see if other fields are in order? > > -- > With Best Regards, > Andy Shevchenko > >
On Mon, Mar 23, 2020 at 08:41:02PM +0200, Andy Shevchenko wrote: > Drop unneeded Cc's. > > On Mon, Mar 23, 2020 at 09:06:32PM +0300, Sergey.Semin@baikalelectronics.ru wrote: > > From: Serge Semin <Sergey.Semin@baikalelectronics.ru> > > > > Add myself as a co-maintainer of the Synopsis DesignWare APB GPIO driver. > > By the way, if you are really wanting to maintain the driver, I may give you > (for free) Intel Galileo board where this IP is being used. > > Send me private mail where we can discuss how to deliver. > You can communicate with me via this email: fancer.lancer (at) gmail.com -Sergey > -- > With Best Regards, > Andy Shevchenko > >
diff --git a/MAINTAINERS b/MAINTAINERS index 6158a143a13e..1940862de204 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -16084,6 +16084,7 @@ F: drivers/tty/serial/8250/8250_dw.c SYNOPSYS DESIGNWARE APB GPIO DRIVER M: Hoan Tran <hoan@os.amperecomputing.com> +S: Serge Semin <fancer.lancer@gmail.com> L: linux-gpio@vger.kernel.org S: Maintained F: Documentation/devicetree/bindings/gpio/snps-dwapb-gpio.txt