Patchwork endless loop when use qemu-system-mipsel to load bios

login
register
mail settings
Submitter rui chen
Date Nov. 16, 2011, 3:21 p.m.
Message ID <CAMOKqhKB_JD91CRGie7WMKz24OgGW55W=XOMkAZQFJ=gNEkL-Q@mail.gmail.com>
Download mbox | patch
Permalink /patch/126000/
State New
Headers show

Comments

rui chen - Nov. 16, 2011, 3:21 p.m.
sorry, here is my new patch file:

From 05f4abe8d8c37f1585f2bb7cb89b15426044bb65 Mon Sep 17 00:00:00 2001
From: Chen Rui <chennrui@gmail.com>
Date: Sun, 13 Nov 2011 19:42:42 +0800
Subject: [PATCH] resolve an endless loop when use qemu-system-mipsel to
load bios


Signed-off-by: Chen Rui <chennrui@gmail.com>
---
 hw/mips_malta.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
Stefan Weil - Dec. 3, 2011, 10:27 p.m.
Am 16.11.2011 16:21, schrieb rui chen:
> sorry, here is my new patch file:
>
> From 05f4abe8d8c37f1585f2bb7cb89b15426044bb65 Mon Sep 17 00:00:00 2001
> From: Chen Rui <chennrui@gmail.com <mailto:chennrui@gmail.com>>
> Date: Sun, 13 Nov 2011 19:42:42 +0800
> Subject: [PATCH] resolve an endless loop when use qemu-system-mipsel 
> to load bios
>
>
> Signed-off-by: Chen Rui <chennrui@gmail.com <mailto:chennrui@gmail.com>>
> ---
>  hw/mips_malta.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/hw/mips_malta.c b/hw/mips_malta.c
> index bb49749..e7dfbd6 100644
> --- a/hw/mips_malta.c
> +++ b/hw/mips_malta.c
> @@ -911,6 +911,7 @@ void mips_malta_init (ram_addr_t ram_size,
>              uint32_t *end = addr + bios_size;
>              while (addr < end) {
>                  bswap32s(addr);
> +                addr++;
>              }
>          }
>  #endif
> -- 
> 1.7.1

This patch fixes a regression introduced by commit
d758525180e0efff8a59cfea11f5f8348014ff6a
(More phys_ram_base elimination).

Please apply it to QEMU git master (with a modified subject, s/use/using/).

Tested-by: Stefan Weil <sw@weilnetz.de>

Regards,
Stefan Weil
Stefan Hajnoczi - Dec. 6, 2011, 10:44 a.m.
On Sat, Dec 03, 2011 at 11:27:29PM +0100, Stefan Weil wrote:
> Am 16.11.2011 16:21, schrieb rui chen:
> >sorry, here is my new patch file:
> >
> >From 05f4abe8d8c37f1585f2bb7cb89b15426044bb65 Mon Sep 17 00:00:00 2001
> >From: Chen Rui <chennrui@gmail.com <mailto:chennrui@gmail.com>>
> >Date: Sun, 13 Nov 2011 19:42:42 +0800
> >Subject: [PATCH] resolve an endless loop when use
> >qemu-system-mipsel to load bios
> >
> >
> >Signed-off-by: Chen Rui <chennrui@gmail.com <mailto:chennrui@gmail.com>>
> >---
> > hw/mips_malta.c |    1 +
> > 1 files changed, 1 insertions(+), 0 deletions(-)
> >
> >diff --git a/hw/mips_malta.c b/hw/mips_malta.c
> >index bb49749..e7dfbd6 100644
> >--- a/hw/mips_malta.c
> >+++ b/hw/mips_malta.c
> >@@ -911,6 +911,7 @@ void mips_malta_init (ram_addr_t ram_size,
> >             uint32_t *end = addr + bios_size;
> >             while (addr < end) {
> >                 bswap32s(addr);
> >+                addr++;
> >             }
> >         }
> > #endif
> >-- 
> >1.7.1
> 
> This patch fixes a regression introduced by commit
> d758525180e0efff8a59cfea11f5f8348014ff6a
> (More phys_ram_base elimination).
> 
> Please apply it to QEMU git master (with a modified subject, s/use/using/).
> 
> Tested-by: Stefan Weil <sw@weilnetz.de>

Thanks, applied to the trivial patches -next tree.

Stefan

Patch

From 05f4abe8d8c37f1585f2bb7cb89b15426044bb65 Mon Sep 17 00:00:00 2001
From: Chen Rui <chennrui@gmail.com>
Date: Sun, 13 Nov 2011 19:42:42 +0800
Subject: [PATCH] resolve an endless loop when use qemu-system-mipsel to load bios


Signed-off-by: Chen Rui <chennrui@gmail.com>
---
 hw/mips_malta.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/hw/mips_malta.c b/hw/mips_malta.c
index bb49749..e7dfbd6 100644
--- a/hw/mips_malta.c
+++ b/hw/mips_malta.c
@@ -911,6 +911,7 @@  void mips_malta_init (ram_addr_t ram_size,
             uint32_t *end = addr + bios_size;
             while (addr < end) {
                 bswap32s(addr);
+                addr++;
             }
         }
 #endif
-- 
1.7.1