diff mbox series

[4/8] package/python3-cheetah: add special host variant

Message ID 20200323104909.16765-4-yegorslists@googlemail.com
State Accepted
Headers show
Series [1/8] package/python-psutil: add host variant | expand

Commit Message

Yegor Yefremov March 23, 2020, 10:49 a.m. UTC 
From: Yegor Yefremov <yegorslists@googlemail.com>

Needed to build mongodb.

Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
---
 package/python3-cheetah/python-cheetah.mk    | 18 ++++++++++++++++++
 package/python3-cheetah/python3-cheetah.hash |  1 +
 2 files changed, 19 insertions(+)
 create mode 100644 package/python3-cheetah/python-cheetah.mk
 create mode 120000 package/python3-cheetah/python3-cheetah.hash

Comments

Thomas Petazzoni April 24, 2020, 1 p.m. UTC | #1 
On Mon, 23 Mar 2020 11:49:05 +0100
yegorslists@googlemail.com wrote:

> From: Yegor Yefremov <yegorslists@googlemail.com>
> 
> Needed to build mongodb.
> 
> Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
> ---
>  package/python3-cheetah/python-cheetah.mk    | 18 ++++++++++++++++++

The name of the .mk file was wrong, it should have been python3-cheetah.mk.

With your version of the patch, check-package was complaining quite
loudly:

package/python3-cheetah/python-cheetah.mk:9: possible typo: PYTHON3_CHEETAH_VERSION -> *PYTHON_CHEETAH*
package/python3-cheetah/python-cheetah.mk:10: possible typo: PYTHON3_CHEETAH_SOURCE -> *PYTHON_CHEETAH*
package/python3-cheetah/python-cheetah.mk:11: possible typo: PYTHON3_CHEETAH_SITE -> *PYTHON_CHEETAH*
package/python3-cheetah/python-cheetah.mk:12: possible typo: PYTHON3_CHEETAH_LICENSE -> *PYTHON_CHEETAH*
package/python3-cheetah/python-cheetah.mk:13: possible typo: PYTHON3_CHEETAH_LICENSE_FILES -> *PYTHON_CHEETAH*
package/python3-cheetah/python-cheetah.mk:14: possible typo: PYTHON3_CHEETAH_SETUP_TYPE -> *PYTHON_CHEETAH*
package/python3-cheetah/python-cheetah.mk:15: possible typo: HOST_PYTHON3_CHEETAH_DL_SUBDIR -> *PYTHON_CHEETAH*
package/python3-cheetah/python-cheetah.mk:16: possible typo: HOST_PYTHON3_CHEETAH_NEEDS_HOST_PYTHON -> *PYTHON_CHEETAH

> +# Please keep in sync with
> +# package/python-cheetah/python-cheetah.mk

This comment fits on one line. And I've added the corresponding comment
in package/python-cheetah/python-cheetah.mk.

Applied with these changes. Thanks!

Thomas
diff mbox series

Patch

diff --git a/package/python3-cheetah/python-cheetah.mk b/package/python3-cheetah/python-cheetah.mk
new file mode 100644
index 0000000000..8876f8d735
--- /dev/null
+++ b/package/python3-cheetah/python-cheetah.mk
@@ -0,0 +1,18 @@ 
+################################################################################
+#
+# python3-cheetah
+#
+################################################################################
+
+# Please keep in sync with
+# package/python-cheetah/python-cheetah.mk
+PYTHON3_CHEETAH_VERSION = 3.2.4
+PYTHON3_CHEETAH_SOURCE = Cheetah3-$(PYTHON3_CHEETAH_VERSION).tar.gz
+PYTHON3_CHEETAH_SITE = https://files.pythonhosted.org/packages/4e/72/e6a7d92279e3551db1b68fd336fd7a6e3d2f2ec742bf486486e6150d77d2
+PYTHON3_CHEETAH_LICENSE = MIT
+PYTHON3_CHEETAH_LICENSE_FILES = LICENSE
+PYTHON3_CHEETAH_SETUP_TYPE = setuptools
+HOST_PYTHON3_CHEETAH_DL_SUBDIR = python-cheetah
+HOST_PYTHON3_CHEETAH_NEEDS_HOST_PYTHON = python3
+
+$(eval $(host-python-package))
diff --git a/package/python3-cheetah/python3-cheetah.hash b/package/python3-cheetah/python3-cheetah.hash
new file mode 120000
index 0000000000..c29a76ea80
--- /dev/null
+++ b/package/python3-cheetah/python3-cheetah.hash
@@ -0,0 +1 @@ 
+../python-cheetah/python-cheetah.hash
\ No newline at end of file