| Message ID | 600e0b027a4e62a4aea8900e5a1e95e3e14b10f0.1584943873.git.baolin.wang7@gmail.com |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | [v2,1/2] dt-bindings: mailbox: Add the Spreadtrum mailbox documentation | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/dt-meta-schema | success |
On Mon, Mar 23, 2020 at 02:13:46PM +0800, Baolin Wang wrote: > From: Baolin Wang <baolin.wang@unisoc.com> > > Add the Spreadtrum mailbox documentation. > > Signed-off-by: Baolin Wang <baolin.wang@unisoc.com> > Signed-off-by: Baolin Wang <baolin.wang7@gmail.com> > --- > Changes from v1: > - Add 'additionalProperties'. > - Split description for each entry. > --- > .../devicetree/bindings/mailbox/sprd-mailbox.yaml | 62 ++++++++++++++++++++++ > 1 file changed, 62 insertions(+) > create mode 100644 Documentation/devicetree/bindings/mailbox/sprd-mailbox.yaml > > diff --git a/Documentation/devicetree/bindings/mailbox/sprd-mailbox.yaml b/Documentation/devicetree/bindings/mailbox/sprd-mailbox.yaml > new file mode 100644 > index 0000000..0848b18 > --- /dev/null > +++ b/Documentation/devicetree/bindings/mailbox/sprd-mailbox.yaml > @@ -0,0 +1,62 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: "http://devicetree.org/schemas/mailbox/sprd-mailbox.yaml#" > +$schema: "http://devicetree.org/meta-schemas/core.yaml#" > + > +title: Spreadtrum mailbox controller bindings > + > +maintainers: > + - Orson Zhai <orsonzhai@gmail.com> > + - Baolin Wang <baolin.wang7@gmail.com> > + - Chunyan Zhang <zhang.lyra@gmail.com> > + > +properties: > + compatible: > + enum: > + - sprd,sc9860-mailbox > + > + reg: > + items: > + - description: inbox registers' base address > + - description: outbox registers' base address > + minItems: 2 This is redundant, drop it. > + > + interrupts: > + items: > + - description: inbox interrupt > + - description: outbox interrupt > + minItems: 2 Same here. With that, Reviewed-by: Rob Herring <robh@kernel.org>
On Wed, Apr 1, 2020 at 1:40 AM Rob Herring <robh@kernel.org> wrote: > > On Mon, Mar 23, 2020 at 02:13:46PM +0800, Baolin Wang wrote: > > From: Baolin Wang <baolin.wang@unisoc.com> > > > > Add the Spreadtrum mailbox documentation. > > > > Signed-off-by: Baolin Wang <baolin.wang@unisoc.com> > > Signed-off-by: Baolin Wang <baolin.wang7@gmail.com> > > --- > > Changes from v1: > > - Add 'additionalProperties'. > > - Split description for each entry. > > --- > > .../devicetree/bindings/mailbox/sprd-mailbox.yaml | 62 ++++++++++++++++++++++ > > 1 file changed, 62 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/mailbox/sprd-mailbox.yaml > > > > diff --git a/Documentation/devicetree/bindings/mailbox/sprd-mailbox.yaml b/Documentation/devicetree/bindings/mailbox/sprd-mailbox.yaml > > new file mode 100644 > > index 0000000..0848b18 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/mailbox/sprd-mailbox.yaml > > @@ -0,0 +1,62 @@ > > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: "http://devicetree.org/schemas/mailbox/sprd-mailbox.yaml#" > > +$schema: "http://devicetree.org/meta-schemas/core.yaml#" > > + > > +title: Spreadtrum mailbox controller bindings > > + > > +maintainers: > > + - Orson Zhai <orsonzhai@gmail.com> > > + - Baolin Wang <baolin.wang7@gmail.com> > > + - Chunyan Zhang <zhang.lyra@gmail.com> > > + > > +properties: > > + compatible: > > + enum: > > + - sprd,sc9860-mailbox > > + > > + reg: > > + items: > > + - description: inbox registers' base address > > + - description: outbox registers' base address > > > + minItems: 2 > > This is redundant, drop it. OK. > > > + > > + interrupts: > > + items: > > + - description: inbox interrupt > > + - description: outbox interrupt > > + minItems: 2 > > Same here. Sure. > > With that, > > Reviewed-by: Rob Herring <robh@kernel.org> Thanks for your comments.
diff --git a/Documentation/devicetree/bindings/mailbox/sprd-mailbox.yaml b/Documentation/devicetree/bindings/mailbox/sprd-mailbox.yaml new file mode 100644 index 0000000..0848b18 --- /dev/null +++ b/Documentation/devicetree/bindings/mailbox/sprd-mailbox.yaml @@ -0,0 +1,62 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +%YAML 1.2 +--- +$id: "http://devicetree.org/schemas/mailbox/sprd-mailbox.yaml#" +$schema: "http://devicetree.org/meta-schemas/core.yaml#" + +title: Spreadtrum mailbox controller bindings + +maintainers: + - Orson Zhai <orsonzhai@gmail.com> + - Baolin Wang <baolin.wang7@gmail.com> + - Chunyan Zhang <zhang.lyra@gmail.com> + +properties: + compatible: + enum: + - sprd,sc9860-mailbox + + reg: + items: + - description: inbox registers' base address + - description: outbox registers' base address + minItems: 2 + + interrupts: + items: + - description: inbox interrupt + - description: outbox interrupt + minItems: 2 + + clocks: + maxItems: 1 + + clock-names: + items: + - const: enable + + "#mbox-cells": + const: 1 + +required: + - compatible + - reg + - interrupts + - "#mbox-cells" + - clocks + - clock-names + +additionalProperties: false + +examples: + - | + #include <dt-bindings/interrupt-controller/arm-gic.h> + mailbox: mailbox@400a0000 { + compatible = "sprd,sc9860-mailbox"; + reg = <0 0x400a0000 0 0x8000>, <0 0x400a8000 0 0x8000>; + #mbox-cells = <1>; + clock-names = "enable"; + clocks = <&aon_gate 53>; + interrupts = <GIC_SPI 28 IRQ_TYPE_LEVEL_HIGH>, <GIC_SPI 29 IRQ_TYPE_LEVEL_HIGH>; + }; +...