| Message ID | 20200322211002.30765-1-ps.report@gmx.net |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | [v1,1/2] package/python-jinja2: fix runtime python modules dependencies | expand |
On Sun, 22 Mar 2020 22:10:01 +0100 Peter Seiderer <ps.report@gmx.net> wrote: > - add python unicodedata runtime dependency, fixes: > File "usr/lib/python3.8/site-packages/jinja2/lexer.py", line 46, in <module> > ModuleNotFoundError: No module named 'unicodedata' > --- > package/python-jinja2/Config.in | 2 ++ > 1 file changed, 2 insertions(+) These two patches lack your Signed-off-by. Also, what about adding runtime tests for those two packages, to detect such missing runtime dependencies ? Thanks! Thomas
Hello Thomas, On Sun, 22 Mar 2020 22:17:50 +0100, Thomas Petazzoni <thomas.petazzoni@bootlin.com> wrote: > On Sun, 22 Mar 2020 22:10:01 +0100 > Peter Seiderer <ps.report@gmx.net> wrote: > > > - add python unicodedata runtime dependency, fixes: > > File "usr/lib/python3.8/site-packages/jinja2/lexer.py", line 46, in <module> > > ModuleNotFoundError: No module named 'unicodedata' > > --- > > package/python-jinja2/Config.in | 2 ++ > > 1 file changed, 2 insertions(+) > > These two patches lack your Signed-off-by. Also, what about adding > runtime tests for those two packages, to detect such missing runtime > dependencies ? Ups, will re-send with the Signed-off-by added... Will take a look at the runtime tests... Regards, Peter > > Thanks! > > Thomas
diff --git a/package/python-jinja2/Config.in b/package/python-jinja2/Config.in index a1900e94d5..5b99df75b8 100644 --- a/package/python-jinja2/Config.in +++ b/package/python-jinja2/Config.in @@ -1,6 +1,8 @@ config BR2_PACKAGE_PYTHON_JINJA2 bool "python-jinja2" select BR2_PACKAGE_PYTHON_MARKUPSAFE # runtime + select BR2_PACKAGE_PYTHON_UNICODEDATA if BR2_PACKAGE_PYTHON + select BR2_PACKAGE_PYTHON3_UNICODEDATA if BR2_PACKAGE_PYTHON3 help Jinja2 is a template engine written in pure Python. It provides a Django inspired non-XML syntax but supports