From patchwork Wed Nov 16 09:45:38 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: [Natty,SRU] drm/i915: fix CB tuning check for ILK+ Date: Tue, 15 Nov 2011 23:45:38 -0000 From: TImo Aaltonen X-Patchwork-Id: 125971 Message-Id: <4EC38642.9070706@ubuntu.com> To: kernel-team@lists.ubuntu.com https://bugs.launchpad.net/ubuntu/+source/linux/+bug/891031 This patch fixes panel corruption on my T420s which occurs after plugging an external monitor to the vga port. Originally from 3.1, applies to 3.0 too but I'll post this upstream to include in the stable series. upstream commit cb0e093162d7b6589c2217a00e2abfef686b32d6 Signed-off-by: Timo Aaltonen >From cb0e093162d7b6589c2217a00e2abfef686b32d6 Mon Sep 17 00:00:00 2001 From: Jesse Barnes Date: Thu, 28 Jul 2011 14:50:30 -0700 Subject: [PATCH] drm/i915: fix CB tuning check for ILK+ CB tuning is needed to handle potential process variations that might cause clock jitter for certain PLL settings. However, we were setting it incorrectly since we were using the wrong M value as a check (M1 when we needed to use the whole M value). Fix it up, making my HDMI attached display a little prettier (used to have occasional dots crawl across the display). Signed-off-by: Jesse Barnes Signed-off-by: Keith Packard --- drivers/gpu/drm/i915/intel_display.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c index 8f7ed73..32c8c95 100644 --- a/drivers/gpu/drm/i915/intel_display.c +++ b/drivers/gpu/drm/i915/intel_display.c @@ -4994,7 +4994,7 @@ static int ironlake_crtc_mode_set(struct drm_crtc *crtc, } else if (is_sdvo && is_tv) factor = 20; - if (clock.m1 < factor * clock.n) + if (clock.m < factor * clock.n) fp |= FP_CB_TUNE; dpll = 0; -- 1.7.5.4