| Message ID | 20111116083643.GA25612@mwanda |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
2011/11/16 Dan Carpenter <dan.carpenter@oracle.com>: > dev_queue_xmit() consumes its own skb, so the call to dev_kfree_skb() > in lowpan_fragment_xmit() is a double free. > > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> > --- > v2: fixed commit message. > > diff --git a/net/ieee802154/6lowpan.c b/net/ieee802154/6lowpan.c > index 602f318..e4ecc1e 100644 > --- a/net/ieee802154/6lowpan.c > +++ b/net/ieee802154/6lowpan.c > @@ -980,9 +980,6 @@ lowpan_fragment_xmit(struct sk_buff *skb, u8 *head, > > ret = dev_queue_xmit(frag); > > - if (ret < 0) > - dev_kfree_skb(frag); > - > return ret; > } > > > Acked-by: Alexander Smirnov <alex.bluesman.smirnov@gmail.com> -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
From: Alexander Smirnov <alex.bluesman.smirnov@gmail.com> Date: Wed, 16 Nov 2011 11:42:07 +0300 > 2011/11/16 Dan Carpenter <dan.carpenter@oracle.com>: >> dev_queue_xmit() consumes its own skb, so the call to dev_kfree_skb() >> in lowpan_fragment_xmit() is a double free. >> >> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> ... > > Acked-by: Alexander Smirnov <alex.bluesman.smirnov@gmail.com> Applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/net/ieee802154/6lowpan.c b/net/ieee802154/6lowpan.c index 602f318..e4ecc1e 100644 --- a/net/ieee802154/6lowpan.c +++ b/net/ieee802154/6lowpan.c @@ -980,9 +980,6 @@ lowpan_fragment_xmit(struct sk_buff *skb, u8 *head, ret = dev_queue_xmit(frag); - if (ret < 0) - dev_kfree_skb(frag); - return ret; }
dev_queue_xmit() consumes its own skb, so the call to dev_kfree_skb() in lowpan_fragment_xmit() is a double free. Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> --- v2: fixed commit message.