| Message ID | 20200321180838.12729-1-iamkeyur96@gmail.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | rtc: bd70528: Avoid double error messaging when IRQ absent | expand |
On 21/03/2020 14:08:37-0400, Keyur Patel wrote: > Since the commit 7723f4c ("driver core: platform: Add an error message > to platform_get_irq*()") platform_get_irq() started issuing an error message. > Thus, there is no need to have the same in the driver. > > Signed-off-by: Keyur Patel <iamkeyur96@gmail.com> > --- > drivers/rtc/rtc-bd70528.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > Applied, thanks.
diff --git a/drivers/rtc/rtc-bd70528.c b/drivers/rtc/rtc-bd70528.c index bbbb1f07c91f..4492b770422c 100644 --- a/drivers/rtc/rtc-bd70528.c +++ b/drivers/rtc/rtc-bd70528.c @@ -542,10 +542,8 @@ static int bd70528_probe(struct platform_device *pdev) irq = platform_get_irq_byname(pdev, irq_name); - if (irq < 0) { - dev_err(&pdev->dev, "Failed to get irq\n"); + if (irq < 0) return irq; - } platform_set_drvdata(pdev, bd_rtc);
Since the commit 7723f4c ("driver core: platform: Add an error message to platform_get_irq*()") platform_get_irq() started issuing an error message. Thus, there is no need to have the same in the driver. Signed-off-by: Keyur Patel <iamkeyur96@gmail.com> --- drivers/rtc/rtc-bd70528.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)