| Message ID | 20111116082138.GA10264@elgon.mountain |
|---|---|
| State | Superseded, archived |
| Delegated to: | David Miller |
| Headers | show |
On Wed, Nov 16, 2011 at 11:21:38AM +0300, Dan Carpenter wrote: > dev_queue_xmit() consumes its own skb, so the call to dev_kfree_skb() > ieee802154/6lowpan.clowpan_fragment_xmits a double free. ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Dur... I messed up my commit message right before sending. Will resend. regards, dan carpenter
diff --git a/net/ieee802154/6lowpan.c b/net/ieee802154/6lowpan.c index 602f318..e4ecc1e 100644 --- a/net/ieee802154/6lowpan.c +++ b/net/ieee802154/6lowpan.c @@ -980,9 +980,6 @@ lowpan_fragment_xmit(struct sk_buff *skb, u8 *head, ret = dev_queue_xmit(frag); - if (ret < 0) - dev_kfree_skb(frag); - return ret; }
dev_queue_xmit() consumes its own skb, so the call to dev_kfree_skb() ieee802154/6lowpan.clowpan_fragment_xmits a double free. Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html