Patchwork [U-Boot,03/19] 4xx_enet.c: Fix GCC 4.6 build warnings

login
register
mail settings
Submitter Stefan Roese
Date Nov. 15, 2011, 6:01 p.m.
Message ID <1321380118-6257-1-git-send-email-sr@denx.de>
Download mbox | patch
Permalink /patch/125835/
State Accepted
Commit f0813ab128a6f3e651454f4fca39bce32c90fe62
Headers show

Comments

Stefan Roese - Nov. 15, 2011, 6:01 p.m.
Fix:
4xx_enet.c: In function 'ppc_4xx_eth_init':
4xx_enet.c:875:6: warning: variable 'ethgroup' set but not used [-Wunused-but-set-variable]

I used "__maybe_unused" here intentionally, since all other
alternatives to fix this compilation warning would result in more
ifdef's.

Signed-off-by: Stefan Roese <sr@denx.de>
---
 drivers/net/4xx_enet.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)
Wolfgang Denk - Nov. 16, 2011, 8:14 p.m.
Dear Stefan Roese,

In message <1321380118-6257-1-git-send-email-sr@denx.de> you wrote:
> Fix:
> 4xx_enet.c: In function 'ppc_4xx_eth_init':
> 4xx_enet.c:875:6: warning: variable 'ethgroup' set but not used [-Wunused-but-set-variable]
> 
> I used "__maybe_unused" here intentionally, since all other
> alternatives to fix this compilation warning would result in more
> ifdef's.
> 
> Signed-off-by: Stefan Roese <sr@denx.de>
> ---
>  drivers/net/4xx_enet.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)

Applied, thanks.

Best regards,

Wolfgang Denk

Patch

diff --git a/drivers/net/4xx_enet.c b/drivers/net/4xx_enet.c
index a771139..73700dd 100644
--- a/drivers/net/4xx_enet.c
+++ b/drivers/net/4xx_enet.c
@@ -92,6 +92,7 @@ 
 #include <asm/ppc4xx-mal.h>
 #include <miiphy.h>
 #include <malloc.h>
+#include <linux/compiler.h>
 
 #if !(defined(CONFIG_MII) || defined(CONFIG_CMD_MII))
 #error "CONFIG_MII has to be defined!"
@@ -872,7 +873,7 @@  static int ppc_4xx_eth_init (struct eth_device *dev, bd_t * bis)
     defined(CONFIG_440EPX) || defined(CONFIG_440GRX) || \
     defined(CONFIG_460EX) || defined(CONFIG_460GT) || \
     defined(CONFIG_405EX)
-	int ethgroup = -1;
+	__maybe_unused int ethgroup = -1;
 #endif
 #endif
 	u32 bd_cached;