From patchwork Tue Nov 15 11:13:54 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Benoit Canet X-Patchwork-Id: 125762 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [140.186.70.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 41E01B6F7F for ; Tue, 15 Nov 2011 23:15:11 +1100 (EST) Received: from localhost ([::1]:59312 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RQGz1-0002QJ-8C for incoming@patchwork.ozlabs.org; Tue, 15 Nov 2011 06:15:19 -0500 Received: from eggs.gnu.org ([140.186.70.92]:38703) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RQGy6-000801-MI for qemu-devel@nongnu.org; Tue, 15 Nov 2011 06:14:26 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RQGxx-0000Kz-S7 for qemu-devel@nongnu.org; Tue, 15 Nov 2011 06:14:22 -0500 Received: from mail-wy0-f173.google.com ([74.125.82.173]:37244) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RQGxx-0000KS-Kk for qemu-devel@nongnu.org; Tue, 15 Nov 2011 06:14:13 -0500 Received: by mail-wy0-f173.google.com with SMTP id 34so1821973wyg.4 for ; Tue, 15 Nov 2011 03:14:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references; bh=d7oLGJ3WNAkbKavnyM4EwHgYDyuGbScRfkF6P8MRiIc=; b=oix1VxrINfr6C2XtyxyHDVqYdoVQaF+Z1qZn8TN6286TyTNpoOON68PrGMwzfXpY6p 87QtvbdOGPkKVdsMgLiz98Lx3vl3wu+moi9chxpWNw2IuSnpvoRh3YZxQOv54fMg6T4x VLkjLscWNaEYHhGqpTRqMxE00EmwDMKwjprCY= Received: by 10.227.60.85 with SMTP id o21mr18665498wbh.0.1321355653114; Tue, 15 Nov 2011 03:14:13 -0800 (PST) Received: from Laure.box.in.chocolate-blue.net ([109.190.18.76]) by mx.google.com with ESMTPS id n18sm12476201wbm.19.2011.11.15.03.14.12 (version=SSLv3 cipher=OTHER); Tue, 15 Nov 2011 03:14:12 -0800 (PST) From: =?UTF-8?q?Beno=C3=AEt=20Canet?= To: qemu-devel@nongnu.org Date: Tue, 15 Nov 2011 12:13:54 +0100 Message-Id: <1321355644-1982-5-git-send-email-benoit.canet@gmail.com> X-Mailer: git-send-email 1.7.5.4 In-Reply-To: <1321355644-1982-1-git-send-email-benoit.canet@gmail.com> References: <1321355644-1982-1-git-send-email-benoit.canet@gmail.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 74.125.82.173 Cc: blauwirbel@gmail.com, =?UTF-8?q?Beno=C3=AEt=20Canet?= , avi@redhat.com Subject: [Qemu-devel] [PATCH 04/14] slavio_misc: convert modem to memory API X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Signed-off-by: Benoit Canet --- hw/slavio_misc.c | 31 +++++++++++++++---------------- 1 files changed, 15 insertions(+), 16 deletions(-) diff --git a/hw/slavio_misc.c b/hw/slavio_misc.c index 60a115d..9110c64 100644 --- a/hw/slavio_misc.c +++ b/hw/slavio_misc.c @@ -38,6 +38,7 @@ typedef struct MiscState { SysBusDevice busdev; MemoryRegion cfg_iomem; MemoryRegion diag_iomem; + MemoryRegion mdm_iomem; qemu_irq irq; qemu_irq fdc_tc; uint32_t dummy; @@ -164,7 +165,7 @@ static const MemoryRegionOps slavio_diag_mem_ops = { }; static void slavio_mdm_mem_writeb(void *opaque, target_phys_addr_t addr, - uint32_t val) + uint64_t val, unsigned size) { MiscState *s = opaque; @@ -172,7 +173,8 @@ static void slavio_mdm_mem_writeb(void *opaque, target_phys_addr_t addr, s->mctrl = val & 0xff; } -static uint32_t slavio_mdm_mem_readb(void *opaque, target_phys_addr_t addr) +static uint64_t slavio_mdm_mem_readb(void *opaque, target_phys_addr_t addr, + unsigned size) { MiscState *s = opaque; uint32_t ret = 0; @@ -182,16 +184,14 @@ static uint32_t slavio_mdm_mem_readb(void *opaque, target_phys_addr_t addr) return ret; } -static CPUReadMemoryFunc * const slavio_mdm_mem_read[3] = { - slavio_mdm_mem_readb, - NULL, - NULL, -}; - -static CPUWriteMemoryFunc * const slavio_mdm_mem_write[3] = { - slavio_mdm_mem_writeb, - NULL, - NULL, +static const MemoryRegionOps slavio_mdm_mem_ops = { + .read = slavio_mdm_mem_readb, + .write = slavio_mdm_mem_writeb, + .endianness = DEVICE_NATIVE_ENDIAN, + .valid = { + .min_access_size = 1, + .max_access_size = 1, + }, }; static void slavio_aux1_mem_writeb(void *opaque, target_phys_addr_t addr, @@ -438,10 +438,9 @@ static int slavio_misc_init1(SysBusDevice *dev) sysbus_init_mmio_region(dev, &s->diag_iomem); /* Modem control */ - io = cpu_register_io_memory(slavio_mdm_mem_read, - slavio_mdm_mem_write, s, - DEVICE_NATIVE_ENDIAN); - sysbus_init_mmio(dev, MISC_SIZE, io); + memory_region_init_io(&s->mdm_iomem, &slavio_mdm_mem_ops, s, + "modem", MISC_SIZE); + sysbus_init_mmio_region(dev, &s->mdm_iomem); /* 16 bit registers */ /* ss600mp diag LEDs */