| Message ID | 1584545013-19859-1-git-send-email-clabbe@baylibre.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | phy: tegra: should select USB_PHY | expand |
Reviewed-by: Nagarjuna Kristam <nkristam@nvidia.com> On 18-03-2020 20:53, Corentin Labbe wrote: > External email: Use caution opening links or attachments > > > I have hit the following build error: > armv7a-hardfloat-linux-gnueabi-ld: drivers/phy/tegra/xusb.o: in function `tegra_xusb_port_unregister': > xusb.c:(.text+0x2ac): undefined reference to `usb_remove_phy' > armv7a-hardfloat-linux-gnueabi-ld: drivers/phy/tegra/xusb.o: in function `tegra_xusb_setup_ports': > xusb.c:(.text+0xf30): undefined reference to `usb_add_phy_dev' > > PHY_TEGRA_XUSB should select USB_PHY > > Fixes: 23babe30fb45d ("phy: tegra: xusb: Add usb-phy support") > Cc: stable <stable@vger.kernel.org> > Signed-off-by: Corentin Labbe <clabbe@baylibre.com> > --- > drivers/phy/tegra/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/phy/tegra/Kconfig b/drivers/phy/tegra/Kconfig > index df07c4dea059..a208aca4ba7b 100644 > --- a/drivers/phy/tegra/Kconfig > +++ b/drivers/phy/tegra/Kconfig > @@ -3,6 +3,7 @@ config PHY_TEGRA_XUSB > tristate "NVIDIA Tegra XUSB pad controller driver" > depends on ARCH_TEGRA > select USB_CONN_GPIO > + select USB_PHY > help > Choose this option if you have an NVIDIA Tegra SoC. > > -- > 2.24.1 >
diff --git a/drivers/phy/tegra/Kconfig b/drivers/phy/tegra/Kconfig index df07c4dea059..a208aca4ba7b 100644 --- a/drivers/phy/tegra/Kconfig +++ b/drivers/phy/tegra/Kconfig @@ -3,6 +3,7 @@ config PHY_TEGRA_XUSB tristate "NVIDIA Tegra XUSB pad controller driver" depends on ARCH_TEGRA select USB_CONN_GPIO + select USB_PHY help Choose this option if you have an NVIDIA Tegra SoC.
I have hit the following build error: armv7a-hardfloat-linux-gnueabi-ld: drivers/phy/tegra/xusb.o: in function `tegra_xusb_port_unregister': xusb.c:(.text+0x2ac): undefined reference to `usb_remove_phy' armv7a-hardfloat-linux-gnueabi-ld: drivers/phy/tegra/xusb.o: in function `tegra_xusb_setup_ports': xusb.c:(.text+0xf30): undefined reference to `usb_add_phy_dev' PHY_TEGRA_XUSB should select USB_PHY Fixes: 23babe30fb45d ("phy: tegra: xusb: Add usb-phy support") Cc: stable <stable@vger.kernel.org> Signed-off-by: Corentin Labbe <clabbe@baylibre.com> --- drivers/phy/tegra/Kconfig | 1 + 1 file changed, 1 insertion(+)