| Message ID | 1321348755-26221-3-git-send-email-wg@denx.de |
|---|---|
| State | Accepted |
| Commit | 0d9679e65a59fd05d9c7d554a7e304590366f390 |
| Delegated to: | Stefano Babic |
| Headers | show |
Acked-by: Mike Frysinger <vapier@gentoo.org>
-mike
On Tue, Nov 15, 2011 at 1:19 AM, Wolfgang Grandegger <wg@denx.de> wrote: > Cc: Simon Glass <sjg@chromium.org> > Cc: Mike Frysinger <vapier@gentoo.org> > Signed-off-by: Wolfgang Grandegger <wg@denx.de> > --- > drivers/usb/eth/smsc95xx.c | 10 +++------- > 1 files changed, 3 insertions(+), 7 deletions(-) Acked-by: Simon Glass <sjg@chromium.org> > > diff --git a/drivers/usb/eth/smsc95xx.c b/drivers/usb/eth/smsc95xx.c > index b5626e6..2f63340 100644 > --- a/drivers/usb/eth/smsc95xx.c > +++ b/drivers/usb/eth/smsc95xx.c > @@ -380,18 +380,14 @@ static int smsc95xx_write_hwaddr(struct eth_device *eth) > /* set hardware address */ > debug("** %s()\n", __func__); > ret = smsc95xx_write_reg(dev, ADDRL, addr_lo); > - if (ret < 0) { > - debug("Failed to write ADDRL: %d\n", ret); > + if (ret < 0) > return ret; > - } > > ret = smsc95xx_write_reg(dev, ADDRH, addr_hi); > if (ret < 0) > return ret; > - debug("MAC %02x:%02x:%02x:%02x:%02x:%02x\n", > - eth->enetaddr[0], eth->enetaddr[1], > - eth->enetaddr[2], eth->enetaddr[3], > - eth->enetaddr[4], eth->enetaddr[5]); > + > + debug("MAC %pM\n", eth->enetaddr); > dev->have_hwaddr = 1; > return 0; > } > -- > 1.7.4.1 > >
Hi Simon, On 11/16/2011 12:22 AM, Simon Glass wrote: > On Tue, Nov 15, 2011 at 1:19 AM, Wolfgang Grandegger <wg@denx.de> wrote: >> Cc: Simon Glass <sjg@chromium.org> >> Cc: Mike Frysinger <vapier@gentoo.org> >> Signed-off-by: Wolfgang Grandegger <wg@denx.de> >> --- >> drivers/usb/eth/smsc95xx.c | 10 +++------- >> 1 files changed, 3 insertions(+), 7 deletions(-) > > Acked-by: Simon Glass <sjg@chromium.org> Thanks. Who will take care of these patches? Do you know? Wolfgang.
On 21/11/2011 11:49, Wolfgang Grandegger wrote: > Hi Simon, > > On 11/16/2011 12:22 AM, Simon Glass wrote: >> On Tue, Nov 15, 2011 at 1:19 AM, Wolfgang Grandegger <wg@denx.de> wrote: >>> Cc: Simon Glass <sjg@chromium.org> >>> Cc: Mike Frysinger <vapier@gentoo.org> >>> Signed-off-by: Wolfgang Grandegger <wg@denx.de> >>> --- >>> drivers/usb/eth/smsc95xx.c | 10 +++------- >>> 1 files changed, 3 insertions(+), 7 deletions(-) >> >> Acked-by: Simon Glass <sjg@chromium.org> > > Thanks. Who will take care of these patches? Do you know? > > Wolfgang. > _______________________________________________ > U-Boot mailing list > U-Boot@lists.denx.de > http://lists.denx.de/mailman/listinfo/u-boot > Hi Wolfgang, I have already merged your patches into u-boot-staging, sbabic@denx.de branch, and sent a pull request to Wolfgang (Denk). Best regards, Stefano Babic
On 15/11/2011 10:19, Wolfgang Grandegger wrote: > Cc: Simon Glass <sjg@chromium.org> > Cc: Mike Frysinger <vapier@gentoo.org> > Signed-off-by: Wolfgang Grandegger <wg@denx.de> > --- Applied to u-boot-staging, sbabic@denx.de, thanks. Best regards, Stefano Babic
diff --git a/drivers/usb/eth/smsc95xx.c b/drivers/usb/eth/smsc95xx.c index b5626e6..2f63340 100644 --- a/drivers/usb/eth/smsc95xx.c +++ b/drivers/usb/eth/smsc95xx.c @@ -380,18 +380,14 @@ static int smsc95xx_write_hwaddr(struct eth_device *eth) /* set hardware address */ debug("** %s()\n", __func__); ret = smsc95xx_write_reg(dev, ADDRL, addr_lo); - if (ret < 0) { - debug("Failed to write ADDRL: %d\n", ret); + if (ret < 0) return ret; - } ret = smsc95xx_write_reg(dev, ADDRH, addr_hi); if (ret < 0) return ret; - debug("MAC %02x:%02x:%02x:%02x:%02x:%02x\n", - eth->enetaddr[0], eth->enetaddr[1], - eth->enetaddr[2], eth->enetaddr[3], - eth->enetaddr[4], eth->enetaddr[5]); + + debug("MAC %pM\n", eth->enetaddr); dev->have_hwaddr = 1; return 0; }
Cc: Simon Glass <sjg@chromium.org> Cc: Mike Frysinger <vapier@gentoo.org> Signed-off-by: Wolfgang Grandegger <wg@denx.de> --- drivers/usb/eth/smsc95xx.c | 10 +++------- 1 files changed, 3 insertions(+), 7 deletions(-)