diff mbox

ipv4: return NET_RX_DROP when arp_rcv drops the received packet.

Message ID 1321322987-16042-1-git-send-email-roy.qing.li@gmail.com
State Rejected, archived
Delegated to: David Miller
Headers show

Commit Message

Li RongQing Nov. 15, 2011, 2:09 a.m. UTC 
From: RongQing.Li <roy.qing.li@gmail.com>

return NET_RX_DROP when arp_rcv drops the received packet.

Signed-off-by: RongQing.Li <roy.qing.li@gmail.com>
---
 net/ipv4/arp.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Comments

David Miller Nov. 15, 2011, 9:47 p.m. UTC | #1 
From: roy.qing.li@gmail.com
Date: Tue, 15 Nov 2011 10:09:47 +0800

> From: RongQing.Li <roy.qing.li@gmail.com>
> 
> return NET_RX_DROP when arp_rcv drops the received packet.
> 
> Signed-off-by: RongQing.Li <roy.qing.li@gmail.com>

This is not appropriate.

NET_RX_DROP means that the packet was dropped because something about
the packet's contents were not acceptable, or the packet violated our
policies so was dropped.

In this arp_rcv() case, we would have accepted the packet, but we had
a memory allocation error.  This memory allocation error has nothing
to do with the packet's contents, and is a transient issue.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/net/ipv4/arp.c b/net/ipv4/arp.c
index d732827..9967385 100644
--- a/net/ipv4/arp.c
+++ b/net/ipv4/arp.c
@@ -969,7 +969,7 @@  static int arp_rcv(struct sk_buff *skb, struct net_device *dev,
 freeskb:
 	kfree_skb(skb);
 out_of_mem:
-	return 0;
+	return NET_RX_DROP;
 }
 
 /*