| Message ID | 1321318357-17723-1-git-send-email-grundler@chromium.org |
|---|---|
| State | Rejected, archived |
| Delegated to: | David Miller |
| Headers | show |
On Mon, 14 Nov 2011 16:52:37 PST, Grant Grundler said: > -#define DRIVER_VERSION "26-Sep-2011" > +#define DRIVER_VERSION "08-Nov-2011" Aren't these sort of things more than a tad silly for an in-kernel driver?
On 11/15/2011 04:29 PM, Valdis.Kletnieks@vt.edu wrote: > On Mon, 14 Nov 2011 16:52:37 PST, Grant Grundler said: > >> -#define DRIVER_VERSION "26-Sep-2011" >> +#define DRIVER_VERSION "08-Nov-2011" > > Aren't these sort of things more than a tad silly for an in-kernel driver? Probably depends on whether or not a distro back-ports something from upstream. rick jones -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, Nov 15, 2011 at 4:29 PM, <Valdis.Kletnieks@vt.edu> wrote: > On Mon, 14 Nov 2011 16:52:37 PST, Grant Grundler said: > >> -#define DRIVER_VERSION "26-Sep-2011" >> +#define DRIVER_VERSION "08-Nov-2011" > > Aren't these sort of things more than a tad silly for an in-kernel driver? Definitely not. Supporting linux device drivers essentially requires some mechanism like this. We could use anything (SHA1, Mayan Calendar, etc). This driver happens to use a ISO-like date code. Upstream drivers are routinely back ported to distro releases. Version is the primary means for a vendor (like ASIX) to determine what was back ported. Distro maintainers and 1st tier support organizations also need to track versions and "ethtool -i" is the canonical way to look this up on a running system. grant -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, 15 Nov 2011 17:37:47 PST, Grant Grundler said: > Upstream drivers are routinely back ported to distro releases. Version > is the primary means for a vendor (like ASIX) to determine what was > back ported. Distro maintainers and 1st tier support organizations > also need to track versions and "ethtool -i" is the canonical way to > look this up on a running system. Oh, OK. I figured the distro would know what they backported based on the kernel version they generated - I forgot that sometimes users will bypass the distro and go to the upstream vendor, and you may not know what their distro had done...
diff --git a/drivers/net/usb/asix.c b/drivers/net/usb/asix.c --- a/drivers/net/usb/asix.c +++ b/drivers/net/usb/asix.c @@ -36,7 +36,7 @@ #include <linux/usb/usbnet.h> #include <linux/slab.h> -#define DRIVER_VERSION "26-Sep-2011" +#define DRIVER_VERSION "08-Nov-2011" #define DRIVER_NAME "asix" /* ASIX AX8817X based USB 2.0 Ethernet Devices */
Update VERSION to reflect previous changes. Signed-off-by: Grant Grundler <grundler@chromium.org> --- -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html