[v4,04/27] sata_promise: use ata_cable_sata()

Message ID	20200317144333.2904-5-b.zolnierkie@samsung.com
State	Not Applicable
Delegated to:	David Miller
Headers	show Return-Path: <linux-ide-owner@vger.kernel.org> From: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> To: Jens Axboe <axboe@kernel.dk> Cc: Michael Schmitz <schmitzmic@gmail.com>, Geert Uytterhoeven <geert@linux-m68k.org>, Christoph Hellwig <hch@lst.de>, linux-ide@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-kernel@vger.kernel.org, b.zolnierkie@samsung.com Subject: [PATCH v4 04/27] sata_promise: use ata_cable_sata() Date: Tue, 17 Mar 2020 15:43:10 +0100 Message-Id: <20200317144333.2904-5-b.zolnierkie@samsung.com> In-Reply-To: <20200317144333.2904-1-b.zolnierkie@samsung.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" CMS-TYPE: 201P References: <20200317144333.2904-1-b.zolnierkie@samsung.com> <CGME20200317144342eucas1p2fd5c2e6ff69f8e10496d0468f01f5601@eucas1p2.samsung.com> Sender: linux-ide-owner@vger.kernel.org Precedence: bulk
Series	[v4,01/27] ata: remove stale maintainership information from core code \| expand [v4,01/27] ata: remove stale maintainership information from core code [v4,02/27] ata: expose ncq_enable_prio sysfs attribute only on NCQ capable hosts [v4,03/27] ata: make SATA_PMP option selectable only if any SATA host driver is enabled [v4,04/27] sata_promise: use ata_cable_sata() [v4,05/27] ata: simplify ata_scsiop_inq_89() [v4,06/27] ata: use COMMAND_LINE_SIZE for ata_force_param_buf[] size [v4,07/27] ata: optimize struct ata_force_param size [v4,08/27] ata: optimize ata_scsi_rbuf[] size [v4,09/27] ata: move EXPORT_SYMBOL_GPL()s close to exported code [v4,10/27] ata: remove EXPORT_SYMBOL_GPL()s not used by modules [v4,11/27] ata: fix CodingStyle issues in PATA timings code [v4,12/27] ata: separate PATA timings code from libata-core.c [v4,13/27] ata: add CONFIG_SATA_HOST=n version of ata_ncq_enabled() [v4,14/27] ata: let compiler optimize out ata_dev_config_ncq() on non-SATA hosts [v4,15/27] ata: let compiler optimize out ata_eh_set_lpm() on non-SATA hosts [v4,16/27] ata: start separating SATA specific code from libata-core.c [v4,17/27] ata: move sata_scr_() to libata-sata.c [v4,18/27] ata: move sata_set_spd() to libata-sata.c [v4,19/27] ata: move sata_link_{debounce,resume}() to libata-sata.c [v4,20/27] ata: move sata_link_hardreset() to libata-sata.c [v4,21/27] ata: move ata_qc_complete_multiple() to libata-sata.c [v4,22/27] ata: move sata_deb_timing_() to libata-sata.c [v4,23/27] ata: start separating SATA specific code from libata-scsi.c [v4,24/27] ata: move ata_sas_*() to libata-sata.c [v4,25/27] ata: start separating SATA specific code from libata-eh.c [v4,26/27] ata: move ata_eh_analyze_ncq_error() & co. to libata-sata.c [v4,27/27] ata: make "libata.force" kernel parameter optional

Message ID

20200317144333.2904-5-b.zolnierkie@samsung.com

State

Not Applicable

Delegated to:

David Miller

Headers

From: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
To: Jens Axboe <axboe@kernel.dk>
Cc: Michael Schmitz <schmitzmic@gmail.com>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Christoph Hellwig <hch@lst.de>, linux-ide@vger.kernel.org,
	linux-m68k@lists.linux-m68k.org, linux-kernel@vger.kernel.org,
	b.zolnierkie@samsung.com
Subject: [PATCH v4 04/27] sata_promise: use ata_cable_sata()
Date: Tue, 17 Mar 2020 15:43:10 +0100
Message-Id: <20200317144333.2904-5-b.zolnierkie@samsung.com>
In-Reply-To: <20200317144333.2904-1-b.zolnierkie@samsung.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 201P
References: <20200317144333.2904-1-b.zolnierkie@samsung.com>
	<CGME20200317144342eucas1p2fd5c2e6ff69f8e10496d0468f01f5601@eucas1p2.samsung.com>
Sender: linux-ide-owner@vger.kernel.org
Precedence: bulk

Series

[v4,01/27] ata: remove stale maintainership information from core code | expand

Use core helper instead of open-coding it. Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> --- drivers/ata/sata_promise.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-)

Comments

Christoph Hellwig March 26, 2020, 9:46 a.m. UTC | #1

On Tue, Mar 17, 2020 at 03:43:10PM +0100, Bartlomiej Zolnierkiewicz wrote:
> Use core helper instead of open-coding it.
> 
> Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>

Looks good,

Reviewed-by: Christoph Hellwig <hch@lst.de>

diff --git a/drivers/ata/sata_promise.c b/drivers/ata/sata_promise.c
index c451d7d1c817..8729f78cef5f 100644
--- a/drivers/ata/sata_promise.c
+++ b/drivers/ata/sata_promise.c
@@ -157,7 +157,6 @@  static int pdc_sata_hardreset(struct ata_link *link, unsigned int *class,
 static void pdc_error_handler(struct ata_port *ap);
 static void pdc_post_internal_cmd(struct ata_queued_cmd *qc);
 static int pdc_pata_cable_detect(struct ata_port *ap);
-static int pdc_sata_cable_detect(struct ata_port *ap);
 
 static struct scsi_host_template pdc_ata_sht = {
 	ATA_BASE_SHT(DRV_NAME),
@@ -183,7 +182,7 @@  static const struct ata_port_operations pdc_common_ops = {
 
 static struct ata_port_operations pdc_sata_ops = {
 	.inherits		= &pdc_common_ops,
-	.cable_detect		= pdc_sata_cable_detect,
+	.cable_detect		= ata_cable_sata,
 	.freeze			= pdc_sata_freeze,
 	.thaw			= pdc_sata_thaw,
 	.scr_read		= pdc_sata_scr_read,
@@ -459,11 +458,6 @@  static int pdc_pata_cable_detect(struct ata_port *ap)
 	return ATA_CBL_PATA80;
 }
 
-static int pdc_sata_cable_detect(struct ata_port *ap)
-{
-	return ATA_CBL_SATA;
-}
-
 static int pdc_sata_scr_read(struct ata_link *link,
 			     unsigned int sc_reg, u32 *val)
 {

[v4,04/27] sata_promise: use ata_cable_sata()

Commit Message

Comments

Patch